Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026043Openbravo ERPA. Platformpublic2014-03-20 13:062014-03-22 04:14
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q2Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2013-02-26
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^]
Triggers an Emergency PackNo
Summary0026043: blur triggers selector ds request without pagination
DescriptionHaving focus in a selector field, blur causes a request to datasource without any pagination.

In case of big amount of data this can cause the oom error in server.

This request shouldn't be triggered at all (it was not before SC upgrade)
Steps To Reproduce1. Create a new sales order
2. Add a new line
3. Open product drop down -> see there is a request to ProductByPriceAndWarehouse OK (it includes pagination)
-Select a product in the drop down list -> see there is an additional request: INCORRECT
  * This second request shouldn't be launched at all
  * It has no pagination info

When the selector popup is opened the second request is also performed:
- Instead of step 3, open product selector popup and see 2nd request

By only blurring it is also performede:
1. Open an existing sales order
2. Go to lines and edit
3. Focus on product
4. Move to any other field -> Request is done
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to feature request 0025574 closed dbaz Upgrade SmartClient 10.0d 
related to defect 0018076 closed mtaal On tax rate, the base amount selected value disappears 
has duplicate defect 0018075 closed mtaal Automatic focus change shows only one available option in combo boxes 
related to defect 0026189 closed alostale [PR14Q2] In Business partner combo box, keyed values get deleted 
related to defect 00262383.0PR14Q2 closed alostale Property field on Defined Selector Field tab is not working 
related to defect 0026432 closed alostale can't select a computed column for a property field. 
related to defect 0027088 closed alostale Wrong behavior with obuisel selectors in manual windows 
causes defect 0027619 acknowledged Triage Platform Base Selector picklist is not refreshed if the text is pasted in the editor using the contextual menu 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-20 13:06alostaleNew Issue
2014-03-20 13:06alostaleAssigned To => AugustoMauch
2014-03-20 13:06alostaleModules => Core
2014-03-20 13:06alostaleTriggers an Emergency Pack => No
2014-03-20 13:07alostaleRegression level => Pre packaging ( pi )
2014-03-20 13:07alostaleRegression date => 2013-02-26
2014-03-20 13:07alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^]
2014-03-20 13:07alostaleAssigned ToAugustoMauch => alostale
2014-03-20 13:07alostaleTarget Version => PR14Q2
2014-03-20 13:10alostaleRelationship addedrelated to 0025574
2014-03-20 13:14alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5591#r5591
2014-03-21 08:47alostalePrioritynormal => immediate
2014-03-21 08:47alostaleReview Assigned To => AugustoMauch
2014-03-21 09:02alostaleTag Attached: Performance
2014-03-21 09:43alostaleRelationship addedhas duplicate 0018075
2014-03-21 09:52alostaleRelationship addedrelated to 0018076
2014-03-21 09:54alostaleSummarydouble selector ds request after selection without pagination => blur triggers selector ds request without pagination
2014-03-21 09:54alostaleDescription Updatedbug_revision_view_page.php?rev_id=5601#r5601
2014-03-21 09:54alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5602#r5602
2014-03-21 09:55alostaleNote Added: 0065340
2014-03-21 09:58hgbotCheckin
2014-03-21 09:58hgbotNote Added: 0065341
2014-03-21 09:59hgbotStatusnew => resolved
2014-03-21 09:59hgbotResolutionopen => fixed
2014-03-21 09:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/06c118995adc10ec206f039743ec34585bb34ac6 [^]
2014-03-21 11:16AugustoMauchNote Added: 0065353
2014-03-21 11:16AugustoMauchStatusresolved => closed
2014-03-21 11:16AugustoMauchFixed in Version => PR14Q2
2014-03-22 04:14hudsonbotCheckin
2014-03-22 04:14hudsonbotNote Added: 0065372
2014-04-08 08:50alostaleRelationship addedrelated to 0026189
2014-04-10 14:15alostaleRelationship addedrelated to 0026238
2014-04-30 15:45alostaleRelationship addedrelated to 0026432
2014-07-16 11:19alostaleRelationship addedrelated to 0027088
2014-12-24 14:16AugustoMauchRelationship addedrelated to 0027619
2014-12-24 16:02AugustoMauchRelationship replacedcauses 0027619

Notes
(0065340)
alostale   
2014-03-21 09:55   
Executed test plan:
1. None of the 3 ways of reproducing this issue reported in steps to reproduce triggers request
2. Issues 0018076 and 0018075 are reproducible
(0065341)
hgbot   
2014-03-21 09:58   
Repository: erp/devel/pi
Changeset: 06c118995adc10ec206f039743ec34585bb34ac6
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 21 09:58:08 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/06c118995adc10ec206f039743ec34585bb34ac6 [^]

fixed bug 26043: blur triggers selector ds request without pagination

addUnknownValues property should be false to prevent non-paginated request: http://www.smartclient.com/docs/9.1/a/b/c/go.html#attr..ComboBoxItem.addUnknownValues [^]

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0065353)
AugustoMauch   
2014-03-21 11:16   
Code reviewed and verified in pi@617ac4497332
(0065372)
hudsonbot   
2014-03-22 04:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b70224bef848 [^]
Maturity status: Test