Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025985Openbravo ERPA. Platformpublic2014-03-13 17:002014-05-26 08:59
Reporteralostale 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q3Fixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025985: P&E smarclient datasources are leaked
DescriptionP&E smarclient datasources are leaked.
Steps To Reproduce-In js console execute: var s = scopeleaks.snapshot()
-Open Sales Order window and close it
-In js console execute: scopeleaks.leaks(s)
  -> it returns: ["isc_OBPickAndExecuteDataSource_0"]

It should return []
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0023761 closed inigosanchez Memory leaks on the browser 
related to defect 0025986 closed AugustoMauch notes datasources are leaked 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-13 17:00alostaleNew Issue
2014-03-13 17:00alostaleAssigned To => AugustoMauch
2014-03-13 17:00alostaleModules => Core
2014-03-13 17:00alostaleTriggers an Emergency Pack => No
2014-03-13 17:00alostaleRelationship addedrelated to 0023761
2014-03-13 17:04alostaleRelationship addedrelated to 0025986
2014-03-13 18:13alostaleTag Attached: Performance
2014-03-21 10:58alostaleTarget VersionPR14Q2 => PR14Q3
2014-04-23 15:43shuehnerIssue Monitored: shuehner
2014-05-22 20:28hgbotCheckin
2014-05-22 20:28hgbotNote Added: 0067388
2014-05-22 20:28hgbotStatusnew => resolved
2014-05-22 20:28hgbotResolutionopen => fixed
2014-05-22 20:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1825749c075f1e26819f82851cda79edc0dd96b3 [^]
2014-05-23 07:24hudsonbotCheckin
2014-05-23 07:24hudsonbotNote Added: 0067397
2014-05-26 08:59alostaleReview Assigned To => alostale
2014-05-26 08:59alostaleNote Added: 0067430
2014-05-26 08:59alostaleStatusresolved => closed
2014-05-26 08:59alostaleFixed in Version => PR14Q3

Notes
(0067388)
hgbot   
2014-05-22 20:28   
Repository: erp/devel/pi
Changeset: 1825749c075f1e26819f82851cda79edc0dd96b3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri May 02 14:29:47 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1825749c075f1e26819f82851cda79edc0dd96b3 [^]

[pw3] Datasource of P&E grids is no longer leaked

Fixes issue 25985 https://issues.openbravo.com/view.php?id=25985. [^] The datasource for the grid is now created once the grid is created, not before. Then, when the grid is destroyed, its datasource is also destroyed.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-pick-and-execute-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceComponent.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/templates/datasource.ftl
---
(0067397)
hudsonbot   
2014-05-23 07:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0b934adf82b [^]
Maturity status: Test
(0067430)
alostale   
2014-05-26 08:59   
code reviewed

Tested in Sales Order, Return to Vendor and Return from Customer windows.

Opening and closing the tabs as well as opening P&E window.

In none of the cases leaks were detected.