Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002597Openbravo ERP03. Procurement managementpublic2008-02-06 17:292008-06-12 09:43
Reporteruser71 
Assigned Torafaroda 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionduplicate 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0002597: Pending Goods Receipts: Wrong User/Contact
DescriptionVersión: 2.35MP1 (Oracle)

The process "Procurement Management || Transactions || Pending Goods Receipts" insert a wrong user/contact in the Goods Receipt generated. It insert the user session of Openbravo instead of the user/contact of the order referenced.

To fix this error, you'va to go to the class "org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java" and you only have to replace the next line:

MaterialReceiptPendingData.insert(conn, this, strmInoutId, vars.getClient(), vars.getOrg(), "Y", vars.getUser(), vars.getUser(), "N", strDocumentno, "CO", "DR", "N", "N", "N", docTargetType, data[0].description, data[0].cOrderId, data[0].dateordered, "N", "V+", strDateReceipt, strDateReceipt, data[0].cBpartnerId, data[0].cBpartnerLocationId, data[0].mWarehouseId, data[0].poreference, data[0].deliveryrule, data[0].freightcostrule, data[0].freightamt, data[0].deliveryviarule, data[0].mShipperId, data[0].cChargeId, data[0].chargeamt, data[0].priorityrule, "N", "N", "N", vars.getUser(), data[0].salesrepId, data[0].adOrgtrxId, data[0].cProjectId, data[0].cCampaignId, data[0].cActivityId, data[0].user1Id, data[0].user2Id, "N", "N", "N");

for the next line:

MaterialReceiptPendingData.insert(conn, this, strmInoutId, vars.getClient(), vars.getOrg(), "Y", vars.getUser(), vars.getUser(), "N", strDocumentno, "CO", "DR", "N", "N", "N", docTargetType, data[0].description, data[0].cOrderId, data[0].dateordered, "N", "V+", strDateReceipt, strDateReceipt, data[0].cBpartnerId, data[0].cBpartnerLocationId, data[0].mWarehouseId, data[0].poreference, data[0].deliveryrule, data[0].freightcostrule, data[0].freightamt, data[0].deliveryviarule, data[0].mShipperId, data[0].cChargeId, data[0].chargeamt, data[0].priorityrule, "N", "N", "N", data[0].adUserId, data[0].salesrepId, data[0].adOrgtrxId, data[0].cProjectId, data[0].cCampaignId, data[0].cActivityId, data[0].user1Id, data[0].user2Id, "N", "N", "N");

That is, replace "vars.getUser()" for "data[0].adUserId".

In any case, I attach the file "MaterialReceiptPending.java" modified. The lines are marked by "//FIX BEG MMR 06/02/2008" and "//FIX END MMR 06/02/2008"
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange

Notes
(0006186)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1888016 [^]
(0003156)
rafaroda   
2008-02-06 17:45   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1892190
Originator: NO

Hi,

This bug is duplicated in https://sourceforge.net/tracker/index.php?func=detail&aid=1840377&group_id=162271&atid=823129 [^]

It has been fixed and will display well in R2.40. Take a look at https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java?rev=2222&sc=1 [^]

Thank you very much for your report,

Openbravo Team
(0003157)
user71   
2008-02-06 18:13   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1790723
Originator: YES

Ok, thank you very much.
But in https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java?rev=2222&sc=1 [^]
appears an illegal character (">"N", "N", "N","). You can see it in the next line:

MaterialReceiptPendingData.insert(conn, this, strmInoutId, vars.getClient(), vars.getOrg(), "Y", vars.getUser(), vars.getUser(), "N", strDocumentno, "CO", "DR", "N", "N", "N", docTargetType, data[0].description, data[0].cOrderId, data[0].dateordered, "N", "V+", strDateReceipt, strDateReceipt, data[0].cBpartnerId, data[0].cBpartnerLocationId, data[0].mWarehouseId, data[0].poreference, data[0].deliveryrule, data[0].freightcostrule, data[0].freightamt, data[0].deliveryviarule, data[0].mShipperId, data[0].cChargeId, data[0].chargeamt, data[0].priorityrule, >"N", "N", "N", data[0].adUserId, data[0].salesrepId, data[0].adOrgtrxId, data[0].cProjectId, data[0].cCampaignId, data[0].cActivityId, data[0].user1Id, data[0].user2Id, "N", "N", "N");