Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025936Openbravo ERPA. Platformpublic2014-03-07 19:422014-05-22 17:42
Reporteriperdomo 
Assigned Todbaz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOracle Linux 3.8.13-26.1.1.el6ue
Product Version3.0MP29.1 
Target Version3.0PR14Q3Fixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browserApple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
ModulesUser Interface Client Kernel
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025936: DateTime reference format support hh:mm:ss a
DescriptionThe DateTime reference only supports time format in HH:mm:ss and not hh:mm:ss a

It uses the dateTimeFormat.java from Openbravo.properties, but not handling all cases.
Steps To ReproduceSet the current values in Openbravo.properties

dateFormat.js=%m-%d-%Y
dateFormat.sql=MM-DD-YYYY
dateFormat.java=MM-dd-yyyy
dateTimeFormat.java=MM-dd-yyyy hh:mm:ss a
dateTimeFormat.sql=MM-DD-YYYY HH12:MI:SS AM

bbdd.sessionConfig=ALTER SESSION SET NLS_DATE_FORMAT='MM-DD-YYYY' NLS_NUMERIC_CHARACTERS='.,'

2) Check the values on "Audit" section of any tab, e.g Organization
3) You'll find that the "time" part is missing or is formatted in unexpected way
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate design defect 0024683 closed shankarb Some java date patterns are not supported in Openbravo.properties 
has duplicate design defect 0024791 closed AugustoMauch Is not possible to apply a format different from the standard format for Time fields 
related to design defect 0025155 new AugustoMauch Java Date Format are not supported. 
related to defect 0027028 closed dbaz Different behavior between grid and form showing "Absolute Time" reference 
causes defect 0029687 closed dbaz Is not possible to set the hour 12 in DateTime fields 
Attached Files? SimpleDateFormatTest.java (516) 2014-03-07 19:42
https://issues.openbravo.com/file_download.php?file_id=6736&type=bug
png HHmmss.png (5,805) 2014-03-07 19:43
https://issues.openbravo.com/file_download.php?file_id=6737&type=bug
png

png hhmmssa.png (26,280) 2014-03-07 19:43
https://issues.openbravo.com/file_download.php?file_id=6738&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-03-07 19:42iperdomoNew Issue
2014-03-07 19:42iperdomoAssigned To => AugustoMauch
2014-03-07 19:42iperdomoFile Added: SimpleDateFormatTest.java
2014-03-07 19:42iperdomoWeb browser => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2014-03-07 19:42iperdomoModules => User Interface Client Kernel
2014-03-07 19:42iperdomoTriggers an Emergency Pack => No
2014-03-07 19:43iperdomoFile Added: HHmmss.png
2014-03-07 19:43iperdomoFile Added: hhmmssa.png
2014-03-07 19:45iperdomoNote Added: 0064965
2014-03-11 13:39jonalegriaesarteWeb browserApple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2014-03-11 16:20iperdomoWeb browserApple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2014-03-11 16:20iperdomoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5560#r5560
2014-03-17 08:18alostaleRelationship addedrelated to 0024683
2014-05-12 09:46alostaleAssigned ToAugustoMauch => dbaz
2014-05-20 13:01alostaleReview Assigned To => alostale
2014-05-20 13:01alostaleWeb browserApple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2014-05-20 13:01alostaleTypedefect => feature request
2014-05-20 13:01alostaleTarget Version => PR14Q3
2014-05-20 13:02hgbotCheckin
2014-05-20 13:02hgbotNote Added: 0067306
2014-05-20 13:02hgbotStatusnew => resolved
2014-05-20 13:02hgbotResolutionopen => fixed
2014-05-20 13:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/43e598987eb706d4eac832d474b84a1d0b7ac958 [^]
2014-05-20 13:07alostaleNote Added: 0067308
2014-05-20 13:07alostaleStatusresolved => closed
2014-05-20 13:07alostaleFixed in Version => PR14Q3
2014-05-20 13:09alostaleRelationship replacedhas duplicate 0024683
2014-05-20 13:10alostaleRelationship addedhas duplicate 0024791
2014-05-20 13:11alostaleRelationship addedrelated to 0025155
2014-05-21 18:34hudsonbotCheckin
2014-05-21 18:34hudsonbotNote Added: 0067347
2014-05-21 23:59hgbotCheckin
2014-05-21 23:59hgbotNote Added: 0067356
2014-05-22 00:18hgbotCheckin
2014-05-22 00:18hgbotNote Added: 0067358
2014-05-22 00:50hgbotCheckin
2014-05-22 00:50hgbotNote Added: 0067359
2014-05-22 17:42hudsonbotCheckin
2014-05-22 17:42hudsonbotNote Added: 0067381
2014-05-22 17:42hudsonbotCheckin
2014-05-22 17:42hudsonbotNote Added: 0067383
2014-05-22 17:42hudsonbotCheckin
2014-05-22 17:42hudsonbotNote Added: 0067384
2014-07-08 16:29dbazRelationship addedrelated to 0027028
2015-04-24 08:36alostaleRelationship addedrelated to 0029687
2015-04-24 11:36alostaleRelationship replacedcauses 0029687

Notes
(0064965)
iperdomo   
2014-03-07 19:45   
* HHmmss.png file shows the "standard" way of representing time on a datetime reference
* hhmmssa.png file shows a wrong behavior when using `MM-dd-yyyy hh:mm:ss a` as the datetime format
(0067306)
hgbot   
2014-05-20 13:02   
Repository: erp/devel/pi
Changeset: 43e598987eb706d4eac832d474b84a1d0b7ac958
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu May 15 23:49:40 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/43e598987eb706d4eac832d474b84a1d0b7ac958 [^]

Fixed issue 25936: Added 'javaTimeformat.java=MM-dd-yyyy hh:mm:ss a' capability

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-datetime.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-form-styles.css
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/AbsoluteTimeUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/DateUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/TimeUIDefinition.java
M src/index.jsp
---
(0067308)
alostale   
2014-05-20 13:07   
Code reviewed.

Executed test cases:

with the following values for dateTimeFormat.java property (and their corresponding dateFormat.java)

MM-dd-yyyy hh:mm:ss a
yyyy-MM-dd hh:mm:ss a
dd-MM-yyyy hh:mm:ss a
MM-dd-yyyy HH:mm:ss
yyyy-MM-dd HH:mm:ss
dd-MM-yyyy HH:mm:ss

In all these cases verified:
-time and date time (absolute and relative) references show the proper format both in grid and form views
-date time picker shows AM/PM picker in case of 12h
-time completion works in all the cases:
  * 10 -> is converted to 10:00:00 AM or 10:00:00 depending on format
  * 22 -> is converted to 10:00:00 PM or 22:00:00 depending on format
  * 10am -> is converted to 10:00:00 AM or 10:00:00 depending on format
  * 10pm -> is converted to 10:00:00 PM or 22:00:00 depending on format
(0067347)
hudsonbot   
2014-05-21 18:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/30be5c8a933a [^]
Maturity status: Test
(0067356)
hgbot   
2014-05-21 23:59   
Repository: erp/devel/pi
Changeset: 4083ef59b102e4a1c4ee59e3f1f1440c719fcb3a
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed May 21 23:58:53 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4083ef59b102e4a1c4ee59e3f1f1440c719fcb3a [^]

Related to issue 25936 and Fixed issue 26644: Removed custom function
'endsWith' implemented by Smartclint to ensure that standalone files work properly with other libraries

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-datetime.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
---
(0067358)
hgbot   
2014-05-22 00:18   
Repository: erp/devel/pi
Changeset: 6395bf98637f8b9ef2c39075f2e533c3500ed9ac
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu May 22 00:17:51 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6395bf98637f8b9ef2c39075f2e533c3500ed9ac [^]

Related to issue 25936: Sidestep Smartclient functions
to ensure that standalone files work properly with other libraries

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
---
(0067359)
hgbot   
2014-05-22 00:50   
Repository: erp/devel/pi
Changeset: f6338addf510fc4564073891d9d816c258f99488
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu May 22 00:50:25 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f6338addf510fc4564073891d9d816c258f99488 [^]

Related to issue 25936: Sidestep Smartclient functions
to ensure that standalone files work properly with other libraries - microfix

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
---
(0067381)
hudsonbot   
2014-05-22 17:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1f80725ff7f4 [^]
Maturity status: Test
(0067383)
hudsonbot   
2014-05-22 17:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1f80725ff7f4 [^]
Maturity status: Test
(0067384)
hudsonbot   
2014-05-22 17:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1f80725ff7f4 [^]
Maturity status: Test