|
Notes |
|
|
(0064887)
|
|
alostale
|
2014-03-06 08:45
(edited on: 2014-03-06 08:47) |
|
Problem:
When quick launch popup is being closed focus is set in the quick launch widget (why?). After SC upgrade, pressing enter to select the item in the drop down causes it to be detected as click event in the widget, opening it again just after closing.
Solution:
Don't set focus in the widget.
Test Plan:
-Both for Quick Launch and Create New launchers:
* Select item by typing and pressing enter
* Select item with mouse
In all the cases popup should be closed after item is selected.
|
|
|
|
(0064888)
|
|
hgbot
|
|
2014-03-06 08:50
|
|
Repository: erp/devel/pi
Changeset: 823fbf69dcf74ba770f0e5900f442bac284542b8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 06 08:50:29 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/823fbf69dcf74ba770f0e5900f442bac284542b8 [^]
fixed bug 25910: quick launch popup is not closed when item is selected
Do not set focus on QuickRun when closing, as in some cases enter click to
select an item in the drop down is captured after the focus set causing the
launcher to be reopened.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quickrun-widget.js
---
|
|
|
|
|
|
|
|
(0065244)
|
|
dbaz
|
|
2014-03-18 01:14
|
|
The fix brokes another thing (at least in Chrome):
With the focus in the "Workspace" tab, if you press CTRL + O, the "Quick Launch" is opened. If you press CTRL + O again, the "Quick Launch" is closed.
Now it comes the problem: if you press CTRL + O again the native browser "Open" view is opened. It didn't happen before the fix.
The problem is that once the quick launch is closed the first time, the focus is lost (no element in the page has the focus), so the focus is in the browser itself and keyboard shortcuts are not captured. |
|
|
|
(0065253)
|
|
hgbot
|
|
2014-03-18 11:11
|
|
Repository: erp/devel/pi
Changeset: 56436da527ee599c3d5e74394c25bbb2713aa2db
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 18 11:11:05 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/56436da527ee599c3d5e74394c25bbb2713aa2db [^]
fixed bug 25910: quick launch popup is not closed when item is selected
Focus needs to be reset in order to make keyboard shortcuts work
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quickrun-widget.js
---
|
|
|
|
|
New fix resets focus with some delay, this makes shortcuts work.
Tested explained test plan before and shortcuts opening the launcher manually and through shortcut. |
|
|
|
|
|
|
|
(0065361)
|
|
dbaz
|
|
2014-03-21 15:26
|
|
With the focus in the "Workspace" tab, if you do a "long" CTRL+O press (or leave the CTRL+O pressed indefinitely), the native browser "Open" view is opened. It didn't happen in MP31.
Theoretically something that could fix the issue is before the 'setTimeout', set the focus in some place that is for sure that will exist and is able to accept the focus. Then the timeout will change it to the previous focused element. The most important thing is to ensure that at any single moment the focus is inside the application. |
|
|
|
(0065385)
|
|
hgbot
|
|
2014-03-24 11:56
|
|
Repository: erp/devel/pi
Changeset: 69c758824b3e22ac0ac0adf3751ebb5e0f4d95c3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Mar 24 11:56:34 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/69c758824b3e22ac0ac0adf3751ebb5e0f4d95c3 [^]
fixed bug 25910: prevent continous CRTL-O to open browser's open dialog
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quickrun-widget.js
---
|
|
|
|
(0065415)
|
|
hgbot
|
|
2014-03-25 10:25
|
|
Repository: erp/devel/pi
Changeset: a07f840d54afaa17822f6e4be4a18b996409b2fc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 25 10:24:01 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a07f840d54afaa17822f6e4be4a18b996409b2fc [^]
fixed bug 26078, related to bug 25910: fixed CI
CI was failing due to the timeout introduced in quick run widget in order to
prevent quick launch to be kept open just after selecting an item.
This caused sync test to fail as it was closing and opening profile widget without
waiting the 50ms defined in the timeout.
Current patch adds this timeout just to quick launch and not to all quick run widgets
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quickrun-widget.js
---
|
|
|
|
(0065430)
|
|
dbaz
|
|
2014-03-25 16:20
|
|
Reviewed @ changeset: 22767 - 1dcbf92e17e9
A changeset due to code-review is still pending. |
|
|
|
(0065438)
|
|
hgbot
|
|
2014-03-25 18:09
|
|
Repository: erp/devel/pi
Changeset: 82c2bef68eed5d5fc2bfd518ff69a29f6fa3abb4
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 25 18:09:00 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/82c2bef68eed5d5fc2bfd518ff69a29f6fa3abb4 [^]
related to bug 25910: return super value
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|