Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025880Retail ModulesWeb POSpublic2014-03-03 12:482014-03-28 13:25
Reportermarvintm 
Assigned Tomalsasua 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR14Q2 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025880: Even if the preference to change the discounts button is set, the button can still be used to create a manual discount
DescriptionEven if the preference Web POS Open Discounts from Keyboard is set, there is a way to add a manual discount. This should not be the case.
Steps To Reproduce- Set the Web POS Open Discounts from Keyboard preference.
- Go to the Web POS. Add some lines.
- Click on the Discounts button. Notice that the Web POS navigates to the Receipt Discounts tab. This is correct.
- Add 100 with the keyboard and click on the "Enter" key. Notice that one of the lines is changed so that the price is 0. This should not happen, as you have set the preference, so there should be no way to add a manual discount.
Proposed SolutionThe command to add a manual discount should be completely disabled if the preference is set.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-03 12:48marvintmNew Issue
2014-03-03 12:48marvintmAssigned To => malsasua
2014-03-03 12:48marvintmTriggers an Emergency Pack => No
2014-03-03 17:54hgbotCheckin
2014-03-03 17:54hgbotNote Added: 0064763
2014-03-03 17:54hgbotStatusnew => resolved
2014-03-03 17:54hgbotResolutionopen => fixed
2014-03-03 17:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f832dcde3681f98b1087b4be4d983fb73d623be5 [^]
2014-03-04 12:51marvintmReview Assigned To => marvintm
2014-03-04 12:51marvintmStatusresolved => closed
2014-03-04 12:51marvintmFixed in Version => RMP32
2014-03-05 12:50hgbotCheckin
2014-03-05 12:50hgbotNote Added: 0064822
2014-03-05 12:50hgbotStatusclosed => resolved
2014-03-05 12:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f832dcde3681f98b1087b4be4d983fb73d623be5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/f832dcde3681f98b1087b4be4d983fb73d623be5 [^]
2014-03-28 13:25migueldejuanaReview Assigned Tomarvintm => migueldejuana
2014-03-28 13:25migueldejuanaNote Added: 0065579
2014-03-28 13:25migueldejuanaStatusresolved => closed

Notes
(0064763)
hgbot   
2014-03-03 17:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f832dcde3681f98b1087b4be4d983fb73d623be5
Author: Rafa de Miguel <rafael.demiguel <at> openbravo.com>
Date: Mon Mar 03 17:53:18 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f832dcde3681f98b1087b4be4d983fb73d623be5 [^]

fixed issue 25880: Even if the preference to change the discounts button is set, the button can still be used to create a manual discount

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0064822)
hgbot   
2014-03-05 12:50   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: f832dcde3681f98b1087b4be4d983fb73d623be5
Author: Rafa de Miguel <rafael.demiguel <at> openbravo.com>
Date: Mon Mar 03 17:53:18 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/f832dcde3681f98b1087b4be4d983fb73d623be5 [^]

fixed issue 25880: Even if the preference to change the discounts button is set, the button can still be used to create a manual discount

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0065579)
migueldejuana   
2014-03-28 13:25   
tested and reviewed in c32dc0bbefd6