Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025844Retail ModulesReturn Receiptpublic2014-02-26 11:532014-03-28 12:36
Reporterrafademiguel 
Assigned Togorkaion 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR14Q2 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025844: Check "Has enough change" fails when required cash is more than 999
DescriptionThere is one check:

hasEnoughChange = OB.DEC.compare(OB.DEC.sub(currentCash, requiredcash)) >= 0;

So for example when you have;

currentCash: 3141.64
requiredcash: "2,128.10"

You receive this error:

Uncaught BigDecimal(): Not a number: 2,,,1,2,8,.,1,0 bigdecimal-1.0.1.min.js:14

Notice that requiredcash is a string with a coma instead of a number
Steps To ReproduceTry to return an order with an amount more than 999.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-02-26 11:53rafademiguelNew Issue
2014-02-26 11:53rafademiguelAssigned To => gorkaion
2014-02-26 11:53rafademiguelTriggers an Emergency Pack => No
2014-02-26 17:23hgbotCheckin
2014-02-26 17:23hgbotNote Added: 0064630
2014-02-26 17:23hgbotStatusnew => resolved
2014-02-26 17:23hgbotResolutionopen => fixed
2014-02-26 17:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e279939d5227e22afa790773e148a91a4496db39 [^]
2014-02-26 17:26hgbotCheckin
2014-02-26 17:26hgbotNote Added: 0064633
2014-02-26 17:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e279939d5227e22afa790773e148a91a4496db39 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/e279939d5227e22afa790773e148a91a4496db39 [^]
2014-03-28 12:36migueldejuanaReview Assigned To => migueldejuana
2014-03-28 12:36migueldejuanaNote Added: 0065573
2014-03-28 12:36migueldejuanaStatusresolved => closed
2014-03-28 12:36migueldejuanaFixed in Version => RR14Q2

Notes
(0064630)
hgbot   
2014-02-26 17:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e279939d5227e22afa790773e148a91a4496db39
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Feb 26 17:17:43 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e279939d5227e22afa790773e148a91a4496db39 [^]

Fixed issue 25844.Use a proper numeric object on check cash.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0064633)
hgbot   
2014-02-26 17:26   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: e279939d5227e22afa790773e148a91a4496db39
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Feb 26 17:17:43 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/e279939d5227e22afa790773e148a91a4496db39 [^]

Fixed issue 25844.Use a proper numeric object on check cash.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0065573)
migueldejuana   
2014-03-28 12:36   
Tested and reviewed in c32dc0bbefd6