Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025826Retail ModulesWeb POSpublic2014-02-25 09:592014-03-28 13:59
Reportermarvintm 
Assigned Tomarvintm 
PriorityimmediateSeveritycriticalReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR14Q2 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025826: Under some circumstances, a failure in a Web POS process may leave the instance triggers in a soft disabled state
DescriptionIt seems that under some circumstances, a failure in some Web POS processes may leave all the instance triggers in a soft disabled state.

The reason for this is that in some cases the TriggerHandler class is being used to disable and enable triggers, but the enable part is not being executed in a finally block, so in some cases it's possible that the insertion which happens in the disable part is committed to the database.

In that case, all triggers would be disabled for all the processes.
Steps To ReproduceIt's not currently clear how to reproduce this issue, but it has happened in a customer environment.
Proposed SolutionThe code will be reviewed and changed to ensure that it's not possible for this to happen again, for example moving all call to enable the triggers to finally blocks.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-02-25 09:59marvintmNew Issue
2014-02-25 09:59marvintmAssigned To => marvintm
2014-02-25 09:59marvintmTriggers an Emergency Pack => No
2014-02-25 12:37hgbotCheckin
2014-02-25 12:37hgbotNote Added: 0064559
2014-02-25 12:37hgbotStatusnew => resolved
2014-02-25 12:37hgbotResolutionopen => fixed
2014-02-25 12:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3c3d1efa659d7188e9f81515a9fd3d218fe4aa1 [^]
2014-02-25 12:49hgbotCheckin
2014-02-25 12:49hgbotNote Added: 0064560
2014-02-25 12:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3c3d1efa659d7188e9f81515a9fd3d218fe4aa1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/5df7191460e6807ac31d3b151fc1ab23759a09ce [^]
2014-02-26 10:45hgbotCheckin
2014-02-26 10:45hgbotNote Added: 0064597
2014-02-26 10:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/5df7191460e6807ac31d3b151fc1ab23759a09ce [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/c3c3d1efa659d7188e9f81515a9fd3d218fe4aa1 [^]
2014-03-28 13:59adrianromeroReview Assigned To => adrianromero
2014-03-28 13:59adrianromeroNote Added: 0065587
2014-03-28 13:59adrianromeroStatusresolved => closed
2014-03-28 13:59adrianromeroFixed in Version => RR14Q2

Notes
(0064559)
hgbot   
2014-02-25 12:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c3c3d1efa659d7188e9f81515a9fd3d218fe4aa1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Feb 25 06:37:32 2014 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3c3d1efa659d7188e9f81515a9fd3d218fe4aa1 [^]

Fixed issue 25826. A failed cashup will no longer create a soft disabling of all triggers in the instance

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---
(0064560)
hgbot   
2014-02-25 12:49   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: 5df7191460e6807ac31d3b151fc1ab23759a09ce
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Feb 25 06:37:32 2014 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/5df7191460e6807ac31d3b151fc1ab23759a09ce [^]

Fixed issue 25826. A failed cashup will no longer create a soft disabling of all triggers in the instance

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---
(0064597)
hgbot   
2014-02-26 10:45   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: c3c3d1efa659d7188e9f81515a9fd3d218fe4aa1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Feb 25 06:37:32 2014 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/c3c3d1efa659d7188e9f81515a9fd3d218fe4aa1 [^]

Fixed issue 25826. A failed cashup will no longer create a soft disabling of all triggers in the instance

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---
(0065587)
adrianromero   
2014-03-28 13:59   
Reviewed