Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0025673 | Openbravo ERP | 09. Financial management | public | 2014-02-06 01:42 | 2014-05-07 18:10 |
|
| Reporter | egoitz | |
| Assigned To | AtulOpenbravo | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 3.0MP31 | |
| Target Version | 3.0PR14Q3 | Fixed in Version | 3.0PR14Q3 | |
| Merge Request Status | |
| Review Assigned To | egoitz |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0025673: Posting a gl journal takes long when the journal is a opening journal with thousands of lines |
| Description | Posting a gl journal takes long when the journal is a opening journal with thousands of lines (3000)
and also with thoused of lines on the fact_acct table (511718) |
| Steps To Reproduce | -Create a new gl_journal batch
-Create a gl journal header with opening=Y
-Add 3000 lines.
-Process
-Post
*It takes long to finish posting the process.
The problem is with the following update:
if (m_docVO.m_IsOpening.equals("Y"))
FactLineData.updateFactAcct(con, conn, m_AD_Table_ID, m_Record_ID);
It takes arround 1 second for each line when there are many lines on the fact_acct table (511718 rows)
|
| Proposed Solution | |
| Additional Information | |
| Tags | Performance |
| Relationships | |
| Attached Files |  bug25673.option2.diff (1,106) 2014-02-06 01:45
https://issues.openbravo.com/file_download.php?file_id=6690&type=bug
bug25673.option1_complete.diff (2,475) 2014-03-06 17:47
https://issues.openbravo.com/file_download.php?file_id=6735&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2014-02-06 01:42 | egoitz | New Issue | |
| 2014-02-06 01:42 | egoitz | Assigned To | => dmiguelez |
| 2014-02-06 01:42 | egoitz | Modules | => Core |
| 2014-02-06 01:42 | egoitz | Resolution time | => 1392591600 |
| 2014-02-06 01:42 | egoitz | Triggers an Emergency Pack | => No |
| 2014-02-06 01:44 | egoitz | File Added: bug25673.option1.diff | |
| 2014-02-06 01:45 | egoitz | File Added: bug25673.option2.diff | |
| 2014-02-06 01:45 | egoitz | Tag Attached: Performance | |
| 2014-02-06 01:45 | egoitz | Assigned To | dmiguelez => jonalegriaesarte |
| 2014-02-19 12:53 | jonalegriaesarte | Assigned To | jonalegriaesarte => pramakrishnan |
| 2014-03-06 17:47 | jonalegriaesarte | File Added: bug25673.option1_complete.diff | |
| 2014-03-06 17:47 | jonalegriaesarte | Note Added: 0064938 | |
| 2014-03-12 10:22 | jonalegriaesarte | Resolution time | 1392591600 => 1395010800 |
| 2014-03-17 11:52 | AtulOpenbravo | Assigned To | pramakrishnan => AtulOpenbravo |
| 2014-03-17 11:52 | AtulOpenbravo | Status | new => scheduled |
| 2014-03-17 11:52 | AtulOpenbravo | fix_in_branch | => pi |
| 2014-03-17 11:53 | egoitz | File Deleted: bug25673.option1.diff | |
| 2014-03-17 17:03 | AtulOpenbravo | Note Added: 0065234 | |
| 2014-03-31 16:17 | jonalegriaesarte | Target Version | PR14Q2 => PR14Q3 |
| 2014-04-01 15:15 | AtulOpenbravo | Review Assigned To | => egoitz |
| 2014-04-01 15:15 | AtulOpenbravo | fix_in_branch | pi => |
| 2014-04-01 15:16 | hgbot | Checkin | |
| 2014-04-01 15:16 | hgbot | Note Added: 0065670 | |
| 2014-04-01 15:17 | hgbot | Status | scheduled => resolved |
| 2014-04-01 15:17 | hgbot | Resolution | open => fixed |
| 2014-04-01 15:17 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/9e49204adcd47b45e38bf74ffc50ddfcf8702acb [^] |
| 2014-04-01 16:07 | egoitz | Note Added: 0065671 | |
| 2014-04-01 16:07 | egoitz | Status | resolved => closed |
| 2014-04-01 16:07 | egoitz | Fixed in Version | => PR14Q3 |
| 2014-05-07 18:10 | hudsonbot | Checkin | |
| 2014-05-07 18:10 | hudsonbot | Note Added: 0066869 | |
|
Notes |
|
|
|
|
Added new version of the first patch that completes the solution. option1 was wrong because is some cases, the factaccttype was null |
|
|
|
|
Test Plan
- Login as F&B International Group Admin.
- Create a new Journal Batch.
- Create a Journal Header by keeping Opening flag as checked.
- Create as many as multiple of thousands Journal Lines.
- Complete Journal Header and post it.
- Notice that document gets posted in less time as compare to steps to reproduce. |
|
|
|
(0065670)
|
|
hgbot
|
|
2014-04-01 15:16
|
|
Repository: erp/devel/pi
Changeset: 9e49204adcd47b45e38bf74ffc50ddfcf8702acb
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 17 17:58:11 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9e49204adcd47b45e38bf74ffc50ddfcf8702acb [^]
Fixes Issue 25673 Posting opening journal (thousand lines) takes long time
---
M src/org/openbravo/erpCommon/ad_forms/FactLine.java
M src/org/openbravo/erpCommon/ad_forms/FactLine_data.xsql
---
|
|
|
|
(0065671)
|
|
egoitz
|
|
2014-04-01 16:07
|
|
|
|
|
|
|