Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025636Openbravo ERPA. Platformpublic2014-02-03 10:332014-02-12 18:30
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q2Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-11-07
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/cd5e1a38c069995d64d183c4e4e6d41259f5bed9 [^]
Triggers an Emergency PackNo
Summary0025636: Saved view filter reapplied after adding a column in grid
DescriptionHaving a saved view that includes a filter. When this filter is removed and a new column is added to grid the filter is reapplied.
Steps To Reproduce-In a professional instance
-Open Sales Order window, remove default filter, filter docno: 1000001
-Save view and set as default
-Close Sales Order window and reopen it -> it appears filtered (OK)
-Click on funnel icon to remove filters (see issue 0025634)
-Show a new column in grid
  *Filter defined in the saved view is applied again
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0024687 closed dbaz Double DataSource request when there using a saved view 
related to defect 0023333 closed shankarb Direct link to view does not work when a filter is active 
related to defect 00227303.0MP20 closed mtaal Tab appears blank when it has a view defined 
related to defect 00256353.0PR14Q2 closed alostale FK drop down restriction is kept after removing saved view filter 
related to defect 0025972 closed alostale incorrect navigation to windows with default saved view 
blocks defect 00256343.0PR14Q2 closed alostale Funnel icon is kept after removing filters defined in a saved view 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-02-03 10:33alostaleNew Issue
2014-02-03 10:33alostaleAssigned To => AugustoMauch
2014-02-03 10:33alostaleModules => Core
2014-02-03 10:33alostaleTriggers an Emergency Pack => No
2014-02-03 10:34alostaleRelationship addedblocks 0025634
2014-02-03 10:34alostaleRelationship addedrelated to 0025635
2014-02-03 10:42alostaleRegression level => Production - QA Approved
2014-02-03 10:42alostaleNote Added: 0063848
2014-02-03 10:42alostalePrioritynormal => immediate
2014-02-03 18:42AugustoMauchRegression levelProduction - QA Approved => Production - Confirmed Stable
2014-02-03 18:42AugustoMauchRegression date => 2013-11-07
2014-02-03 18:42AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/cd5e1a38c069995d64d183c4e4e6d41259f5bed9 [^]
2014-02-04 15:26alostaleRelationship addedrelated to 0024687
2014-02-04 15:27alostaleAssigned ToAugustoMauch => alostale
2014-02-04 15:28alostaleRelationship addedrelated to 0023333
2014-02-04 15:29alostaleRelationship addedrelated to 0022730
2014-02-04 16:03alostaleNote Added: 0063890
2014-02-04 16:13hgbotCheckin
2014-02-04 16:13hgbotNote Added: 0063893
2014-02-04 16:13hgbotStatusnew => resolved
2014-02-04 16:13hgbotResolutionopen => fixed
2014-02-04 16:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e698ee97b844cfac10002299da1281ca8ee08789 [^]
2014-02-04 16:14alostaleReview Assigned To => dbaz
2014-02-04 20:29dbazNote Added: 0063901
2014-02-04 20:29dbazStatusresolved => closed
2014-02-04 20:29dbazFixed in Version => 3.0MP32
2014-02-12 18:30hudsonbotCheckin
2014-02-12 18:30hudsonbotNote Added: 0064158
2014-03-12 15:27alostaleRelationship addedrelated to 0025972

Notes
(0063848)
alostale   
2014-02-03 10:42   
Regression: works fine in mp27
(0063890)
alostale   
2014-02-04 16:03   
The problem is introduced by fix for issue 0024687. Now when there is a saved view with criteria, this criteria is saved in view.initialCriteria and it is never removed. When getting criteria, initialCriteria is applied in case there is no other criteria, this was happening in the 3 reported cases.

Executed test cases:
-Adding a new column doesn't add the filter defined in the saved view
-Clicking the funnel icon removes filter and the icon is also removed 0025634
-Removing filter shows all available items in FK drop down 0025635
-Direct links with criteria to windows with saved views with criteria apply url's criteria instead of saved one 0023333
-Issue 0022730 is not reproduced after this fix
(0063893)
hgbot   
2014-02-04 16:13   
Repository: erp/devel/pi
Changeset: e698ee97b844cfac10002299da1281ca8ee08789
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 04 16:12:14 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e698ee97b844cfac10002299da1281ca8ee08789 [^]

fixed bug 25634, fixed bug 25635, fixed bug 25636

  Proper management of filtering removal within windows with saved views that
  include filtering.

  This filtering was preserved in initialCriteria which was retrieved after filter
  was removed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0063901)
dbaz   
2014-02-04 20:29   
Reviewed @ changeset: 21915 - 5915bbb61611
(0064158)
hudsonbot   
2014-02-12 18:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d1a5bb862230 [^]
Maturity status: Test