Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025623Retail ModulesReturn Receiptpublic2014-01-31 11:532015-03-30 19:06
Reporterjecharri 
Assigned Tomigueldejuana 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q2 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025623: It is possible to return more quantity than sold quantity
DescriptionIt is possible to return more quantity than sold quantity
Steps To Reproduce-Go to Web POS
-Create a ticket
-Go to "verified returns" and choose the order
-Return the order
-Go again to "verified returns" and choose the order

Verify that you can return again the order.
Proposed SolutionIt will be fantastic if Web POS will be able to manage returned quantities
Additional Information
TagsNo tags attached.
Relationships
has duplicate feature request 0028133 closed marvintm Ability to register which tickets has been already returned in verified returns window 
has duplicate defect 0025239 closed marvintm RMP29: System wrongly allows the user to return more than the ordered qty using return receipt option. 
related to defect 0028109 closed migueldejuana [RR14Q4] system wrongly allows user to return more than the ordered quantity using verified returns option 
related to defect 0025607RR14Q2 closed rafademiguel Impossible to do a return 
blocks defect 0029071 closed migueldejuana Error in receipt synchronization with verified returns and one line with two shipments lines 
blocks feature request 0028933RR16Q1 closed Retail QA: RR15Q2: Add tests for Mobile applications 
blocks feature request 0029305 new migueldejuana Convert the table in the Verified Return popup, to a ScrollableTable 
Attached Filesdiff issue25623posterminal.diff (8,835) 2014-12-18 15:42
https://issues.openbravo.com/file_download.php?file_id=7620&type=bug
diff issue25623returns.diff (10,313) 2014-12-18 15:43
https://issues.openbravo.com/file_download.php?file_id=7621&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-01-31 11:53jecharriNew Issue
2014-01-31 11:53jecharriAssigned To => migueldejuana
2014-01-31 11:53jecharriTriggers an Emergency Pack => No
2014-12-16 12:47migueldejuanaRelationship addedrelated to 0028109
2014-12-17 08:41hgbotCheckin
2014-12-17 08:41hgbotNote Added: 0072585
2014-12-17 08:41hgbotStatusnew => resolved
2014-12-17 08:41hgbotResolutionopen => fixed
2014-12-17 08:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9cedc9f8875f455e51a1ac84dc406e8db4f05be7 [^]
2014-12-17 08:43hgbotCheckin
2014-12-17 08:43hgbotNote Added: 0072587
2014-12-17 08:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9cedc9f8875f455e51a1ac84dc406e8db4f05be7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c87714948a7ab6b9b3c975d99801cf6e81753b51 [^]
2014-12-17 08:43hgbotCheckin
2014-12-17 08:43hgbotNote Added: 0072589
2014-12-18 08:36hgbotCheckin
2014-12-18 08:36hgbotNote Added: 0072685
2014-12-18 08:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c87714948a7ab6b9b3c975d99801cf6e81753b51 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/6c1cbab998a97a24813bde01f76e78f521593c82 [^]
2014-12-18 09:47hgbotCheckin
2014-12-18 09:47hgbotNote Added: 0072689
2014-12-18 09:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/6c1cbab998a97a24813bde01f76e78f521593c82 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6d1c376b2f92f8aaba5ad16efd897ede52a75e9 [^]
2014-12-18 12:26migueldejuanaNote Added: 0072693
2014-12-18 12:26migueldejuanaStatusresolved => new
2014-12-18 12:26migueldejuanaResolutionfixed => open
2014-12-18 15:42migueldejuanaFile Added: issue25623posterminal.diff
2014-12-18 15:43migueldejuanaFile Added: issue25623returns.diff
2014-12-18 15:43migueldejuanaNote Added: 0072700
2015-02-03 13:13hgbotCheckin
2015-02-03 13:13hgbotNote Added: 0074023
2015-02-03 13:13hgbotStatusnew => resolved
2015-02-03 13:13hgbotResolutionopen => fixed
2015-02-03 13:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6d1c376b2f92f8aaba5ad16efd897ede52a75e9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/023c72711778723356443b7c1701d9f507b708fd [^]
2015-02-03 13:16hgbotCheckin
2015-02-03 13:16hgbotNote Added: 0074024
2015-02-03 13:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/023c72711778723356443b7c1701d9f507b708fd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/6b679d56a723203d5104d69387f29041570cffc1 [^]
2015-02-03 13:19hgbotCheckin
2015-02-03 13:19hgbotNote Added: 0074025
2015-02-03 13:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/6b679d56a723203d5104d69387f29041570cffc1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fef8f75cb69fcd24994f3e5e08a03a02286bd65d [^]
2015-02-03 13:20migueldejuanaRelationship addedrelated to 0025607
2015-02-03 16:38hgbotCheckin
2015-02-03 16:38hgbotNote Added: 0074038
2015-02-03 16:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fef8f75cb69fcd24994f3e5e08a03a02286bd65d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/3502d1bf3d09e0a525600600b626d7b681c7df51 [^]
2015-02-03 17:12hgbotCheckin
2015-02-03 17:12hgbotNote Added: 0074040
2015-02-03 17:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/3502d1bf3d09e0a525600600b626d7b681c7df51 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/434ce0eb610d37e4277feb2ee755966bd0854bb0 [^]
2015-02-04 13:00hgbotCheckin
2015-02-04 13:00hgbotNote Added: 0074079
2015-02-04 13:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/434ce0eb610d37e4277feb2ee755966bd0854bb0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bf37fb9fcbdad12e82c02512ba92bce99021c7 [^]
2015-02-04 13:00hgbotCheckin
2015-02-04 13:00hgbotNote Added: 0074080
2015-02-04 13:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bf37fb9fcbdad12e82c02512ba92bce99021c7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5d98503334defd16f94094f97025925fb54c21a3 [^]
2015-02-04 13:03hgbotCheckin
2015-02-04 13:03hgbotNote Added: 0074081
2015-02-04 13:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5d98503334defd16f94094f97025925fb54c21a3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/2b06261bbd7b6d1b1d73ce44a910ca11cb28fe8e [^]
2015-02-04 13:04hgbotCheckin
2015-02-04 13:04hgbotNote Added: 0074082
2015-02-04 13:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/2b06261bbd7b6d1b1d73ce44a910ca11cb28fe8e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a6fa9a0a45fb7137cede3bb2c5b0c6ab7c8c1d28 [^]
2015-02-16 19:10dmitry_mezentsevRelationship addedhas duplicate 0028133
2015-02-26 17:30dmitry_mezentsevNote Added: 0074978
2015-03-05 09:54hgbotCheckin
2015-03-05 09:54hgbotNote Added: 0075184
2015-03-05 09:56hgbotCheckin
2015-03-05 09:56hgbotNote Added: 0075185
2015-03-06 12:53migueldejuanaRelationship addedblocks 0029071
2015-03-06 12:54migueldejuanaNote Added: 0075242
2015-03-06 12:54migueldejuanaStatusresolved => new
2015-03-06 12:54migueldejuanaResolutionfixed => open
2015-03-08 00:06OrekariaRelationship addedblocks 0028933
2015-03-10 13:29migueldejuanaStatusnew => scheduled
2015-03-10 13:29migueldejuanaStatusscheduled => resolved
2015-03-10 13:29migueldejuanaResolutionopen => fixed
2015-03-16 11:49OrekariaNote Added: 0075615
2015-03-16 11:49OrekariaStatusresolved => new
2015-03-16 11:49OrekariaResolutionfixed => open
2015-03-16 11:49OrekariaNote Edited: 0075615bug_revision_view_page.php?bugnote_id=0075615#r7977
2015-03-16 12:57OrekariaNote Added: 0075621
2015-03-16 12:58OrekariaNote Edited: 0075621bug_revision_view_page.php?bugnote_id=0075621#r7979
2015-03-16 23:14hgbotCheckin
2015-03-16 23:14hgbotNote Added: 0075665
2015-03-16 23:32OrekariaRelationship addedblocks 0029305
2015-03-17 00:15hgbotCheckin
2015-03-17 00:15hgbotNote Added: 0075671
2015-03-30 12:28marvintmNote Added: 0076132
2015-03-30 12:29migueldejuanaNote Added: 0076133
2015-03-30 12:32hgbotCheckin
2015-03-30 12:32hgbotNote Added: 0076134
2015-03-30 12:32hgbotStatusnew => resolved
2015-03-30 12:32hgbotResolutionopen => fixed
2015-03-30 12:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a6fa9a0a45fb7137cede3bb2c5b0c6ab7c8c1d28 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5d57d572170920bf774872884e82cf8bd6f8e348 [^]
2015-03-30 15:00OrekariaReview Assigned To => Orekaria
2015-03-30 15:00OrekariaStatusresolved => closed
2015-03-30 15:00OrekariaFixed in Version => RR15Q3
2015-03-30 15:01OrekariaFixed in VersionRR15Q3 => RR15Q2
2015-03-30 19:06OrekariaNote Added: 0076156
2016-07-20 15:21marvintmRelationship addedhas duplicate 0025239

Notes
(0072585)
hgbot   
2014-12-17 08:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9cedc9f8875f455e51a1ac84dc406e8db4f05be7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Dec 16 12:48:03 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9cedc9f8875f455e51a1ac84dc406e8db4f05be7 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity and fixed issue 0028109: [RR14Q4] system wrongly allows user to return more than the ordered quantity using verified returns option

Do not allow to return more than ordered.

---
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M src/org/openbravo/retail/posterminal/PaidReceiptsHeader.java
A src/org/openbravo/retail/posterminal/PaidReceiptShipLinesProperties.java
---
(0072587)
hgbot   
2014-12-17 08:43   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: c87714948a7ab6b9b3c975d99801cf6e81753b51
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Dec 16 13:03:01 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c87714948a7ab6b9b3c975d99801cf6e81753b51 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity and fixed issue 0028109: [RR14Q4] system wrongly allows user to return more than the ordered quantity using verified returns option

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0072589)
hgbot   
2014-12-17 08:43   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 3d05d868ea07c403fd9a4386a026f5e80de9b669
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Dec 17 08:33:25 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/3d05d868ea07c403fd9a4386a026f5e80de9b669 [^]

Related to issue 0025623 and related to issue 0028109: Change few things for automated test

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0072685)
hgbot   
2014-12-18 08:36   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 6c1cbab998a97a24813bde01f76e78f521593c82
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Dec 18 08:35:50 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/6c1cbab998a97a24813bde01f76e78f521593c82 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity and fixed issue 0028109: [RR14Q4] system wrongly allows user to return more than the ordered quantity using verified returns option

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0072689)
hgbot   
2014-12-18 09:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e6d1c376b2f92f8aaba5ad16efd897ede52a75e9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Dec 18 08:35:19 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6d1c376b2f92f8aaba5ad16efd897ede52a75e9 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity and fixed issue 0028109: [RR14Q4] system wrongly allows user to return more than the ordered quantity using verified returns option

---
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptShipLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0072693)
migueldejuana   
2014-12-18 12:26   
Backed out. Target Q2.
(0072700)
migueldejuana   
2014-12-18 15:43   
Patches uploaded to push them in January
(0074023)
hgbot   
2015-02-03 13:13   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 023c72711778723356443b7c1701d9f507b708fd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 03 13:13:24 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/023c72711778723356443b7c1701d9f507b708fd [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

Adding an image for fully returned lines background

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
A web/org.openbravo.mobile.core/assets/img/fullyReturned.png
---
(0074024)
hgbot   
2015-02-03 13:16   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 6b679d56a723203d5104d69387f29041570cffc1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 03 13:16:15 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/6b679d56a723203d5104d69387f29041570cffc1 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

Check returned qty for orders and show just pending to return qty

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0074025)
hgbot   
2015-02-03 13:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fef8f75cb69fcd24994f3e5e08a03a02286bd65d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 03 13:19:09 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fef8f75cb69fcd24994f3e5e08a03a02286bd65d [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

Check returned qty for orders and show just pending to return qty

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
A src/org/openbravo/retail/posterminal/PaidReceiptShipLinesProperties.java
---
(0074038)
hgbot   
2015-02-03 16:38   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 3502d1bf3d09e0a525600600b626d7b681c7df51
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 03 16:38:27 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/3502d1bf3d09e0a525600600b626d7b681c7df51 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

Check returned qty for orders and show just pending to return qty

---
M src/org/openbravo/retail/returns/ReturnsShipmentOrderLoaderHook.java
---
(0074040)
hgbot   
2015-02-03 17:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 434ce0eb610d37e4277feb2ee755966bd0854bb0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 03 17:11:47 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/434ce0eb610d37e4277feb2ee755966bd0854bb0 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

Send client and organization to overwrite the by default preference

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0074079)
hgbot   
2015-02-04 13:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 42bf37fb9fcbdad12e82c02512ba92bce99021c7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 04 12:59:37 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bf37fb9fcbdad12e82c02512ba92bce99021c7 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

---
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptShipLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
---
(0074080)
hgbot   
2015-02-04 13:00   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 5d98503334defd16f94094f97025925fb54c21a3
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 04 13:00:33 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5d98503334defd16f94094f97025925fb54c21a3 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0074081)
hgbot   
2015-02-04 13:03   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 2b06261bbd7b6d1b1d73ce44a910ca11cb28fe8e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 04 13:03:08 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/2b06261bbd7b6d1b1d73ce44a910ca11cb28fe8e [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0074082)
hgbot   
2015-02-04 13:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a6fa9a0a45fb7137cede3bb2c5b0c6ab7c8c1d28
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 04 13:03:46 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a6fa9a0a45fb7137cede3bb2c5b0c6ab7c8c1d28 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

---
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptShipLinesProperties.java
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
---
(0074978)
dmitry_mezentsev   
2015-02-26 17:30   
Guys,
Not closed for 23 days!!!
(0075184)
hgbot   
2015-03-05 09:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7d5086aa2080aa07fa9cfb90fa25bd43b2200a0a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 05 09:53:42 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7d5086aa2080aa07fa9cfb90fa25bd43b2200a0a [^]

Related to issue 0025623: It is possible to return more quantity than sold quantity. UI improvements

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
A web/org.openbravo.mobile.core/assets/img/iconReturned.png
---
(0075185)
hgbot   
2015-03-05 09:56   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: a57f8253e0ef7a0387c183b1dba13aa5dadde01d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 05 09:56:10 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/a57f8253e0ef7a0387c183b1dba13aa5dadde01d [^]

Related to issue 0025623: It is possible to return more quantity than sold quantity. UI improvements

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0075242)
migueldejuana   
2015-03-06 12:54   
It is not working in that case:

https://issues.openbravo.com/view.php?id=29071 [^]
(0075615)
Orekaria   
2015-03-16 11:49   
When the 'Done' button is tapped, the Amount to be returned change its sign

Steps to reproduce:
- Create a receipt
- Verified Returns ยป select all lines of previous receipt
- tap in total to pay
- tap in the exact amount button (the tick on the right)
- verify that "Exact amount returned" message appears (CORRECT)
- verify that the amount to be returned is the amount of the receipt (CORRECT)
- now, pay attention to the amount just after the "Done" button is tapped
- verify that the amount turns negative (INCORRECT)
(0075621)
Orekaria   
2015-03-16 12:57   
(edited on: 2015-03-16 12:58)
The test creted to verify this issue is failing all the first attempts. See:

https://ci.openbravo.com/view/retail/job/ret-sandbox-test-pgsql/330/artifact/SANDBOX/automation/pi-mobile-sandbox/last-results/ret-sandbox-test-pgsql/screenshots/17%3A17%3A05%20attempt%201%20failed%3A%20I25623_VerifyReturnAvoidMoreThanOrdered.png [^]

Trace:

https://ci.openbravo.com/view/retail/job/ret-sandbox-test-pgsql/330/consoleText [^]
(0075665)
hgbot   
2015-03-16 23:14   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: f62e24605bdbf7b8c5d77f4b5c5120fa4f43bb99
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Mar 16 23:13:21 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/f62e24605bdbf7b8c5d77f4b5c5120fa4f43bb99 [^]

Related to issue 25623: The 'ModalReturnReceipt' creates only 1 'checkboxButtonAll'

The missing name was provoking enyo to create a new id of the object each time the window was opened

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0075671)
hgbot   
2015-03-17 00:15   
Repository: tools/automation/pi-mobile
Changeset: 47d170ef0267cc4bfcad8b8c50fad93f5c27a0af
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Mar 16 12:51:12 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/47d170ef0267cc4bfcad8b8c50fad93f5c27a0af [^]

Related to issue 28933. Verifies issue 25623: Updated and new test

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I25623_VerifiedReturnsAlreadyReturned.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I25623_VerifiedReturnsAvoidMoreThanOrdered.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I25623_VerifyReturnAvoidMoreThanOrdered.java
---
(0076132)
marvintm   
2015-03-30 12:28   
There is one case at least in which it does't work:
- Add four units of one product
- Add a discount of 5%
- Complete the order
- Create a verified return of the order. Return only one unit
- Check the discount. It will be correct.
- Create a verified return of the order again. Return one unit again.
- Verify that the discount is wrong.
(0076133)
migueldejuana   
2015-03-30 12:29   
This last case was introduced in:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c87714948a7a [^]
(0076134)
hgbot   
2015-03-30 12:32   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 5d57d572170920bf774872884e82cf8bd6f8e348
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Mar 30 12:32:04 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5d57d572170920bf774872884e82cf8bd6f8e348 [^]

Fixed issue 0025623: It is possible to return more quantity than sold quantity

We need to take into account initial Qty to calculate the discounts instead of remaining qty

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0076156)
Orekaria   
2015-03-30 19:06   
A test should be added to verify the note https://issues.openbravo.com/view.php?id=25623#c76132 [^] by martintm