Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025594Retail ModulesWeb POSpublic2014-01-29 14:522014-03-03 18:39
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q2Fixed in VersionRR14Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025594: rearranging packs can cause lines to be applied with invalid discounts
DescriptionHaving a pack applied and adding a new line that makes this pack to be removed in order to apply a new one, products affected by the first pack but not by the second one are kept with first pack applied.
Steps To Reproduce1. Define these packs:
 *p1
   -priority 1
   -products:
     -Headlamp ultralight, qty:2
     -Avalanche transceiver, qty:1
 *p2
   -priority: 2
   -products:
     -Insect repellent, qty:1
     -Headlamp ultralight, qty:1

2. In POS create a ticket with
    Headlamp ultralight 1
    Avalanche transceiver 1
    Insect repellent 1
  At this point p2 is correctly applied

3. Add 1 unit of Headlamp ultralight
  Avalanche transceiver and Insect repellent are correctly in p2. Pack p1 should have been removed from Headlamp ultralight but it is still present
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? issue-25594.export (1,922) 2014-01-29 15:42
https://issues.openbravo.com/file_download.php?file_id=6666&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-01-29 14:52alostaleNew Issue
2014-01-29 14:52alostaleAssigned To => alostale
2014-01-29 14:52alostaleTriggers an Emergency Pack => No
2014-01-29 14:57alostaleReview Assigned To => guilleaer
2014-01-29 15:42alostaleFile Added: issue-25594.export
2014-01-29 15:42alostaleNote Added: 0063786
2014-01-29 15:59alostaleTarget Version => RMP32
2014-01-29 16:00alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5377#r5377
2014-01-29 16:50hgbotCheckin
2014-01-29 16:50hgbotNote Added: 0063788
2014-01-29 16:50hgbotStatusnew => resolved
2014-01-29 16:50hgbotResolutionopen => fixed
2014-01-29 16:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/03b614663e4d1508d6084ff66eb0c3f1d4499610 [^]
2014-01-29 16:51alostaleStatusresolved => new
2014-01-29 16:51alostaleResolutionfixed => open
2014-02-06 14:30hgbotCheckin
2014-02-06 14:30hgbotNote Added: 0063981
2014-02-06 14:30hgbotStatusnew => resolved
2014-02-06 14:30hgbotResolutionopen => fixed
2014-02-06 14:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/03b614663e4d1508d6084ff66eb0c3f1d4499610 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a20541f3bf964393535063bfb6da80940b780818 [^]
2014-02-06 17:00guilleaerNote Added: 0063995
2014-02-20 15:46hgbotCheckin
2014-02-20 15:46hgbotNote Added: 0064407
2014-02-20 15:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a20541f3bf964393535063bfb6da80940b780818 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/a20541f3bf964393535063bfb6da80940b780818 [^]
2014-02-24 18:41guilleaerNote Added: 0064545
2014-03-03 18:39guilleaerNote Added: 0064768
2014-03-03 18:39guilleaerStatusresolved => closed
2014-03-03 18:39guilleaerFixed in Version => RMP32

Notes
(0063786)
alostale   
2014-01-29 15:42   
attached fix, not pushing it till repos are unfrozen
(0063788)
hgbot   
2014-01-29 16:50   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: 03b614663e4d1508d6084ff66eb0c3f1d4499610
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jan 29 15:41:38 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/03b614663e4d1508d6084ff66eb0c3f1d4499610 [^]

fixed bug 25594: rearranging packs causes lines to have invalid discounts

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
---
(0063981)
hgbot   
2014-02-06 14:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a20541f3bf964393535063bfb6da80940b780818
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jan 29 15:41:38 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a20541f3bf964393535063bfb6da80940b780818 [^]

fixed bug 25594: rearranging packs causes lines to have invalid discounts

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
---
(0063995)
guilleaer   
2014-02-06 17:00   
In this case is not working fine:

1. Define these packs:
 *p1
   -priority 2
   -products:
     -Headlamp ultralight, qty:2
     -Avalanche transceiver, qty:1
 *p2
   -priority: 1
   -products:
     -Insect repellent, qty:1
     -Headlamp ultralight, qty:1

2. In POS create a ticket with
    Headlamp ultralight 1 + 1 = 2
    Avalanche transceiver 1
  At this point p1 is correctly applied to both lines

3. Add 1 unit of Insect Repellent
  expected:
  - Avalanche transceiver shouldn't be affected by any pack
  - 1 unit of headlamp ultralight and insect repellent -> p2
  result:
  - p1 is affecting to Headlamp ultralight (2 units) and Avalanche transceiver
  - nothing is affecting to the 3rd line (Insect repelent)

  Note: With the previous status, if I remove one unit of Headlamp ultralight and then I add 1 unit again all works fine. The same pressing f5
(0064407)
hgbot   
2014-02-20 15:46   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: a20541f3bf964393535063bfb6da80940b780818
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jan 29 15:41:38 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/a20541f3bf964393535063bfb6da80940b780818 [^]

fixed bug 25594: rearranging packs causes lines to have invalid discounts

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
---
(0064545)
guilleaer   
2014-02-24 18:41   
related to the case that I raised in a previous note:

http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/818068f2cc7b7578d2e03210d2d07e8846eb232f [^]
(0064768)
guilleaer   
2014-03-03 18:39   
Verified