Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0025558 | Openbravo ERP | A. Platform | public | 2014-01-24 15:50 | 2014-03-21 10:23 |
|
| Reporter | egoitz | |
| Assigned To | AugustoMauch | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR14Q2 | Fixed in Version | 3.0PR14Q3 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0025558: The callout of the combos on manual forms does not work if you have opened previously other form |
| Description | The callout of the combos on the form does not work if you have opened previously another form, for example, the enterprise module managemente window |
| Steps To Reproduce | -Open the Product movements report
-Find a product with stock having also attribute set.
-See that after select the attribute combo is filled.
-close the form
-Open the enterprise module management window.
-Open again the Product movements report
-Find a product with stock having also attribute set.
*The callout does not work so the combo of attributes does not who values |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0027017 | 3.0PR14Q4 | closed | AugustoMauch | The callout of the combos on manual forms does not work if you have opened previously other form |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2014-01-24 15:50 | egoitz | New Issue | |
| 2014-01-24 15:50 | egoitz | Assigned To | => jonalegriaesarte |
| 2014-02-03 13:23 | egoitz | Project | Modules => Openbravo ERP |
| 2014-02-03 13:27 | egoitz | Review Assigned To | => AugustoMauch |
| 2014-02-03 13:27 | egoitz | Modules | => Core |
| 2014-02-03 13:27 | egoitz | Resolution time | => 1392418800 |
| 2014-02-03 13:27 | egoitz | Triggers an Emergency Pack | => No |
| 2014-02-03 13:27 | egoitz | Category | Tax Report Launcher => A. Platform |
| 2014-02-03 13:27 | egoitz | Summary | The callout of the combos on the form does not work if you have opened previously the enterprise module managemente window => The callout of the combos on manual forms does not work if you have opened previously other form |
| 2014-02-03 13:27 | egoitz | Description Updated | bug_revision_view_page.php?rev_id=5409#r5409 |
| 2014-02-03 13:27 | egoitz | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=5411#r5411 |
| 2014-02-03 20:54 | egoitz | Note Added: 0063876 | |
| 2014-02-10 10:37 | egoitz | Assigned To | jonalegriaesarte => AugustoMauch |
| 2014-02-10 10:37 | egoitz | Target Version | => 3.0MP32 |
| 2014-03-10 15:24 | alostale | Assigned To | AugustoMauch => szapata |
| 2014-03-12 10:21 | jonalegriaesarte | Resolution time | 1392418800 => 1394838000 |
| 2014-03-15 14:39 | szapata | Note Added: 0065190 | |
| 2014-03-17 08:28 | alostale | Assigned To | szapata => AugustoMauch |
| 2014-03-18 17:19 | AugustoMauch | Status | new => scheduled |
| 2014-03-18 17:19 | AugustoMauch | fix_in_branch | => pi |
| 2014-03-18 17:26 | AugustoMauch | Issue Monitored: alostale | |
| 2014-03-18 21:05 | hgbot | Checkin | |
| 2014-03-18 21:05 | hgbot | Note Added: 0065277 | |
| 2014-03-18 21:05 | hgbot | Status | scheduled => resolved |
| 2014-03-18 21:05 | hgbot | Resolution | open => fixed |
| 2014-03-18 21:05 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/05acae86769bfc1e346a48c561e918b91e31efb5 [^] |
| 2014-03-18 21:17 | AugustoMauch | Review Assigned To | AugustoMauch => alostale |
| 2014-03-20 17:18 | hudsonbot | Checkin | |
| 2014-03-20 17:18 | hudsonbot | Note Added: 0065311 | |
| 2014-03-21 10:23 | alostale | Note Added: 0065344 | |
| 2014-03-21 10:23 | alostale | Status | resolved => closed |
| 2014-03-21 10:23 | alostale | Fixed in Version | => PR14Q3 |
| 2014-07-04 13:35 | caristu | Relationship added | related to 0027017 |
|
Notes |
|
|
(0063876)
|
|
egoitz
|
|
2014-02-03 20:54
|
|
This happens also with other forms that have callout.
For example with the Tax Report Launcher. |
|
|
|
(0065190)
|
|
szapata
|
|
2014-03-15 14:39
|
|
Here is the situation:
1 You open the first form and the HTML of the entire window contains a frame called 'appFrame'
2 You open the second form and the HTML now contains two forms called 'appFrame' the src of the first one points to the first form and the second one to the second form.
3 You close the first form, so now the HTML only have one frame called 'appFrame' which was the second one, but now is the only one in the HTML.
4 You open again the form with the callout, and now the HTML has again two frames called 'appFrame', but the src property of the first appFrame points to the form you opened in step 2, so when you execute the callout, the response of the callout is injected in this src and the expected fields to be filled by the response does not exist in that frame.
Callouts response shouldn't be managed by the name of the frame only but should be managed by the entire Frame object or the combination of src+frame name. |
|
|
|
(0065277)
|
|
hgbot
|
|
2014-03-18 21:05
|
|
Repository: erp/devel/pi
Changeset: 05acae86769bfc1e346a48c561e918b91e31efb5
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 18 17:23:09 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/05acae86769bfc1e346a48c561e918b91e31efb5 [^]
Fixes issue 25558: Fixes callout of manual forms
The code that applies the response of the manual forms callout was taking for granted that there one only one frame called appFrame. This was true in Openbravo 2.50, but in Openbravo 3.0 many manual windows can be opened at the same time, so there may be several frames called appFrame in one given moment.
This has been fixed by storing the active manual frame (the one whose tab is focused), and using that frame when applying the response of the callout.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/classic/ob-classic-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
M src/org/openbravo/erpCommon/security/Login.html
M src/org/openbravo/erpCommon/security/Login_F1.html
M web/js/callOut.js
M web/js/utils.js
---
|
|
|
|
|
|
|
|
|
|