Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025449Openbravo ERPZ. Otherspublic2014-01-08 17:042014-04-01 11:31
Reporterjecharri 
Assigned Tojecharri 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q2Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned Tojonalegriaesarte
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025449: int-3.0-api fails because I need to change 2 columns definition
DescriptionDue to this issue

https://issues.openbravo.com/view.php?id=24685 [^]

I have to make an api change. Below you will find the changeset and api change:
-https://code.openbravo.com/erp/devel/try/rev/48befdcb4245 [^]

-http://builds.openbravo.com/view/try/job/try-api/1728/console [^]

-The changes are the followings:
I have changed the definition of column processing to column processed and the definition of processed to processing. Apart from that, I have created a sqllofic field to be able to filter in the grid view by column "Processed"

-The risk of this api change is medium because of the following reason:
The problem was that button "Process/Unprocess" expense sheet was using column processing and it was wrong, because the button needs to change from processing to unprocess when processed has value 'Y' and the only way to do that is using processed column.
Apart from that the risk is medium because both columns only allow to save values 'Y' or 'N' but there are modules that are already using and we should do little changes
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00246853.0PR14Q2 closed jecharri After an Expense Sheet is processed, processing column stays 'Y'. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-01-08 17:04jecharriNew Issue
2014-01-08 17:04jecharriAssigned To => dmitry_mezentsev
2014-01-08 17:04jecharriWeb browser => Google Chrome
2014-01-08 17:04jecharriModules => Core
2014-01-08 17:04jecharriTriggers an Emergency Pack => No
2014-01-09 10:33dmitry_mezentsevNote Added: 0063327
2014-01-09 10:39dmitry_mezentsevNote Added: 0063328
2014-01-09 10:40dmitry_mezentsevAssigned Todmitry_mezentsev => jecharri
2014-01-09 10:47jecharriWeb browserGoogle Chrome => Google Chrome
2014-01-09 10:47jecharriDescription Updatedbug_revision_view_page.php?rev_id=5300#r5300
2014-01-31 12:27jecharriWeb browserGoogle Chrome => Google Chrome
2014-01-31 12:27jecharriDescription Updatedbug_revision_view_page.php?rev_id=5398#r5398
2014-01-31 13:26dmitry_mezentsevNote Added: 0063825
2014-01-31 14:11jecharriStatusnew => scheduled
2014-01-31 14:11jecharrifix_in_branch => pi
2014-02-04 11:57hgbotCheckin
2014-02-04 11:57hgbotNote Added: 0063884
2014-02-04 11:57hgbotStatusscheduled => resolved
2014-02-04 11:57hgbotResolutionopen => fixed
2014-02-04 11:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/c2b00c4876c5dadadb5ae05ed514f15df4a70b9b [^]
2014-02-05 01:51hgbotCheckin
2014-02-05 01:51hgbotNote Added: 0063910
2014-02-06 18:41hgbotCheckin
2014-02-06 18:41hgbotNote Added: 0064006
2014-02-27 18:21jecharriRelationship addedrelated to 0024685
2014-04-01 11:31jonalegriaesarteReview Assigned To => jonalegriaesarte
2014-04-01 11:31jonalegriaesarteStatusresolved => closed
2014-04-01 11:31jonalegriaesarteFixed in Version => PR14Q2

Notes
(0063327)
dmitry_mezentsev   
2014-01-09 10:32   
Approved with the need to rise the risk of the change to medium and to check about the way Processing column is handled by Openbravo.
(0063328)
dmitry_mezentsev   
2014-01-09 10:39   
Sorry, does not work. If we change the way you propose we will introduce another regression then. Now Processed column is used in the grid for filtering which is handy and with this change we will delete this feature.

We need to do sth else.
(0063825)
dmitry_mezentsev   
2014-01-31 13:26   
Approved.
(0063884)
hgbot   
2014-02-04 11:57   
Repository: erp/devel/api-checks
Changeset: c2b00c4876c5dadadb5ae05ed514f15df4a70b9b
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Feb 04 11:57:13 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/c2b00c4876c5dadadb5ae05ed514f15df4a70b9b [^]

Fixes issue 25449: int-3.0-api fails because I need to change 2 columns definition

---
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0063910)
hgbot   
2014-02-05 01:51   
Repository: erp/devel/api-checks
Changeset: 47d63c7ce10be9efa32b8e01ddfedeea0223df21
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Feb 05 01:51:28 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/47d63c7ce10be9efa32b8e01ddfedeea0223df21 [^]

issue 25449: int-3.0-api fails because
I need to change 2 columns definition

---
M java/reference/java.japi.gz
---
(0064006)
hgbot   
2014-02-06 18:41   
Repository: erp/devel/api-checks
Changeset: 5b1b3f343cc6e168ce66982248b14fcffd099d8d
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Thu Feb 06 18:42:00 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5b1b3f343cc6e168ce66982248b14fcffd099d8d [^]

issue 25449: int-3.0-api fails because
I need to change 2 columns definition

---
M model/src-db/database/model/tables/S_TIMEEXPENSE.xml
---