Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025447Openbravo ERPB. User interfacepublic2014-01-08 16:142014-03-06 11:18
Reportercaristu 
Assigned Toshankarb 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR14Q2Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025447: isNull filter expression is not working properly for table reference
DescriptionThe isNull filter expression is not working properly for those fields that are related to a table reference. Other filter expressions like isNotNull are working fine.
Steps To Reproduce1) Go to the [Sales Order] window and display the "Sales Representative" (table reference) field in grid view.
2) Without removing the implicit filters, put # (isNull) in the Sales Representative filter. It works fine.
3) Remove the implicit filter (by clicking on the funnel icon)
4) Put # (isNull) in the Sales Representative filter. It doesn't work.
5) Put !# (isNotNull) in the Sales Representative filter. It works fine.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0025211 closed AugustoMauch Filter by selected value in FK uses identifier instead of ID 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-01-08 16:14caristuNew Issue
2014-01-08 16:14caristuAssigned To => dbaz
2014-01-08 16:14caristuModules => Core
2014-01-08 16:14caristuResolution time => 1395788400
2014-01-08 16:14caristuTriggers an Emergency Pack => No
2014-01-08 16:15dbazAssigned Todbaz => shankarb
2014-01-08 16:15caristuAssigned Toshankarb => dbaz
2014-01-08 16:15caristuSummaryisNull expression filter is not working properly for table reference => isNull filter expression is not working properly for table reference
2014-01-08 16:15caristuDescription Updatedbug_revision_view_page.php?rev_id=5296#r5296
2014-01-08 16:15caristuIssue Monitored: networkb
2014-01-08 16:23caristuAssigned Todbaz => shankarb
2014-01-08 18:59alostaleNote Added: 0063318
2014-01-08 19:00alostaleRelationship addedrelated to 0025211
2014-01-08 19:01alostaleNote Edited: 0063318bug_revision_view_page.php?bugnote_id=0063318#r5298
2014-02-27 13:31caristuTarget Version3.0MP33 => 3.0MP32
2014-03-03 06:12shankarbIssue Monitored: AugustoMauch
2014-03-03 06:12shankarbReview Assigned To => AugustoMauch
2014-03-03 06:13hgbotCheckin
2014-03-03 06:13hgbotNote Added: 0064703
2014-03-03 06:13hgbotStatusnew => resolved
2014-03-03 06:13hgbotResolutionopen => fixed
2014-03-03 06:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/75f848b61c970b56a125d16cc20f52179587b357 [^]
2014-03-03 17:38hudsonbotCheckin
2014-03-03 17:38hudsonbotNote Added: 0064757
2014-03-06 11:18AugustoMauchNote Added: 0064900
2014-03-06 11:18AugustoMauchStatusresolved => closed
2014-03-06 11:18AugustoMauchFixed in Version => PR14Q2

Notes
(0063318)
alostale   
2014-01-08 18:59   
(edited on: 2014-01-08 19:01)
This is the current query:
Order as e left join e.salesRepresentative as join_0 where (( e.salesRepresentative.name is null ))

This is what it should be:
Order as e left join e.salesRepresentative as join_0 where (( e.salesRepresentative is null ))

Notes:
*when fixing this issue take also into account adaptive filtering
*verify also other FK references (tableDir, selector...)
(0064703)
hgbot   
2014-03-03 06:13   
Repository: erp/devel/pi
Changeset: 75f848b61c970b56a125d16cc20f52179587b357
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Feb 06 14:23:45 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/75f848b61c970b56a125d16cc20f52179587b357 [^]

Fixes Issue 25447: isNull filter expression is not working properly for table reference

If the operator is isNull or notNull comparison should be done at the object level and
not at the field value level

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0064757)
hudsonbot   
2014-03-03 17:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8d1e52794b1e [^]
Maturity status: Test
(0064900)
AugustoMauch   
2014-03-06 11:18   
Code reviewed and verified in pi@9484419af022.

Tested with and without adaptive filtering.