Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025431Openbravo ERPA. Platformpublic2014-01-03 16:002014-03-19 02:41
Reporteregoitz 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q2Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket25649
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025431: The linked items on a partner -customer- is showing incorrect links
DescriptionThe linked items on a partner -customer- is showing incorrect links.

The linked items for a customer, when there is a posted payment it, despite of showning the link for the accounting of the payment in, is also showing a link for the accouting of a payment out that does not exsist.

The following error is raised on the log:


2014-01-03 15:26:05,845 [ajp-localhost%2F127.0.0.1-8809-3] ERROR org.openbravo.base.util.CheckException - Property null does not exist for entity FinancialMgmtAccountingFact
org.openbravo.base.util.CheckException: Property null does not exist for entity FinancialMgmtAccountingFact
    at org.openbravo.base.util.Check.isNotNull(Check.java:72)
    at org.openbravo.base.model.Entity.getProperty(Entity.java:556)
    at org.openbravo.base.model.Entity.getProperty(Entity.java:538)
    at org.openbravo.base.structure.BaseOBObject.get(BaseOBObject.java:250)
    at org.openbravo.base.structure.BaseOBObject.get(BaseOBObject.java:228)
    at org.openbravo.base.structure.BaseOBObject.get(BaseOBObject.java:209)
    at org.openbravo.service.datasource.DefaultDataSourceService.addFetchParameters(DefaultDataSourceService.java:114)
    at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:71)
    at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:255)
    at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:678)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:440)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:63)
    at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:138)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    at org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:448)
    at org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:399)
    at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1675)
    at java.lang.Thread.run(Thread.java:701)
Steps To ReproduceOn the demo data:

-Access to the partner "Alimentos y Supermercados, S.A"
-open the linked items section
-click on the link to payment out > accounting
-Click on a record shown on the right section.
*You get the error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-01-03 16:00egoitzNew Issue
2014-01-03 16:00egoitzAssigned To => AugustoMauch
2014-01-03 16:00egoitzModules => Core
2014-01-03 16:00egoitzOBNetwork customer => Yes
2014-01-03 16:00egoitzTriggers an Emergency Pack => No
2014-01-03 16:03egoitzSupport ticket => 25649
2014-01-03 16:03egoitzResolution time => 1392418800
2014-01-03 16:03egoitzPriorityurgent => high
2014-01-03 16:03egoitzSeveritymajor => minor
2014-03-05 13:03alostaleTarget Version => PR14Q2
2014-03-09 07:47shankarbAssigned ToAugustoMauch => shankarb
2014-03-09 08:30shankarbReview Assigned To => AugustoMauch
2014-03-09 08:30shankarbIssue Monitored: AugustoMauch
2014-03-09 08:31hgbotCheckin
2014-03-09 08:31hgbotNote Added: 0064968
2014-03-09 08:31hgbotStatusnew => resolved
2014-03-09 08:31hgbotResolutionopen => fixed
2014-03-09 08:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8c76a7a6bf32a51ee1fd1c0f685ad4bf52e06c9f [^]
2014-03-10 22:58hudsonbotCheckin
2014-03-10 22:58hudsonbotNote Added: 0065002
2014-03-11 09:04hgbotCheckin
2014-03-11 09:04hgbotNote Added: 0065015
2014-03-11 17:04hudsonbotCheckin
2014-03-11 17:04hudsonbotNote Added: 0065055
2014-03-17 12:07AugustoMauchNote Added: 0065209
2014-03-17 12:07AugustoMauchStatusresolved => new
2014-03-17 12:07AugustoMauchResolutionfixed => open
2014-03-17 12:11AugustoMauchNote Added: 0065210
2014-03-18 09:46hgbotCheckin
2014-03-18 09:46hgbotNote Added: 0065250
2014-03-18 09:46hgbotStatusnew => resolved
2014-03-18 09:46hgbotResolutionopen => fixed
2014-03-18 09:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8c76a7a6bf32a51ee1fd1c0f685ad4bf52e06c9f [^] => http://code.openbravo.com/erp/devel/pi/rev/5b72cc2f9c66a9303856460256025d43057cb5d8 [^]
2014-03-18 11:23AugustoMauchNote Added: 0065256
2014-03-18 11:23AugustoMauchStatusresolved => closed
2014-03-18 11:23AugustoMauchFixed in Version => PR14Q2
2014-03-19 02:41hudsonbotCheckin
2014-03-19 02:41hudsonbotNote Added: 0065284

Notes
(0064968)
hgbot   
2014-03-09 08:31   
Repository: erp/devel/pi
Changeset: 8c76a7a6bf32a51ee1fd1c0f685ad4bf52e06c9f
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Sun Mar 09 12:58:18 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8c76a7a6bf32a51ee1fd1c0f685ad4bf52e06c9f [^]

Fixes issue 0025431: The linked items on a partner -customer- is showing incorrect links

The value of the json data is compared to null along with the object comparison to null.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
---
(0065002)
hudsonbot   
2014-03-10 22:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b362f74ef31a [^]
Maturity status: Test
(0065015)
hgbot   
2014-03-11 09:04   
Repository: erp/devel/pi
Changeset: be7456cf48f2e691d40bda691491b24ccb34550d
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Mar 11 13:33:21 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/be7456cf48f2e691d40bda691491b24ccb34550d [^]

Related to Issue 25431: Updated copyright year

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
---
(0065055)
hudsonbot   
2014-03-11 17:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0d35a09c7eb8 [^]
Maturity status: Test
(0065209)
AugustoMauch   
2014-03-17 12:07   
This issue should not be solved by handling in the server side the case when the parameters.get(JsonConstants.FILTERBYPARENTPROPERTY_PARAMETER) parameter is "null".

This should be addressed in the client side, why is "null" being sent?
(0065210)
AugustoMauch   
2014-03-17 12:11   
The Accounting tab uses the Fact_Act table. This table does not have any Is Parent columns, so it does not have a parentProperty. Probably it should be taken into accout here [1], if this.view.parentProperty is null it should not be assigned to params._filterByParentProperty.

[1] https://code.openbravo.com/erp/devel/pi/file/f98bc5e90f33/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js#l2005 [^]
(0065250)
hgbot   
2014-03-18 09:46   
Repository: erp/devel/pi
Changeset: 5b72cc2f9c66a9303856460256025d43057cb5d8
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Mar 18 11:30:18 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5b72cc2f9c66a9303856460256025d43057cb5d8 [^]

Fixes Issue 25431: The linked items on a partner -customer- is showing incorrect links

params._filterByParentProperty is set only if view contains parentProperty.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0065256)
AugustoMauch   
2014-03-18 11:23   
Code reviewed and verified in pi@c84042acbfab
(0065284)
hudsonbot   
2014-03-19 02:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8682dba110 [^]
Maturity status: Test