Openbravo Issue Tracking System - Retail Modules
View Issue Details
0025399Retail ModulesWeb POSpublic2013-12-24 14:342014-01-21 15:50
marvintm 
marvintm 
urgentmajorsometimes
closedfixed 
5
 
RMP31 
migueldejuana
No
0025399: Under very specific circumstances, an error in the OrderLoader could lead to data loss
The OrderLoader process in the Web POS is designed to create an error entry in the database, in case something fails while creating the order.

However, under very specific circumstances, it seems this error entry may not be created correctly. In this case, the order will be deleted from the POS terminal, but will be neither saved as an order in the database, nor saved as an error, and therefore, its data will be lost.
It's not completely clear how to reproduce it, but it seems maybe it can be reproduced if the maximum number of database connections is reached. In this case, the order creation will obviously fail, but the problem is that the error entry creation will also fail, because the process cannot use the database either to create the error.
In this case, if the commit of the error creation returns an exception, then the OrderLoader process should also return an exception, so that the order is not deleted from the client.
No tags attached.
diff diffGrape_mobilecore.diff (1,072) 2013-12-26 18:57
https://issues.openbravo.com/file_download.php?file_id=6586&type=bug
diff diffGrape_posterminal.diff (5,894) 2013-12-26 19:00
https://issues.openbravo.com/file_download.php?file_id=6587&type=bug
Issue History
2013-12-24 14:34marvintmNew Issue
2013-12-24 14:34marvintmAssigned To => marvintm
2013-12-24 14:34marvintmTriggers an Emergency Pack => No
2013-12-26 18:57guilleaerFile Added: diffGrape_mobilecore.diff
2013-12-26 19:00guilleaerFile Added: diffGrape_posterminal.diff
2013-12-29 16:38dmitry_mezentsevNote Added: 0063103
2013-12-29 16:38dmitry_mezentsevPrioritynormal => urgent
2013-12-29 16:38dmitry_mezentsevSeveritycritical => major
2014-01-09 09:50hgbotCheckin
2014-01-09 09:50hgbotNote Added: 0063323
2014-01-09 09:50hgbotStatusnew => resolved
2014-01-09 09:50hgbotResolutionopen => fixed
2014-01-09 09:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^]
2014-01-09 09:51hgbotCheckin
2014-01-09 09:51hgbotNote Added: 0063324
2014-01-09 11:17hgbotCheckin
2014-01-09 11:17hgbotNote Added: 0063335
2014-01-09 11:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-splitlines/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^]
2014-01-09 14:20hgbotCheckin
2014-01-09 14:20hgbotNote Added: 0063345
2014-01-09 14:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-splitlines/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^]
2014-01-09 14:22hgbotCheckin
2014-01-09 14:22hgbotNote Added: 0063346
2014-01-21 15:50migueldejuanaReview Assigned To => migueldejuana
2014-01-21 15:50migueldejuanaNote Added: 0063577
2014-01-21 15:50migueldejuanaStatusresolved => closed
2014-01-21 15:50migueldejuanaFixed in Version => RMP31

Notes
(0063103)
dmitry_mezentsev   
2013-12-29 16:38   
Not Critical, http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^]
(0063323)
hgbot   
2014-01-09 09:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 211e4d65c88770c8e0fd5fa49ccea00267786b88
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jan 09 09:47:17 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^]

fixed issue 25399: If something goes worng during save order process, the orders are not removed from the client side DB

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/utils/ordersSyncUtils.js
---
(0063324)
hgbot   
2014-01-09 09:51   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9ec3eca006716b832295ca9af7bb7400af8aaaeb
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jan 09 09:48:44 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9ec3eca006716b832295ca9af7bb7400af8aaaeb [^]

related to issue 25399: Now we know if an error happened because a timeout. Also we can get additional info about exceptions.

---
M src-db/database/sourcedata/AD_TAB.xml
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0063335)
hgbot   
2014-01-09 11:17   
Repository: erp/pmods/org.openbravo.retail.posterminal-splitlines
Changeset: 211e4d65c88770c8e0fd5fa49ccea00267786b88
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jan 09 09:47:17 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-splitlines/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^]

fixed issue 25399: If something goes worng during save order process, the orders are not removed from the client side DB

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/utils/ordersSyncUtils.js
---
(0063345)
hgbot   
2014-01-09 14:20   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: 211e4d65c88770c8e0fd5fa49ccea00267786b88
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jan 09 09:47:17 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/211e4d65c88770c8e0fd5fa49ccea00267786b88 [^]

fixed issue 25399: If something goes worng during save order process, the orders are not removed from the client side DB

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/utils/ordersSyncUtils.js
---
(0063346)
hgbot   
2014-01-09 14:22   
Repository: erp/pmods/org.openbravo.mobile.core.cirque
Changeset: 9ec3eca006716b832295ca9af7bb7400af8aaaeb
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jan 09 09:48:44 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core.cirque/rev/9ec3eca006716b832295ca9af7bb7400af8aaaeb [^]

related to issue 25399: Now we know if an error happened because a timeout. Also we can get additional info about exceptions.

---
M src-db/database/sourcedata/AD_TAB.xml
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0063577)
migueldejuana   
2014-01-21 15:50   
Tested and reviewed