Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025162Openbravo ERPA. Platformpublic2013-11-15 01:402013-12-19 12:30
Reporterjonalegriaesarte 
Assigned Toshankarb 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP31Fixed in Version3.0MP31 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025162: Roles permissions are not working correectly
DescriptionRoles' permission are not working correctly (at least for fields that are in status bar). When a role has editable permission to a tab that has a field in
status bar, that field can be updated in grid view when you shouldn't be able to do it.
Steps To ReproduceLogin as 'F&B Internacional Group Admin'
Go to Roles window.
Selected 'F&B Internacional Group Admin' and go to Window access
Select 'Sales Order' window and go to Tab Access
Insert new record:
TAB: 'Header'
EDITABLE FIELDS: true
ACTIVE: true

Log out and log in.
Go to 'Sales Order' window and try to edit one record in grid view. Notice that you are able to change the value of the status field.


If one field is readonly, even though an edit permisson are given to that field, you should never be able to edit it.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff FixIssue25162.diff (1,491) 2013-12-03 07:08
https://issues.openbravo.com/file_download.php?file_id=6551&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-11-15 01:40jonalegriaesarteNew Issue
2013-11-15 01:40jonalegriaesarteAssigned To => AugustoMauch
2013-11-15 01:40jonalegriaesarteModules => Core
2013-11-15 01:40jonalegriaesarteTriggers an Emergency Pack => No
2013-12-03 07:05shankarbAssigned ToAugustoMauch => shankarb
2013-12-03 07:05shankarbStatusnew => scheduled
2013-12-03 07:05shankarbNote Added: 0062497
2013-12-03 07:05shankarbfix_in_branch => pi
2013-12-03 07:08shankarbFile Added: FixIssue25162.diff
2013-12-05 06:43shankarbIssue Monitored: AugustoMauch
2013-12-05 06:45shankarbReview Assigned To => AugustoMauch
2013-12-05 06:45shankarbfix_in_branchpi =>
2013-12-05 06:46hgbotCheckin
2013-12-05 06:46hgbotNote Added: 0062537
2013-12-05 06:46hgbotStatusscheduled => resolved
2013-12-05 06:46hgbotResolutionopen => fixed
2013-12-05 06:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bd2288f21d2bf06aaa8930bae12aad39bc1d8956 [^]
2013-12-18 14:14AugustoMauchNote Added: 0062783
2013-12-18 14:14AugustoMauchStatusresolved => closed
2013-12-18 14:14AugustoMauchFixed in Version => 3.0MP31
2013-12-19 12:30hudsonbotCheckin
2013-12-19 12:30hudsonbotNote Added: 0062823

Notes
(0062497)
shankarb   
2013-12-03 07:05   
Issue fixed. Will be pushed in mp31
(0062537)
hgbot   
2013-12-05 06:46   
Repository: erp/devel/pi
Changeset: bd2288f21d2bf06aaa8930bae12aad39bc1d8956
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Dec 03 11:37:56 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/bd2288f21d2bf06aaa8930bae12aad39bc1d8956 [^]

Fixes Issue 0025162: Roles permissions are not working correctly

Checked whether the field is readOnly or shownInStatus bar before providing access to the field in case tab access is provided.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
---
(0062783)
AugustoMauch   
2013-12-18 14:14   
Code reviewed and verified in pi@469ba15fbba3
(0062823)
hudsonbot   
2013-12-19 12:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b878bb51dc09 [^]

Maturity status: Test