|
Notes |
|
|
(0062136)
|
|
alostale
|
2013-11-15 09:13
(edited on: 2013-11-15 09:22) |
|
Regression introduced in MP28
When in this situation, a javascript error is thrown by SmartClient's ListGrid.getFrozenSlots method:
Uncaught TypeError: Cannot call method 'slice' of null ListGrid.js:31570
isc.ListGrid.addMethods.getFrozenSlots
doing array.slice because array is null at this point.
The root cause is grid field grouping is done locally in client manipulating data that has been fetched. To fix issue 0024684, saved view is applied before requesting data so in case saved view includes grouping it is tried to be applied to an empty (null) array of data.
|
|
|
|
|
When this error happens, the window that was tried to be opened remains in loading data not being possible to be operated.
Workaround: delete entries for that window in:
-Window Personalization window
-Preferences window (as System Admin), the ones with Property "Default View Setting" and "Grid Configuration" |
|
|
|
|
Executed test cases:
Both at main tab and sub tab levels:
-Do grouping and save view, close and open window, apply saved view
-Set saved view with grouping as default view, close and open window
In all the 4 cases grouping is properly applied |
|
|
|
(0062139)
|
|
hgbot
|
|
2013-11-15 09:49
|
|
Repository: erp/devel/pi
Changeset: 73efa41903ad82eac87aac7ef881adc280c39cf9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Nov 15 09:47:05 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/73efa41903ad82eac87aac7ef881adc280c39cf9 [^]
fixed bug 25119: problem with grid configuration and field grouping
Don't apply grouping grid configuration till dataset callback as grouping is
done in client side with grid's data it expects data to be present
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js
---
|
|
|
|
(0062140)
|
|
alostale
|
2013-11-15 09:55
(edited on: 2013-11-15 10:46) |
|
Reopening: when current grid status contains both filtering and grouping, clicking in funnel icon to remove filters causes a javascript exception
|
|
|
|
|
In case of current grid status contains both filter clause and grouping and filter is removed, grouping will also be removed. This makes sense because data after removing filter clause can be bigger than the number of rows supported by grouping.
Additional test cases:
-In a window with default filter clause (such as Sales Order). Open the window, without removing filter clause, apply groping by a column. Clean filters, grouping is now removed and complete data is requested.
-In a window without default filter clause. Apply grouping and filter, remove filter. Grouping is preserved. |
|
|
|
(0062142)
|
|
hgbot
|
|
2013-11-15 10:53
|
|
Repository: erp/devel/pi
Changeset: 3c17ffad5021da3e83dee712c4ea0388a38e05fa
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Nov 15 10:52:43 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3c17ffad5021da3e83dee712c4ea0388a38e05fa [^]
fixed bug 25119: problem with grid configuration and field grouping
Remove grouping when deleting filters in case of filter clause
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
---
|
|
|
|
|
Previous fix still doesn't work for the case of not using saved views, but just adding a group, closing the window and opening it again. In this case, it doesn't fail, but the grouping is not applied.
Additionally tested after new patch: explained case both at root tab and sub tabs. |
|
|
|
(0062152)
|
|
hgbot
|
|
2013-11-15 15:23
|
|
Repository: erp/devel/pi
Changeset: 49c475685925ad48c03bf28556a2965ed0066fb0
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Nov 15 15:22:59 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/49c475685925ad48c03bf28556a2965ed0066fb0 [^]
fixed bug 25119: Problem with grid configuration and field grouping
Apply grouping not only for saved views but also in grid configuration
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js
---
|
|
|
|
(0062153)
|
|
shankarb
|
|
2013-11-15 15:50
|
|
|
Code reviewed and verified in pi changeset 49c475685925. |
|
|
|
|
|
|
|
|
|
|
|
|
|