Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025075Openbravo ERP09. Financial managementpublic2013-11-04 18:462013-11-19 19:07
ReporterioritzCia 
Assigned Toeduardo_Argal 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionUbuntu 12.04
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToioritzCia
OBNetwork customerOBPS
Web browserGoogle Chrome
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0025075: FIN_Utility.getDocumentNo method can return the same documentno to same document and organization.
DescriptionFIN_Utility.getDocumentNo makes a call to a query that returns the nextAssignedNumber of a sequence. This can be called concurrently and can return the same number twice.

Note that to avoid this wad calls Utility.getDocumentNo method that makes a call to DocumentNoData.nextDocType method, that executes AD_Sequence_DocType database function. This function makes a select ... for update call at the beginning, blocking the ad_sequence table so that no one can access it until the commit of the transaction has been done.
Steps To Reproduce- Hard to reproduce it in pi.
- Could reproduce it in customer's environment with a custom development.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029246 closed Triage Omni WMS Modules can get duplicated document numbers in picking list 
related to defect 0029258 closed Sandrahuguet Openbravo ERP FIN_Utility.getDocumentNo method can return duplicates 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-11-04 18:46ioritzCiaNew Issue
2013-11-04 18:46ioritzCiaAssigned To => dmiguelez
2013-11-04 18:46ioritzCiaWeb browser => Google Chrome
2013-11-04 18:46ioritzCiaModules => Advanced Payables and Receivables Mngmt
2013-11-04 18:46ioritzCiaOBNetwork customer => Yes
2013-11-04 18:46ioritzCiaTriggers an Emergency Pack => No
2013-11-06 11:52eduardo_ArgalAssigned Todmiguelez => eduardo_Argal
2013-11-06 11:52eduardo_ArgalStatusnew => scheduled
2013-11-06 11:52eduardo_Argalfix_in_branch => pi
2013-11-06 11:53hgbotCheckin
2013-11-06 11:53hgbotNote Added: 0062042
2013-11-06 11:53hgbotStatusscheduled => resolved
2013-11-06 11:53hgbotResolutionopen => fixed
2013-11-06 11:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e884b5f2318b77d3cbd8765541d5a5b4b5ebbef2 [^]
2013-11-06 11:56ioritzCiaReview Assigned To => ioritzCia
2013-11-06 11:56ioritzCiaNote Added: 0062043
2013-11-06 11:56ioritzCiaStatusresolved => closed
2013-11-19 19:07hudsonbotCheckin
2013-11-19 19:07hudsonbotNote Added: 0062240
2015-03-11 18:03alostaleRelationship addedrelated to 0029246
2015-03-12 13:58alostaleRelationship addedrelated to 0029258

Notes
(0062042)
hgbot   
2013-11-06 11:53   
Repository: erp/devel/pi
Changeset: e884b5f2318b77d3cbd8765541d5a5b4b5ebbef2
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Wed Nov 06 11:52:46 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e884b5f2318b77d3cbd8765541d5a5b4b5ebbef2 [^]

Fixes bug 25075

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0062043)
ioritzCia   
2013-11-06 11:56   
Verified.
(0062240)
hudsonbot   
2013-11-19 19:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ab71e0273dc1 [^]

Maturity status: Test