Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024996Openbravo ERPZ. Otherspublic2013-10-23 11:412014-02-12 18:29
ReporterVictorVillar 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR14Q2Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket24163
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024996: CSV Exportation is not working as expected in Price List based on cost
DescriptionCSV Exportation is not working as expected in Price List based on cost.
The Cost field shows in the application decimals regarding the GeneralQty number type in Format.xml
Steps To ReproduceAs System Admin role,
Go to Currency window,
   Select EUR and USD and put the Costing precision = 8
As group admin role,
Go to Price List Schema window
  change the base List Price and the Base unit Price = cost for the Price List Schema. --> Margin = 44
Go to Price list window,
Create a new one: - Sales Price List = Yes
                  - Price List based on cost = Yes
   Price List version tab:
         Price List Schema = Price List Schema
Click on Create Price List button.
Realise in the Product Price tab is showed the Cost field in grid view, and check that the cost values informed are with 6 decimals according to the GeneralQty number in the Format.xml
Export it to CSV, check that the cost values are exported in the CSV with 2 decimals, it is wrong, it should be with 6 decimals
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff ExportIssue.diff (541) 2014-01-02 04:45
https://issues.openbravo.com/file_download.php?file_id=6598&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-10-23 11:41VictorVillarNew Issue
2013-10-23 11:41VictorVillarAssigned To => dmiguelez
2013-10-23 11:41VictorVillarModules => Core
2013-10-23 11:41VictorVillarOBNetwork customer => Yes
2013-10-23 11:41VictorVillarSupport ticket => 24163
2013-10-23 11:41VictorVillarResolution time => 1389049200
2013-10-23 11:41VictorVillarTriggers an Emergency Pack => No
2013-10-23 11:41VictorVillarIssue Monitored: networkb
2013-10-23 11:55VictorVillarSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5140#r5140
2013-10-25 09:09dmiguelezAssigned Todmiguelez => jonalegriaesarte
2013-11-04 09:54jonalegriaesarteTarget Version3.0MP30 => 3.0MP31
2014-01-02 04:45shankarbAssigned Tojonalegriaesarte => shankarb
2014-01-02 04:45shankarbFile Added: ExportIssue.diff
2014-01-02 04:46shankarbStatusnew => scheduled
2014-01-02 04:46shankarbfix_in_branch => pi
2014-01-02 12:38jonalegriaesarteTarget Version3.0MP31 => 3.0MP32
2014-01-09 04:57shankarbIssue Monitored: AugustoMauch
2014-01-09 04:57shankarbReview Assigned To => AugustoMauch
2014-01-09 04:57shankarbfix_in_branchpi =>
2014-01-09 04:58hgbotCheckin
2014-01-09 04:58hgbotNote Added: 0063319
2014-01-09 04:58hgbotStatusscheduled => resolved
2014-01-09 04:58hgbotResolutionopen => fixed
2014-01-09 04:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/abbf2aa1426e3bac0479f2ec6f82db12872781aa [^]
2014-01-13 11:06VictorVillarNote Added: 0063382
2014-01-17 15:49hudsonbotCheckin
2014-01-17 15:49hudsonbotNote Added: 0063487
2014-01-20 18:44AugustoMauchNote Added: 0063547
2014-01-20 18:44AugustoMauchStatusresolved => new
2014-01-20 18:44AugustoMauchResolutionfixed => open
2014-01-21 09:58AugustoMauchNote Added: 0063562
2014-01-23 06:49hgbotCheckin
2014-01-23 06:49hgbotNote Added: 0063631
2014-01-23 06:49hgbotStatusnew => resolved
2014-01-23 06:49hgbotResolutionopen => fixed
2014-01-23 06:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/abbf2aa1426e3bac0479f2ec6f82db12872781aa [^] => http://code.openbravo.com/erp/devel/pi/rev/5cf31fdaa1ef98a78635d746a3f0438bf00f71ed [^]
2014-01-24 12:03AugustoMauchNote Added: 0063671
2014-01-24 12:03AugustoMauchStatusresolved => closed
2014-01-24 12:03AugustoMauchFixed in Version => 3.0MP32
2014-02-12 18:29hudsonbotCheckin
2014-02-12 18:29hudsonbotNote Added: 0064102

Notes
(0063319)
hgbot   
2014-01-09 04:58   
Repository: erp/devel/pi
Changeset: abbf2aa1426e3bac0479f2ec6f82db12872781aa
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Jan 09 09:27:10 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/abbf2aa1426e3bac0479f2ec6f82db12872781aa [^]

Fixes Issue 0024996: CSV Exportation is not working as expected in Price List based on cost

The number reference used DecimalUIDefinition.
The format of this type should be generalQuantity instead of euro.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/NumberUIDefinition.java
---
(0063382)
VictorVillar   
2014-01-13 11:06   
Verified, it is working fine regarding the case reported.
(0063487)
hudsonbot   
2014-01-17 15:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9669102eb541 [^]
Maturity status: Test
(0063547)
AugustoMauch   
2014-01-20 18:44   
I think the change is not proper. With this change, both DecimalUIDefinition and BigDecimalUIDefinition have the same format, and they would be identical. Probably a better option is to just change the reference of the Cost column to General Quantity
(0063562)
AugustoMauch   
2014-01-21 09:58   
It is not a good idea to change the User Interface definition of the Number reference from 'org.openbravo.client.kernel.reference.NumberUIDefinition$DecimalUIDefinition' to 'org.openbravo.client.kernel.reference.NumberUIDefinition$BigDecimalUIDefinition'. If you do that, the 'Number' reference will be exactly the same as the 'General Quantity' reference, and there will not be any reference that uses the euroedition format.
(0063631)
hgbot   
2014-01-23 06:49   
Repository: erp/devel/pi
Changeset: 5cf31fdaa1ef98a78635d746a3f0438bf00f71ed
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Jan 21 14:38:08 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5cf31fdaa1ef98a78635d746a3f0438bf00f71ed [^]

Fixes Issue 0024996: CSV Exportation is not working as expected in Price List based on cost

Reference has been changed to General Quantity.

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0063671)
AugustoMauch   
2014-01-24 12:03   
Code reviewed and verified in pi@5cf31fdaa1ef
(0064102)
hudsonbot   
2014-02-12 18:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d1a5bb862230 [^]
Maturity status: Test