Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024962Openbravo ERPA. Platformpublic2013-10-17 10:052013-12-31 04:57
Reporterjecharri 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP31Fixed in Version3.0MP31 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024962: It should be possible to lock a user only with parameter "login.trial.user.lock"
DescriptionIt should be possible to lock a user only with parameter "login.trial.user.lock"

Currently it is necessary to configure also the parameter "login.trial.delay.increment"

Steps To Reproduce-confiure parameter "login.trial.user.lock"

Verify that if you do not configure the delay, it is impossible to lock a user.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00245453.0MP27 closed AugustoMauch Impossible to lock a user 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-10-17 10:05jecharriNew Issue
2013-10-17 10:05jecharriAssigned To => AugustoMauch
2013-10-17 10:05jecharriWeb browser => Google Chrome
2013-10-17 10:05jecharriModules => Core
2013-10-17 10:05jecharriTriggers an Emergency Pack => No
2013-10-17 10:05jecharriRelationship addedrelated to 0024545
2013-10-17 10:08jecharriWeb browserGoogle Chrome => Google Chrome
2013-10-17 10:08jecharriSummaryIt should be possible to block a user only with parameter "login.trial.user.lock" => It should be possible to lock a user only with parameter "login.trial.user.lock"
2013-10-17 10:08jecharriDescription Updatedbug_revision_view_page.php?rev_id=5118#r5118
2013-10-17 10:08jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5120#r5120
2013-11-05 09:42AugustoMauchAssigned ToAugustoMauch => shankarb
2013-11-21 16:23jonalegriaesarteWeb browserGoogle Chrome => Google Chrome
2013-11-21 16:23jonalegriaesarteTarget Version3.0MP30 =>
2013-11-27 11:35AugustoMauchWeb browserGoogle Chrome => Google Chrome
2013-11-27 11:35AugustoMauchTarget Version => 3.0MP31
2013-12-23 12:56shankarbIssue Monitored: AugustoMauch
2013-12-23 12:56shankarbReview Assigned To => AugustoMauch
2013-12-23 12:56shankarbWeb browserGoogle Chrome => Google Chrome
2013-12-23 12:59hgbotCheckin
2013-12-23 12:59hgbotNote Added: 0063051
2013-12-23 12:59hgbotStatusnew => resolved
2013-12-23 12:59hgbotResolutionopen => fixed
2013-12-23 12:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/45f454a1d15f2d4cec0c9fede7a40335487222cf [^]
2013-12-24 19:11hudsonbotCheckin
2013-12-24 19:11hudsonbotNote Added: 0063068
2013-12-30 13:13shankarbNote Added: 0063121
2013-12-30 14:29dbazIssue Monitored: dbaz
2013-12-30 14:48hgbotCheckin
2013-12-30 14:48hgbotNote Added: 0063126
2013-12-30 16:26dbazReview Assigned ToAugustoMauch => dbaz
2013-12-30 16:26dbazNote Added: 0063128
2013-12-30 16:26dbazStatusresolved => closed
2013-12-30 16:26dbazFixed in Version => 3.0MP31
2013-12-31 04:57hudsonbotCheckin
2013-12-31 04:57hudsonbotNote Added: 0063138

Notes
(0063051)
hgbot   
2013-12-23 12:59   
Repository: erp/devel/pi
Changeset: 45f454a1d15f2d4cec0c9fede7a40335487222cf
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Dec 23 14:13:08 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/45f454a1d15f2d4cec0c9fede7a40335487222cf [^]

Fixes Issue 0024962: It should be possible to lock a user only with parameter "login.trial.user.lock"

The user can be locked with the login.trial.user.lock parameter.
If the the login.trial.delay.increment is not 0 it will be used, else lock parameter alone will be checked.

---
M src/org/openbravo/base/secureApp/UserLock.java
---
(0063068)
hudsonbot   
2013-12-24 19:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a6ebb8307561 [^]

Maturity status: Test
(0063121)
shankarb   
2013-12-30 13:13   
Test Plan:
1. Set login.trial.user.lock to "1" in Openbravo.properties.
2. Login into the application with incorrect credentials.
3. Login again with proper credentials. The user should be locked now (as there was 1 incorrect login attempt).
4. Before the fix only if login.trial.delay.increment is provided, the user will be locked, now even without that parameter the user will be locked.
(0063126)
hgbot   
2013-12-30 14:48   
Repository: erp/devel/pi
Changeset: 987357c24f955c696cf5b7c4b502b185a49253df
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Dec 30 19:17:05 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/987357c24f955c696cf5b7c4b502b185a49253df [^]

Related to Issue 0024962: Proper matching for lockAfterTrials

---
M src/org/openbravo/base/secureApp/UserLock.java
---
(0063128)
dbaz   
2013-12-30 16:26   
Reviewed @ changeset: 21731 - 987357c24f95
(0063138)
hudsonbot   
2013-12-31 04:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/987357c24f95 [^]

Maturity status: Test