Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024960Openbravo ERPB. User interfacepublic2013-10-17 01:562013-10-30 09:52
Reportercaristu 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP29Fixed in Version3.0MP29 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket20689
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024960: Field groups are not displayed under some circunstances
DescriptionIf we assign a display logic to a group of fields, and if this group has not enough space in the tab, it is shown but after a while it disappears again. Also some additional configuration in the tab is required. Attached is a module that contains a tab where this problem is always reproducible.
Steps To Reproduce1) Install the attached module
2) Go to the [Disappear] tab in the Business Partner window
3) In the Business Partner field, select Hoteles Buenas Noches, S.A.
4) Notice that the field group blinks and disappear
5) Maximize the tab
6) Select the same business partner again. Now everything works fine.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? org.openbravo.disappear-1.0.0.obx (16,518) 2013-10-17 01:56
https://issues.openbravo.com/file_download.php?file_id=6452&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-10-17 01:56caristuNew Issue
2013-10-17 01:56caristuAssigned To => dbaz
2013-10-17 01:56caristuFile Added: org.openbravo.disappear-1.0.0.obx
2013-10-17 01:56caristuModules => Core
2013-10-17 01:56caristuOBNetwork customer => Yes
2013-10-17 01:56caristuSupport ticket => 20689
2013-10-17 01:56caristuResolution time => 1386025200
2013-10-17 01:56caristuTriggers an Emergency Pack => No
2013-10-17 01:56caristuIssue Monitored: networkb
2013-10-17 01:57caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5116#r5116
2013-10-17 01:57dbazAssigned Todbaz => AugustoMauch
2013-10-17 08:41shankarbAssigned ToAugustoMauch => shankarb
2013-10-24 10:06shankarbReview Assigned To => AugustoMauch
2013-10-24 10:06shankarbIssue Monitored: AugustoMauch
2013-10-24 10:14hgbotCheckin
2013-10-24 10:14hgbotNote Added: 0061880
2013-10-24 10:14hgbotStatusnew => resolved
2013-10-24 10:14hgbotResolutionopen => fixed
2013-10-24 10:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/decd52611c978f16fed7d91be1b9b1d4d4d2289e [^]
2013-10-24 20:04hudsonbotCheckin
2013-10-24 20:04hudsonbotNote Added: 0061895
2013-10-29 10:39shankarbNote Added: 0061932
2013-10-30 09:52AugustoMauchNote Added: 0061959
2013-10-30 09:52AugustoMauchStatusresolved => closed
2013-10-30 09:52AugustoMauchFixed in Version => 3.0MP29

Notes
(0061880)
hgbot   
2013-10-24 10:14   
Repository: erp/devel/pi
Changeset: decd52611c978f16fed7d91be1b9b1d4d4d2289e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Oct 24 13:40:04 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/decd52611c978f16fed7d91be1b9b1d4d4d2289e [^]

Fixes Issue 0024960: Field groups are not displayed under some circumstances.

The focus item value is lost during form reflow in some particular scenarios.
Do overcome this, retrieved the lost focus item value and set it again after form redraw if they are not the same.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0061895)
hudsonbot   
2013-10-24 20:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0465c5073ba [^]

Maturity status: Test
(0061932)
shankarb   
2013-10-29 10:39   
The problem is inside the redraw method called in ob-view-form. The redraw parent call, calls the redraw method in Layout.js. But there the resizeMembers method is called to accomodate the new field groups to be displayed. Inside this method, again the redraw method is called. So it recurses again. This is where the value is lost. The exact place where value changes to null in the Super method in Class.js
(0061959)
AugustoMauch   
2013-10-30 09:52   
Code reviewed and verified in pi@2eb60e1f2b72