Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024820Openbravo ERPA. Platformpublic2013-09-24 12:422013-09-25 09:32
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP28 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024820: Order Date criteria is applied in the Organization filter
DescriptionOrder Date criteria is applied in the Organization filter
Steps To ReproduceTest here:https://livebuilds.openbravo.com/erp_mp_3.0MP27/ [^]
- As F&B Admin
- Open Purchase Order. Do not clear the filters
- Open the Order Date filter.
- Select any date and click the OK button.
- Notice that the criteria has been applied to the Organization filter

This issue is no longer reproducible in pi, but one of its underlying causes is still not fixed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-24 12:42AugustoMauchNew Issue
2013-09-24 12:42AugustoMauchAssigned To => AugustoMauch
2013-09-24 12:42AugustoMauchModules => Core
2013-09-24 12:42AugustoMauchTriggers an Emergency Pack => No
2013-09-24 12:46AugustoMauchIssue Monitored: shankarb
2013-09-24 12:46AugustoMauchReview Assigned To => shankarb
2013-09-24 12:47hgbotCheckin
2013-09-24 12:47hgbotNote Added: 0061367
2013-09-24 12:47hgbotStatusnew => resolved
2013-09-24 12:47hgbotResolutionopen => fixed
2013-09-24 12:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/92740d37c7e2b5b786417a1e03f808cb5b721ec1 [^]
2013-09-24 20:10hudsonbotCheckin
2013-09-24 20:10hudsonbotNote Added: 0061378
2013-09-25 09:32shankarbNote Added: 0061380
2013-09-25 09:32shankarbStatusresolved => closed
2013-09-25 09:32shankarbFixed in Version => 3.0MP28

Notes
(0061367)
hgbot   
2013-09-24 12:47   
Repository: erp/devel/pi
Changeset: 92740d37c7e2b5b786417a1e03f808cb5b721ec1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Sep 24 12:46:38 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/92740d37c7e2b5b786417a1e03f808cb5b721ec1 [^]

Fixes issue 24820: Criteria is applied only to the proper filter

There was a problem in the implementation of the canEditCriterion function:

  canEditCriterion: function (criterion) {
    return criterion && (criterion.fieldName === this.name || (criterion.fieldName === this.criteriaField));
  },

If both criterion.fieldName and this.criteriaField were undefined, it returned true. If this.criteriaField is undefined it should have returned false.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
---
(0061378)
hudsonbot   
2013-09-24 20:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/af5a5f1a0fe1 [^]

Maturity status: Test
(0061380)
shankarb   
2013-09-25 09:32   
Code reviewed and verified in pi changeset 684d905cbcc1