Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024804Openbravo ERPA. Platformpublic2013-09-20 09:562013-09-27 22:28
Reportercaristu 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version3.0MP28 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket23517
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024804: Filters are not working properly for translated fields
DescriptionFilters are not working properly for the translated values, if the user filters using the translated value zero results are obtained.
Steps To Reproduce1) Log-in with language Spanish (or any translation).
2) Go to the [Sales Order] window
3) Try to filter by document type used any of the translated values in the list. Notice that zero records are obtained
4) Try to filter, writing the document type original value (in English), the filter works fine now
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0023545 closed shankarb Window field filters are not translated in Menu 
related to defect 00247403.0MP28 closed alostale Filters for columns with list reference doesn't work properly on HQL defined selectors 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-20 09:56caristuNew Issue
2013-09-20 09:56caristuAssigned To => AugustoMauch
2013-09-20 09:56caristuModules => Core
2013-09-20 09:56caristuOBNetwork customer => Yes
2013-09-20 09:56caristuSupport ticket => 23517
2013-09-20 09:56caristuResolution time => 1382565600
2013-09-20 09:56caristuTriggers an Emergency Pack => No
2013-09-20 09:56caristuRelationship addedrelated to 0023545
2013-09-20 10:00caristuDescription Updatedbug_revision_view_page.php?rev_id=5037#r5037
2013-09-23 04:14shankarbAssigned ToAugustoMauch => shankarb
2013-09-23 08:33alostaleRelationship addedrelated to 0024740
2013-09-24 09:56shankarbNote Added: 0061364
2013-09-25 13:00alostaleNote Edited: 0061364bug_revision_view_page.php?bugnote_id=0061364#r5055
2013-09-26 08:08shankarbReview Assigned To => alostale
2013-09-26 08:09shankarbIssue Monitored: alostale
2013-09-26 08:10hgbotCheckin
2013-09-26 08:10hgbotNote Added: 0061402
2013-09-26 08:10hgbotStatusnew => resolved
2013-09-26 08:10hgbotResolutionopen => fixed
2013-09-26 08:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c6dbf71135bc6f94218ec0fed6b35beb3051c24d [^]
2013-09-26 12:34shankarbNote Added: 0061411
2013-09-26 12:34shankarbStatusresolved => new
2013-09-26 12:34shankarbResolutionfixed => open
2013-09-26 13:25hgbotCheckin
2013-09-26 13:25hgbotNote Added: 0061412
2013-09-26 13:27hgbotStatusnew => resolved
2013-09-26 13:27hgbotResolutionopen => fixed
2013-09-26 13:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c6dbf71135bc6f94218ec0fed6b35beb3051c24d [^] => http://code.openbravo.com/erp/devel/pi/rev/f497481ca351627e5336c307429c9b42c2fb924d [^]
2013-09-27 03:11hudsonbotCheckin
2013-09-27 03:11hudsonbotNote Added: 0061431
2013-09-27 03:11hudsonbotCheckin
2013-09-27 03:11hudsonbotNote Added: 0061433
2013-09-27 11:42alostaleNote Added: 0061440
2013-09-27 11:44hgbotCheckin
2013-09-27 11:44hgbotNote Added: 0061441
2013-09-27 11:45alostaleReview Assigned Toalostale => AugustoMauch
2013-09-27 14:02AugustoMauchNote Added: 0061446
2013-09-27 14:02AugustoMauchStatusresolved => closed
2013-09-27 14:02AugustoMauchFixed in Version => 3.0MP28
2013-09-27 22:28hudsonbotCheckin
2013-09-27 22:28hudsonbotNote Added: 0061455

Notes
(0061364)
shankarb   
2013-09-24 09:56   
(edited on: 2013-09-25 13:00)
The problem is that the grid data for document type is not translated. But the filter contains the translated item. So it is not getting filtered properly.
(0061402)
hgbot   
2013-09-26 08:10   
Repository: erp/devel/pi
Changeset: c6dbf71135bc6f94218ec0fed6b35beb3051c24d
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Sep 26 09:41:37 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/c6dbf71135bc6f94218ec0fed6b35beb3051c24d [^]

Fixes Issue 0024804: Filters are not working properly for translated fields

When retrieving the display property name, the values are not translated.
Instead when identifier values are retrieved, the values are translated.
Added code to translate the display property and search key.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
---
(0061411)
shankarb   
2013-09-26 12:34   
Fix creates runtime exception, when loading grid with timestamp values. Example, Sales Invoice - Payment Plan - Payment Details
(0061412)
hgbot   
2013-09-26 13:25   
Repository: erp/devel/pi
Changeset: f497481ca351627e5336c307429c9b42c2fb924d
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Sep 26 16:39:58 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f497481ca351627e5336c307429c9b42c2fb924d [^]

Fixes Issue 0024804: Filters are not working properly for translated fields

Retrieved the toString value instead of typecasting to string to avoid cast exception.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
---
(0061431)
hudsonbot   
2013-09-27 03:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/71a3ba7a4af8 [^]

Maturity status: Test
(0061433)
hudsonbot   
2013-09-27 03:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/71a3ba7a4af8 [^]

Maturity status: Test
(0061440)
alostale   
2013-09-27 11:42   
Current fix correctly displays in grid translated value for table reference fields, but it does not execute the correct query in backend. It is comparing translated value field set in filter with base language value field.

Note this apparently works fine in case of filtering on a record set with a size smaller than 100 records, this is due to the fact in this case filtering is computed in client side.
(0061441)
hgbot   
2013-09-27 11:44   
Repository: erp/devel/pi
Changeset: ffeabc536d1746b2f253f840255d74f825da3ed8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Sep 27 11:44:02 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ffeabc536d1746b2f253f840255d74f825da3ed8 [^]

related to bug 24804: backend filter for translated fields with table reference

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0061446)
AugustoMauch   
2013-09-27 14:02   
Code reviewed and verified in pi@34a6241c3e04
(0061455)
hudsonbot   
2013-09-27 22:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d3e738d010f4 [^]

Maturity status: Test