Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0024796Openbravo ERP07. Sales managementpublic2013-09-19 14:002014-06-20 17:54
maite 
caristu 
immediatemajoralways
closedfixed 
5
 
3.0MP28 
Advanced Payables and Receivables Mngmt
No
0024796: New recalculated Exchange Rate should be rounded when inserted in fin_payment table, when working with multicurrency
New recalculated Exchange Rate should be rounded when inserted in fin_payment table, when working with multicurrency
1. Configure "Transferencia" Payment Method as "Receive Payment in multiple currencies" in Financial Account "Cuenta de Banco"
2. Define conversion rate between USD and EUR as 1.12345678
3. Create new Payment In header for any BP using Transferencia and Cuenta de Banco and set currency=USD . set Amount=15 . Conversion rate information will be automatically loaded
4. "Add details" and set amount =15 and any gl item. Process. Realize that conversion rate has been recalculated to 1.12333333
5. Try to edit payment's description and error "Payment processed/posted" will be raised when it should not (problem is that value of finacc_txn_convert_rate field in database is not rounded)
Problem is in "setFinancialTransactionAmountAndRate" method in FIN_AddPayment file. Conversion rate is recalculated using following formula: finTxnConvertRate = finTxnAmount.divide(paymentAmount, MathContext.DECIMAL64);
Variable "finTxnConvertRate" needs to be rounded to number of decimals defined in Format.xml for "generalQty" type reference
No tags attached.
Issue History
2013-09-19 14:00maiteNew Issue
2013-09-19 14:00maiteAssigned To => dmiguelez
2013-09-19 14:00maiteModules => Advanced Payables and Receivables Mngmt
2013-09-19 14:00maiteTriggers an Emergency Pack => No
2013-09-19 14:00maiteTarget Version => 3.0MP28
2013-09-19 14:00maiteIssue Monitored: networkb
2013-09-19 14:11jonalegriaesarteAssigned Todmiguelez => caristu
2013-09-19 19:09hgbotCheckin
2013-09-19 19:09hgbotNote Added: 0061299
2013-09-19 19:09hgbotStatusnew => resolved
2013-09-19 19:09hgbotResolutionopen => fixed
2013-09-19 19:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/88ddb52efe0448e758620b656096584d7fc2a2c2 [^]
2013-09-20 14:15maiteNote Added: 0061318
2013-09-20 14:15maiteStatusresolved => closed
2013-09-20 16:14hudsonbotCheckin
2013-09-20 16:14hudsonbotNote Added: 0061323
2014-06-19 17:04hgbotCheckin
2014-06-19 17:04hgbotNote Added: 0068174
2014-06-20 17:54hudsonbotCheckin
2014-06-20 17:54hudsonbotNote Added: 0068233

Notes
(0061299)
hgbot   
2013-09-19 19:09   
Repository: erp/devel/pi
Changeset: 88ddb52efe0448e758620b656096584d7fc2a2c2
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 19 19:08:41 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/88ddb52efe0448e758620b656096584d7fc2a2c2 [^]

fixes issue 24796: New recalculated Exchange Rate should be rounded
 when inserted in fin_payment table, when working with multicurrency

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0061318)
maite   
2013-09-20 14:15   
verified
(0061323)
hudsonbot   
2013-09-20 16:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9adf8dd6aa1b [^]

Maturity status: Test
(0068174)
hgbot   
2014-06-19 17:04   
Repository: erp/devel/pi
Changeset: 1fe0e783e8513738f1993962798bee3f6253e8e9
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Jun 11 18:32:43 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1fe0e783e8513738f1993962798bee3f6253e8e9 [^]

[aprm-windows] Prevent Issue 0024796

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0068233)
hudsonbot   
2014-06-20 17:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/089e5cbefd60 [^]
Maturity status: Test