Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024778Openbravo ERP09. Financial managementpublic2013-09-16 12:592013-10-22 23:42
Reportervmromanos 
Assigned Topramakrishnan 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Versionpi 
Target Version3.0MP29Fixed in Version 
Merge Request Status
Review Assigned Topramakrishnan
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024778: Payment Monitor doesn't udpate invoice status when voiding a payment
DescriptionThe Payment Monitor doesn't update the invoice status in case any of the related payments is voided and the invoice was fully paid.
Steps To Reproduce1. Create an invoice
2. Pay it completely. The invoice is set a Payment Complete
3. Go to the payment and void it.
4. Go back to the invoice and verify the status is NOT updated and the invoice is still shown as fully paid.
Proposed SolutionRight now the payment monitor only updates the invoice in case it is not completely paid or it has outstanding amount <> 0. Instead we should check whether there are payment schedule details updated after the payment monitor previous run.

Find attached a patch that should fix it (and 0024768). Note that I haven't tested it deeply!
Additional Information
TagsNo tags attached.
Relationships
related to defect 00247683.0MP29 closed dmiguelez Payment Monitor NullPointer Exception in method calculateAmounts() 
Attached Filesdiff paymentmonitor.diff (3,841) 2013-09-18 10:40
https://issues.openbravo.com/file_download.php?file_id=6416&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-09-16 12:59vmromanosNew Issue
2013-09-16 12:59vmromanosAssigned To => dmiguelez
2013-09-16 12:59vmromanosFile Added: paymentmonitor.diff
2013-09-16 12:59vmromanosModules => Core
2013-09-16 12:59vmromanosTriggers an Emergency Pack => No
2013-09-16 12:59vmromanosRelationship addedrelated to 0024768
2013-09-16 13:43jonalegriaesarteTarget Version3.0MP28 => 3.0MP29
2013-09-18 10:40vmromanosFile Deleted: paymentmonitor.diff
2013-09-18 10:40vmromanosFile Added: paymentmonitor.diff
2013-10-03 10:18jonalegriaesarteAssigned Todmiguelez => pramakrishnan
2013-10-22 10:01hgbotCheckin
2013-10-22 10:01hgbotNote Added: 0061838
2013-10-22 10:01hgbotStatusnew => resolved
2013-10-22 10:01hgbotResolutionopen => fixed
2013-10-22 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c6559f88e5ab2d45a7c1e3a0a5ce801c05127a3 [^]
2013-10-22 10:02pramakrishnanReview Assigned To => pramakrishnan
2013-10-22 10:02pramakrishnanNote Added: 0061840
2013-10-22 10:02pramakrishnanStatusresolved => closed
2013-10-22 23:42hudsonbotCheckin
2013-10-22 23:42hudsonbotNote Added: 0061858

Notes
(0061838)
hgbot   
2013-10-22 10:01   
Repository: erp/devel/pi
Changeset: 0c6559f88e5ab2d45a7c1e3a0a5ce801c05127a3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Oct 21 12:26:36 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0c6559f88e5ab2d45a7c1e3a0a5ce801c05127a3 [^]

Fixes Issue 24778, Fixes Issue 24768

Payment Monitor doesn't udpate invoice status when voiding a payment
Payment Monitor NullPointer Exception in method calculateAmounts()

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
---
(0061840)
pramakrishnan   
2013-10-22 10:02   
Code Review + Testing - OK.
(0061858)
hudsonbot   
2013-10-22 23:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a362c560793b [^]

Maturity status: Test