Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0024771 | Openbravo ERP | A. Platform | public | 2013-09-14 09:32 | 2013-09-17 19:03 |
|
| Reporter | shuehner | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP28 | |
| Merge Request Status | |
| Review Assigned To | shankarb |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0024771: Broken/useless onCreateDefault statement |
| Description | There are quite a few identical onCreateDefault statements which are (now) broken and no longer useful.
As those always fail and create errors in log on the execution they should be removed.
ERROR: more than one row returned by a subquery used as an expression
STATEMENT: SELECT (SELECT AD_MODULE_ID FROM AD_MODULE WHERE AD_MODULE_ID<>'0' AND TYPE='M') FROM AD_MESSAGE LIMIT 1
Concretely:
Those are onCreateDefault constraints which are adding the 'ad_module_id' values to AD-tables on upgrade of 2.40 (which did not have modules) to 2.50.
In that upgrade all custom rows (which would need a module id generated) were placed into a customization module so there was exactly one module <> '0' in that upgrade so this sql code the value.
However now in pi first ad_module_id is mandatory and always filled + also there are always more module so that subselect can only fail with as it does not produce only a single value.
As upgrades from 2.40 to pi need to go always via 2.50 it should be fine to remove those onCreateDefaults in pi (and pi only) as there we are garanteed to always have those ad_module_id's filled and also if not those onCreateDefault would never work. |
| Steps To Reproduce | Check postgresql.log on any update.database for errors related to t |
| Proposed Solution | Remove the onCreateDefault values on pi as they cannot work. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  24771.diff (22,718) 2013-09-14 10:27
https://issues.openbravo.com/file_download.php?file_id=6407&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-09-14 09:32 | shuehner | New Issue | |
| 2013-09-14 09:32 | shuehner | Assigned To | => AugustoMauch |
| 2013-09-14 09:32 | shuehner | Modules | => Core |
| 2013-09-14 09:32 | shuehner | OBNetwork customer | => No |
| 2013-09-14 09:32 | shuehner | Triggers an Emergency Pack | => No |
| 2013-09-14 10:27 | shuehner | File Added: 24771.diff | |
| 2013-09-16 10:28 | AugustoMauch | Issue Monitored: shankarb | |
| 2013-09-16 10:28 | AugustoMauch | Review Assigned To | => shankarb |
| 2013-09-16 15:18 | hgbot | Checkin | |
| 2013-09-16 15:18 | hgbot | Note Added: 0061173 | |
| 2013-09-16 15:18 | hgbot | Status | new => resolved |
| 2013-09-16 15:18 | hgbot | Resolution | open => fixed |
| 2013-09-16 15:18 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/39da19e84a241426a1de3fe6e1f1be67ee2aca3b [^] |
| 2013-09-17 09:08 | shankarb | Note Added: 0061188 | |
| 2013-09-17 09:08 | shankarb | Status | resolved => closed |
| 2013-09-17 09:08 | shankarb | Fixed in Version | => 3.0MP28 |
| 2013-09-17 19:03 | hudsonbot | Checkin | |
| 2013-09-17 19:03 | hudsonbot | Note Added: 0061256 | |