0024768: Payment Monitor NullPointer Exception in method calculateAmounts()

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0024768

Openbravo ERP

09. Financial management

public

2013-09-13 12:56

2013-10-22 23:42

Reporter

vmromanos

Assigned To

dmiguelez

Priority

high

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Debian 5.0

Product Version

Target Version

3.0MP29

Fixed in Version

Merge Request Status

Review Assigned To

pramakrishnan

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0024768: Payment Monitor NullPointer Exception in method calculateAmounts()

Description

The FIN_PaymentMonitorProcess class contains the public static method updateInvoice() which can be invoked from outside of the class.
This method calls the calculateAmounts() which uses the "logger" variable in some flows. In this case we will get a NullPointer Exception because this variable is set in a non static method [execute()], so it is not initialized at this point if we use the FIN_PaymentMonitorProcess.updateInvoice() method.

Apart from that, the class has hardcoded messages like:
"ERROR Invoice " + invoice.getDocumentNo()
              + ": wrong payment plan info, paid amount is "
              + paymentSchedule.getPaidAmount().toPlainString() + " when it should be "
              + paid.toPlainString()

These messages should be declared in the application dictionary instead.

Steps To Reproduce

Not necessary

Proposed Solution

Easiest solution: add if (logger != null) before using the logger. Example:
if (paymentSchedule.getPaidAmount().compareTo(paid) != 0) {
        if (logger != null) {
          logger.log("ERROR Invoice " + invoice.getDocumentNo()
              + ": wrong payment plan info, paid amount is "
              + paymentSchedule.getPaidAmount().toPlainString() + " when it should be "
              + paid.toPlainString());
        }
        paymentSchedule.setPaidAmount(paid);
        OBDal.getInstance().save(paymentSchedule);
      }

Hardest solution: refactor the class to avoid this kind of problems

Don't forget to add the messages to the Application Dictionary

Additional Information