Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024741Openbravo ERPA. Platformpublic2013-09-11 13:542013-09-17 19:03
Reporteregoitz 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version3.0MP28 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024741: Error when inserting a row on grid mode pressing tab key for selecting a value on a selector
DescriptionError when inserting a row on grid mode pressing tab key for selecting a value on a selector
Steps To Reproduce-Access to the sales invoice window
-Click on insert on grid view
-Using the keyboardand tab fill the records.
-On the partner selector start righting a name of an existing selector.
-When the partner appears click on tab key to select it

*See that on the first exection the row is not saved and a new row to insert is opened.

Close the new row and cancel the insertiion of the row.

-Repeat the process to inert a new row

*On this time after click on tab key on the partner field the save button change to loading (saving) but never ends.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0024863 closed AugustoMauch Not possible to save a row on grid having a window personalization 
related to defect 0041016 closed caristu creating new record in grid, empty record generated if clicking line while retrieving defaults 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-11 13:54egoitzNew Issue
2013-09-11 13:54egoitzAssigned To => AugustoMauch
2013-09-11 13:54egoitzModules => Core
2013-09-11 13:54egoitzTriggers an Emergency Pack => No
2013-09-12 12:04egoitzPriorityurgent => immediate
2013-09-13 11:56egoitzAssigned ToAugustoMauch => alostale
2013-09-13 12:16egoitzNote Added: 0061139
2013-09-13 12:28egoitzNote Edited: 0061139bug_revision_view_page.php?bugnote_id=0061139#r5021
2013-09-13 12:34AugustoMauchAssigned Toalostale => AugustoMauch
2013-09-13 14:58AugustoMauchNote Added: 0061143
2013-09-16 15:17AugustoMauchIssue Monitored: shankarb
2013-09-16 15:17AugustoMauchReview Assigned To => shankarb
2013-09-16 15:18hgbotCheckin
2013-09-16 15:18hgbotNote Added: 0061174
2013-09-16 15:18hgbotStatusnew => resolved
2013-09-16 15:18hgbotResolutionopen => fixed
2013-09-16 15:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9138cdfbcb9badfceaf1a0eb54b4be87fec6eb35 [^]
2013-09-17 09:06shankarbNote Added: 0061187
2013-09-17 09:06shankarbStatusresolved => closed
2013-09-17 09:06shankarbFixed in Version => 3.0MP28
2013-09-17 19:03hudsonbotCheckin
2013-09-17 19:03hudsonbotNote Added: 0061257
2013-10-02 09:08egoitzRelationship addedrelated to 0024863
2019-06-07 12:09caristuRelationship addedrelated to 0041016

Notes
(0061139)
egoitz   
2013-09-13 12:16   
(edited on: 2013-09-13 12:28)
The problems seems to be caused because the callout on a field on the grid trying to update a field not on the grid.
Also with a validation of a field not in grid referring to a field changed on the grid
(0061143)
AugustoMauch   
2013-09-13 14:58   
This happens because the datasource request to save the record is issued before receiving the FIC response. The FIC response contains the values updated after executing the callouts, so the datasource request does not have this updated data.

To solve this, the datasource request needs to be delayed until the FIC response is processed.
(0061174)
hgbot   
2013-09-16 15:18   
Repository: erp/devel/pi
Changeset: 9138cdfbcb9badfceaf1a0eb54b4be87fec6eb35
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 16 15:06:01 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9138cdfbcb9badfceaf1a0eb54b4be87fec6eb35 [^]

Fixes issue 24741: Row saved by pressing a tab for picking a selector value

The problem was that the request to the datasource to save the new record was being done before the response of the FIC (it was called because picking a business partner triggers a callout to select its location) was received and processed. This has been fixed by delaying the execution of the cellEditEnd function until the FIC response has been processed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0061187)
shankarb   
2013-09-17 09:06   
Code reviewed and verified in pi changeset a549285cc9f0
(0061257)
hudsonbot   
2013-09-17 19:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1c53d622fc50 [^]

Maturity status: Test