Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024698Openbravo ERPA. Platformpublic2013-09-05 13:332013-09-25 10:21
Reporteregoitz 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version3.0MP28 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024698: When opening a window two request to save the view on recent view section are send
DescriptionWhen opening a window two request to save the view on recent view section are send
Steps To ReproduceUsing chrome, open the developer tools on network section.
Open the product window.
See on the developert tools that two request has been done to seve the recent view.
The first is faster than the second. This last request takes arround 1 sec.

Proposed Solution
Additional Information
TagsPerformance
Relationships
has duplicate defect 0024227 closed shuehner When opening a window the request to update the RecentViewList is sent twice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-05 13:33egoitzNew Issue
2013-09-05 13:33egoitzAssigned To => AugustoMauch
2013-09-05 13:33egoitzModules => Core
2013-09-05 13:33egoitzTriggers an Emergency Pack => No
2013-09-05 13:33egoitzTag Attached: Performance
2013-09-05 15:57jpcalventeIssue Monitored: jpcalvente
2013-09-08 09:37shankarbAssigned ToAugustoMauch => shankarb
2013-09-09 13:06shankarbReview Assigned To => AugustoMauch
2013-09-09 13:06shankarbIssue Monitored: AugustoMauch
2013-09-09 13:07hgbotCheckin
2013-09-09 13:07hgbotNote Added: 0060973
2013-09-09 13:07hgbotStatusnew => resolved
2013-09-09 13:07hgbotResolutionopen => fixed
2013-09-09 13:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9f4f2629b7ff602d495f7336a449b9f0a1c65064 [^]
2013-09-13 09:39AugustoMauchNote Added: 0061130
2013-09-13 09:39AugustoMauchStatusresolved => new
2013-09-13 09:39AugustoMauchResolutionfixed => open
2013-09-15 08:01shankarbRelationship addedhas duplicate 0024227
2013-09-16 05:51hgbotCheckin
2013-09-16 05:51hgbotNote Added: 0061163
2013-09-16 05:51hgbotStatusnew => resolved
2013-09-16 05:51hgbotResolutionopen => fixed
2013-09-16 05:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/9f4f2629b7ff602d495f7336a449b9f0a1c65064 [^] => http://code.openbravo.com/erp/devel/pi/rev/d03d06d3cd71a3cd0e7c9e08c89ef206758c450c [^]
2013-09-17 19:02hudsonbotCheckin
2013-09-17 19:02hudsonbotNote Added: 0061227
2013-09-17 19:03hudsonbotCheckin
2013-09-17 19:03hudsonbotNote Added: 0061254
2013-09-25 10:21alostaleNote Added: 0061383
2013-09-25 10:21alostaleStatusresolved => closed
2013-09-25 10:21alostaleFixed in Version => 3.0MP28

Notes
(0060973)
hgbot   
2013-09-09 13:07   
Repository: erp/devel/pi
Changeset: 9f4f2629b7ff602d495f7336a449b9f0a1c65064
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Sep 09 16:35:02 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9f4f2629b7ff602d495f7336a449b9f0a1c65064 [^]

Fixes Issue 0024698: When opening a window two request to save the view on recent view section are send

When launching a menu through quick launch, two calls to save the Recent view is made.
One is happening in the quick launch and other in the default openView method.
Removed the code to add to recent view in quick launch.
The same code is accessed when creating a new record through create new record so the issue is fixed there too.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
---
(0061130)
AugustoMauch   
2013-09-13 09:39   
Reopened because it is still reproducible.

In live builds, the double request to the StorePropertyActionHandler to set the OBUIAPP_RecentViewList is done in the following cases (tested in https://livebuilds.openbravo.com/erp_pi_pgsql [^]):
- When entering 'Currency' in the quick launch and pressing enter
- When clicking on the Currency label in the Recent Views section
- When clicking on the Currency label in the top part of the Quick Launch section
- When clicking on the Currency label in the top part of the Application section.
(0061163)
hgbot   
2013-09-16 05:51   
Repository: erp/devel/pi
Changeset: d03d06d3cd71a3cd0e7c9e08c89ef206758c450c
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Sep 16 09:16:09 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/d03d06d3cd71a3cd0e7c9e08c89ef206758c450c [^]

Fixes Issue 0024698: When opening a window two request to save the view on recent view section are send

Modify recent view list only if needed. If the object at index 0 is going to be readded, skip.
This is done to avoid multiple calls to server for setting the Recent View List.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-recent-utilities.js
---
(0061227)
hudsonbot   
2013-09-17 19:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1c53d622fc50 [^]

Maturity status: Test
(0061254)
hudsonbot   
2013-09-17 19:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1c53d622fc50 [^]

Maturity status: Test
(0061383)
alostale   
2013-09-25 10:21   
Code reviewed + tested