Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024692Openbravo ERPA. Platformpublic2013-09-04 17:102013-10-03 18:19
Reportercaristu 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version3.0MP28 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024692: Double request to the datasource is done when a numeric field is in the first position of the grid
DescriptionA double request is done to the datasource if we configure a numeric field as the first in the grid. This causes that the target record is not selected when navigating to that window. This sometimes causes that the child tab information doesn't appear.
Steps To Reproduce1) Go to the [Product] window and display the Weight field (the related column uses a numeric reference)
2) Place it in the first position of the grid
3) Go to the [Purchase/Sales Order] window and create a new order with at least one line.
4) Navigate from the [Lines] tab to the [Product] window
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0047941 closed AugustoMauch Issue in creating a order line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-04 17:10caristuNew Issue
2013-09-04 17:10caristuAssigned To => AugustoMauch
2013-09-04 17:10caristuWeb browser => Google Chrome
2013-09-04 17:10caristuModules => Core
2013-09-04 17:10caristuTriggers an Emergency Pack => No
2013-09-04 17:10caristuIssue Monitored: networkb
2013-09-04 17:10caristuWeb browserGoogle Chrome => Google Chrome
2013-09-04 17:10caristuSummaryDouble request to the datasource when a numeric field is the first in the grid => Double request to the datasource is made when a numeric field is the first in the grid
2013-09-04 17:12caristuWeb browserGoogle Chrome => Google Chrome
2013-09-04 17:12caristuSummaryDouble request to the datasource is made when a numeric field is the first in the grid => Double request to the datasource is done when a numeric field is in the first position of the grid
2013-09-10 08:54shankarbAssigned ToAugustoMauch => shankarb
2013-09-16 07:56shankarbStatusnew => scheduled
2013-09-16 07:56shankarbfix_in_branch => pi
2013-09-24 09:40shankarbReview Assigned To => AugustoMauch
2013-09-24 09:40shankarbWeb browserGoogle Chrome => Google Chrome
2013-09-24 09:40shankarbfix_in_branchpi =>
2013-09-24 09:40shankarbIssue Monitored: AugustoMauch
2013-09-24 09:41hgbotCheckin
2013-09-24 09:41hgbotNote Added: 0061363
2013-09-24 09:41hgbotStatusscheduled => resolved
2013-09-24 09:41hgbotResolutionopen => fixed
2013-09-24 09:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2bbac483aff8d1414f4017a2c89ae839ad292384 [^]
2013-09-24 20:10hudsonbotCheckin
2013-09-24 20:10hudsonbotNote Added: 0061377
2013-09-25 08:57alostaleNote Added: 0061379
2013-09-25 08:57alostaleStatusresolved => new
2013-09-25 08:57alostaleResolutionfixed => open
2013-09-25 08:59alostaleNote Edited: 0061379bug_revision_view_page.php?bugnote_id=0061379#r5047
2013-09-25 11:18hgbotCheckin
2013-09-25 11:18hgbotNote Added: 0061388
2013-09-25 11:18hgbotStatusnew => resolved
2013-09-25 11:18hgbotResolutionopen => fixed
2013-09-25 11:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/2bbac483aff8d1414f4017a2c89ae839ad292384 [^] => http://code.openbravo.com/erp/devel/pi/rev/327a7d8af6cee2d1d0abcbf50854380fee17b790 [^]
2013-09-25 19:58hudsonbotCheckin
2013-09-25 19:58hudsonbotNote Added: 0061396
2013-09-27 10:09alostaleReview Assigned ToAugustoMauch => alostale
2013-09-27 11:51alostaleNote Added: 0061442
2013-09-27 11:51alostaleStatusresolved => closed
2013-09-27 11:51alostaleFixed in Version => 3.0MP28
2013-10-03 18:19alostaleTag Attached: Performance
2021-12-01 00:22AugustoMauchRelationship addedrelated to 0047941

Notes
(0061363)
hgbot   
2013-09-24 09:41   
Repository: erp/devel/pi
Changeset: 2bbac483aff8d1414f4017a2c89ae839ad292384
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Sep 24 13:08:10 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/2bbac483aff8d1414f4017a2c89ae839ad292384 [^]

Fixes Issue 0024692: Double request to the datasource is done when a numeric field is in the first position of the grid

In numeric fields, then in the blur event, the filters are applied again if its not applied through performGridAction.
But this was resulting in double datasource calls, if the numeric field is the first field of the grid.
Added validation to performGridAction only if the numeric field is not the first field of the grid.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0061377)
hudsonbot   
2013-09-24 20:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/af5a5f1a0fe1 [^]

Maturity status: Test
(0061379)
alostale   
2013-09-25 08:57   
(edited on: 2013-09-25 08:59)
Reopening because it causes a regression: blur event in numeric filter fields doesn't apply the filter.

Test cases:
-Following steps to reproduce -> FIXED
-Filtering by numeric field having it in first position in grid pressing enter after setting the number -> WORKS
-Filtering by numeric field having it in other grid position pressing enter after setting the number -> WORKS
-Filter by numeric field in any grid position by entering the number and pressing tab to move to next filter field -> DOES NOT APPLY FILTER: REGRESSION

Note current fix is preventing datasource call in numeric filter fields in ALL cases:

  this.form.getFocusItem() === this

always evaluates true in the blur method
(0061388)
hgbot   
2013-09-25 11:18   
Repository: erp/devel/pi
Changeset: 327a7d8af6cee2d1d0abcbf50854380fee17b790
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Sep 25 13:28:36 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/327a7d8af6cee2d1d0abcbf50854380fee17b790 [^]

Fixes Issue 0024692: Double request to the datasource is done when a numeric field is in the first position of the grid

The filter in blur event needs to be applied only if the value is not undefined.
In case there is value in the filter and then the value is cleared,
still the filter will be applied because the value returned will be null and not undefined.
Also the additional datasource call will be avoided as in that case, the value is undefined.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0061396)
hudsonbot   
2013-09-25 19:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a06bf757c7ec [^]

Maturity status: Test
(0061442)
alostale   
2013-09-27 11:51   
Code reviewed and tested according to tests cases explained in note above