Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024684Openbravo ERPA. Platformpublic2013-09-04 09:592013-11-05 12:18
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP28 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024684: Double DataSource request when there is grid configuration
DescriptionDouble request to DataSource is performed when opening the window when there is a grid configuration in root tab that modifies the default order by.

In addition, the grid is loaded first in with the Standard view and after it is rendered, customized grid is applied resulting in a blink in the GUI.
Steps To ReproduceIn a professional instance

 -Open Sales Order window in grid view
 -Sort by Order Date column
 -Move Order Date column to the first position in grid
 -Remove all the columns in grid but Order Date and Document No.
 -Close Sales Order window
 -Reopen it having Developer's Tools Network tab open
   -> Notice how first time grid is opened showing all columns in the Standard view and sorting by Document No column (default one), after that grid is rerendered hidding the rest of the columns and sorting properly
   -> See there are two request to Order datasorce
Proposed SolutionEven grid configuration is stored locally in the client, it is applied after creating the view with its standard visualization. In case of grid configuration, it should be applied when creating the view.
Additional Information
TagsPerformance
Relationships
related to defect 0024686 closed alostale Grid configuration not saved if the only config is different sorting 
related to design defect 0024687 closed dbaz Double DataSource request when there using a saved view 
related to defect 00251193.0MP30 closed alostale Problem with grid configuration and field grouping 
related to defect 00271573.0PR14Q4 closed AugustoMauch summary functions in saved view/grid config cause several requests 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-04 09:59alostaleNew Issue
2013-09-04 09:59alostaleAssigned To => alostale
2013-09-04 09:59alostaleModules => Core
2013-09-04 09:59alostaleTriggers an Emergency Pack => No
2013-09-04 10:02alostaleProposed Solution updated
2013-09-04 10:02alostaleReview Assigned To => dbaz
2013-09-04 10:02alostaleTag Attached: Performance
2013-09-04 10:10alostaleNote Added: 0060906
2013-09-04 10:14hgbotCheckin
2013-09-04 10:14hgbotNote Added: 0060907
2013-09-04 10:14hgbotStatusnew => resolved
2013-09-04 10:14hgbotResolutionopen => fixed
2013-09-04 10:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f497677fd0d957afd9b2c9ee51488a82fdb04667 [^]
2013-09-04 10:21alostaleRelationship addedrelated to 0024686
2013-09-04 10:39alostaleRelationship addedrelated to 0024687
2013-09-17 19:02hudsonbotCheckin
2013-09-17 19:02hudsonbotNote Added: 0061212
2013-09-17 20:42dbazNote Added: 0061263
2013-09-17 20:42dbazStatusresolved => closed
2013-09-17 20:42dbazFixed in Version => 3.0MP28
2013-11-05 12:18dbazIssue Monitored: dbaz
2013-11-15 09:13alostaleRelationship addedrelated to 0025119
2014-07-22 17:03alostaleRelationship addedrelated to 0027157

Notes
(0060906)
alostale   
2013-09-04 10:10   
Executed test cases:

- Following steps to reproduce in this issue, a single request is performed
- When there is a grid configuration and toolbar's view's menu is open, Standard View is not selected
- Saved views still work as before the fix
- Grid configuration is only applied in professional instances
(0060907)
hgbot   
2013-09-04 10:14   
Repository: erp/devel/pi
Changeset: f497677fd0d957afd9b2c9ee51488a82fdb04667
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Sep 04 10:14:05 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f497677fd0d957afd9b2c9ee51488a82fdb04667 [^]

fixed bug 24684: Double DataSource request when there is grid configuration

  viewState (grid configuration) is set when building view structure so it is
  used in first DS request preventing in this way second one and displaying
  directly the customized grid without need of redrawing it.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0061212)
hudsonbot   
2013-09-17 19:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1c53d622fc50 [^]

Maturity status: Test
(0061263)
dbaz   
2013-09-17 20:42   
Reviewed @ changeset: 21154 - 8c4c0a929010