Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024680Openbravo ERPA. Platformpublic2013-09-03 14:532013-09-17 19:02
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP28 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024680: Improve performance of translation import - part2
DescriptionThe translation import code is doing a commit per inserted translation row. That is very inefficient for performance.

Doing 1 commit per imported file does improve performance a lot.
Steps To ReproduceInstall i.e. spanish core translation module and observe runtime of the part importing translation into the database.
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 00245333.0MP27 closed shuehner Improve performance of translation import 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-03 14:53shuehnerNew Issue
2013-09-03 14:53shuehnerAssigned To => shuehner
2013-09-03 14:53shuehnerModules => Core
2013-09-03 14:53shuehnerTriggers an Emergency Pack => No
2013-09-03 14:54shuehnerRelationship addedrelated to 0024533
2013-09-04 15:51hgbotCheckin
2013-09-04 15:51hgbotNote Added: 0060917
2013-09-04 15:51hgbotStatusnew => resolved
2013-09-04 15:51hgbotResolutionopen => fixed
2013-09-04 15:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d9b490f70ad2976ec248bcaf37ae8cf53e252847 [^]
2013-09-04 15:53shuehnerReview Assigned To => alostale
2013-09-04 15:53shuehnerNote Added: 0060919
2013-09-04 15:53alostaleTag Attached: Performance
2013-09-13 07:55alostaleNote Added: 0061123
2013-09-13 07:55alostaleStatusresolved => closed
2013-09-13 07:55alostaleFixed in Version => 3.0MP28
2013-09-17 19:02hudsonbotCheckin
2013-09-17 19:02hudsonbotNote Added: 0061217

Notes
(0060917)
hgbot   
2013-09-04 15:51   
Repository: erp/devel/pi
Changeset: d9b490f70ad2976ec248bcaf37ae8cf53e252847
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Sep 04 15:49:58 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d9b490f70ad2976ec248bcaf37ae8cf53e252847 [^]

Fixed 24680: Speed up translation import by not doing commits per _trl row.
This commit changes translation import to not do an implicit commit per row
updated but bigger transaction + a single commit per imported xml file.
This speed ups translation import greatly.

---
M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
---
(0060919)
shuehner   
2013-09-04 15:53   
Testing done:
preparation: install spanish core translations
- ant apply.module (on postgres + oracle)
Rest of tests only done on postgres as there is no special need to repeat on both db's
- export translation to attachment folder via application (import/export translation window)
- import translation via same window
- install 'Translation management extension' module
- Use export+import using that module for the module containing the spanish core translation (two new buttons in module window).
(0061123)
alostale   
2013-09-13 07:55   
Code reviewed + tested in Oracle and PG
(0061217)
hudsonbot   
2013-09-17 19:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1c53d622fc50 [^]

Maturity status: Test