Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0002467Openbravo ERP07. Sales managementpublic2008-01-04 11:342008-07-10 11:36
user71 
pheenan 
normalmajoralways
closedfixed 
5
 
2.402.40beta 
No
Core
No
0002467: AT235MP1: Create a goods shipment from a sales order
Sales management->Transactions->Create shipments from orders: after selecting BP and sales order, and "Process", order still shows and Goods Shipment is not created.
---
Paulo Leandro
QA user: guest3
No tags attached.
Issue History
2008-06-13 19:50cromeroStatusnew => scheduled
2008-06-13 19:53cromeroSeverityminor => major
2008-06-13 19:53cromeroTarget Version => 2.50
2008-06-13 19:53cromeroDescription Updated
2008-06-17 11:45pjuvaraTarget Version2.50 => 2.40
2008-06-22 12:51svnbotCheckin
2008-06-22 12:51svnbotNote Added: 0007943
2008-06-22 12:51svnbotStatusscheduled => resolved
2008-06-22 12:51svnbotResolutionopen => fixed
2008-06-22 12:51svnbotsvn_revision => 5287
2008-07-07 17:36pheenanNote Added: 0008190
2008-07-10 11:36plujanStatusresolved => closed
2008-07-10 11:36plujanFixed in Version2.40 => 2.40beta

Notes
(0006056)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1863872 [^]
(0002942)
pjuvara   
2008-01-07 14:08   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1871571
Originator: NO

Paulo: we are not able to reproduce this issue. Can you please add more detailed reproduction steps?
Thanks
(0002943)
user71   
2008-01-07 16:23   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1338238
Originator: YES

Hi.

I'm attaching a PDF file with some printouts.

I proceeded exactly as stated in test case TCA113-0.1 in order to create the Sales Order:
- Logedin as userA
- Sales management->Transactions->Sales Order
- New and select Transaction Document: Standard Order
- Selected business partner CUSTOMER A
- Moved to tab Lines and clicked New
- Selected 'Final goods'
- UOM:Unit; Unit price:2; List price:2; Tax:VAT (3)+CHARGE(0.5); Ordered quantity= 1
- Moved to header and completed.
- Verified that: Summed Line Amount= 2 and Grand Total Amount= 2.07
- Sales Order no. 50007

As for test case TCA114-0.1:
- Logedin as userA;
- Sales management->Transactions->Create shipments from orders
- Selected the sales order no. 50007 and clicked Process

The results are in the printouts attached.
As you can see, after 'Process' and although there is a message saying that "The process completed successfully", the order is still showing up.
Choosing Sales management->Transactions->Goods shipment, there isn't any shipment created, only the existing one created by hand (with Create Lines From) for the test cases. See also attached printouts.

I hope this is clear. Anyway, feel free to contact.

Regards,
---
Paulo Leandro
QA user: guest3
File Added: TCA114-0.1.pdf.zip
(0002944)
plujan   
2008-01-08 13:52   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1759992
Originator: NO

Hi Paulo,

Could you please create a new Order and attach a screenshot showing the Create Shipment window just before pressing the Process button?

Thanks,
Pablo Luján, QA Team.
(0002945)
user71   
2008-01-09 12:27   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1236898
Originator: NO

Hi Paulo,

I've encountered this problem before.

You need to make sure there quantity of stock in hand for the said goods is not zero. ie. stock is available.

I believe the bugs is not on whether goods shipment created or not, but rather on the message. It should says, sth like "Insufficient quantity available for xxx stock".

Or better still, with the option 'Allow negative stock' checked, system should allow creation of Goods Shipment resulting to negative stock.

Some decision need to be made by the Openbravo people about this. In the mean time, can somebody point me to the piece of code responsible for this so I can do a quick hack.

Regards,
(0002946)
user71   
2008-01-09 13:36   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1338238
Originator: YES

Hi to all.

Thanks a lot xeonn ;-)

I can CONFIRM the described behavior:

1. If Quantity on hand is "zero", the process will fail, i.e., the Shipment WILL NOT be created.

2. If Quantity on Hand > "zero", the Shipment IS indeed created and it won't show up anymore in the "Create Shipments from Orders" grid.

I also passed this info to the QA team working with me.

Regards,
---
Paulo Leandro
QA user: guest3
(0002947)
pjuvara   
2008-01-10 09:10   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1871571
Originator: NO

We need to change the messages so that the behavior is clear.
(0002948)
user71   
2008-01-12 04:51   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1236898
Originator: NO

Here are my suggestions in addition to fixing the message:-

1- "General Setup->Client->Client Information->AllowNegativeStock" should be honoured upon 'Create shipments from orders". Reason: System says *AllowNegativeStock*, walk the talk.

2- Documents generated should not immediately 'Posted'. Reason: To allow user make partial delivery.
(0002949)
pheenan   
2008-05-16 13:02   
(edited on: 2008-06-12 09:24)
Logged In: YES
user_id=1883435
Originator: NO

I have been looking through this issue and the functionality around it.

Firstly, the Allow Negative Stock option does not appear to be relevant to this process. The generation of the shipment and the quantity is based around the defined Delivery Rule in the header of the order. Depending on the selection made here the process will generate a shipment for the correct quantity, and if there is insufficient to complete the rule it will remain in the list of orders to select from. When it is processed the next time a shipment will be created for the remaining quantity.

There are still some issues with the messages being returned.
When are partial shipment is created the message does not state that the remainder will be processed when available.
When an order cannot be filled the message returned is 'Process Completed Successfully', should state that there is insufficient quantity to process the order.

Creating a delivery rule to allow the creation of a shipment for more than the quantity currently on hand would involve the addition of a new delivery rule and modifying the M_INOUT_CREATE procedure.
(0007943)
svnbot   
2008-06-22 12:51   
Repository: openbravo
Revision: 5287
Author: pheenan
Date: 2008-06-22 12:51:42 +0200 (Sun, 22 Jun 2008)

Fixed bug 2467. Added message handling to the end of the curorder loop. Set v_document to empty at the beginning of the curOrder loop.

---
U trunk/src-db/database/model/functions/M_INOUT_CREATE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=5287&sc=1 [^]
(0008190)
pheenan   
2008-07-07 17:36   
Added note raised on Sourceforge directly.

Date: 2008-07-07 13:35
Sender: xeonn
Logged In: YES
user_id=1236898
Originator: NO

My customer's production and logistic dept run 24 hours a day. The
storekeeper work normal hours from 8am to 6pm.

Logistic dept, whom are responsible for Goods Shipment, are unable to
create Goods Shipment upon delivery if there are no stock in hand. Updating
the stock in hand is the storekeepers job.

If the Allow Negative Stock option is not relevant, then, how do I work
around the scenario above. The goal is to allow creation of Goods Shipment,
even if the data not updated.

I seek advice, as I do not want to stray the codes from mainline
Openbravo. (I did a few, and it gives me headache especially upon
upgrades).