Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024638Openbravo ERPA. Platformpublic2013-08-30 14:412013-10-01 17:04
Reportercaristu 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version3.0MP28 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024638: An error appears when using a field in the tab display logic which is present in the header and also in the tab
DescriptionAn error appears (see attached screenshot) if we use a display logic for a tab which uses a field name, which is present in the header and also in the tab we want to apply this display logic
Steps To ReproduceAs system administrator role
1) Go to the [Windows, Tabs and fields] window and look for the Sales Invoice window
2) Add the following display logic for the lines tab: @AD_Org_ID@='7BABA5FF80494CAFA54DEBD22EC46F01' (AD_Org_ID field is present in both header and lines tab)
Log-out and log-in as group admin role
3) Go to the Sales Invoice window

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00246373.0MP28 closed shankarb Display Logic does not work in tabs located in windows that have several tabs referencing the same entity 
related to defect 00247633.0MP29 closed AugustoMauch Display logic for tabs not working properly for tabs that reference the same entity of the header 
related to defect 0025307 closed AugustoMauch Display logic based on preferences 
related to defect 00253873.0MP31 closed alostale unneeded flushes in view generation 
Attached Filespng dlError.png (72,069) 2013-08-30 14:41
https://issues.openbravo.com/file_download.php?file_id=6362&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2013-08-30 14:41caristuNew Issue
2013-08-30 14:41caristuAssigned To => AugustoMauch
2013-08-30 14:41caristuFile Added: dlError.png
2013-08-30 14:41caristuModules => Core
2013-08-30 14:41caristuTriggers an Emergency Pack => No
2013-08-30 14:41caristuRelationship addedrelated to 0024637
2013-09-03 09:53AugustoMauchAssigned ToAugustoMauch => shankarb
2013-09-19 07:36hgbotCheckin
2013-09-19 07:36hgbotNote Added: 0061289
2013-09-19 07:36hgbotStatusnew => resolved
2013-09-19 07:36hgbotResolutionopen => fixed
2013-09-19 07:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/06606d1fa59dc0e973c2033683e7e041672227f7 [^]
2013-09-19 11:27shankarbNote Added: 0061291
2013-09-19 11:27shankarbStatusresolved => new
2013-09-19 11:27shankarbResolutionfixed => open
2013-09-19 14:52hudsonbotCheckin
2013-09-19 14:52hudsonbotNote Added: 0061297
2013-09-30 13:56shankarbReview Assigned To => AugustoMauch
2013-09-30 13:56shankarbIssue Monitored: AugustoMauch
2013-09-30 14:01hgbotCheckin
2013-09-30 14:01hgbotNote Added: 0061486
2013-09-30 14:01hgbotStatusnew => resolved
2013-09-30 14:01hgbotResolutionopen => fixed
2013-09-30 14:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/06606d1fa59dc0e973c2033683e7e041672227f7 [^] => http://code.openbravo.com/erp/devel/pi/rev/73df6c79ca82f5fcc60cddda824d6bd721e05067 [^]
2013-09-30 14:04alostaleRelationship addedrelated to 0024763
2013-09-30 15:05AugustoMauchNote Added: 0061487
2013-09-30 15:05AugustoMauchStatusresolved => closed
2013-09-30 15:05AugustoMauchFixed in Version => 3.0MP28
2013-10-01 17:04hudsonbotCheckin
2013-10-01 17:04hudsonbotNote Added: 0061507
2013-12-12 12:52AugustoMauchRelationship addedrelated to 0025307
2013-12-20 12:42alostaleRelationship addedrelated to 0025387

Notes
(0061289)
hgbot   
2013-09-19 07:36   
Repository: erp/devel/pi
Changeset: 06606d1fa59dc0e973c2033683e7e041672227f7
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Sep 19 11:04:32 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/06606d1fa59dc0e973c2033683e7e041672227f7 [^]

Fixes Issue 0024638: An error appears when using a field in the tab display logic which is present in the header and also in the tab

If a window has more than one tab with the same entity then getParentTab was returning incorrect values.
getParentTab has been modified to look at the logical arrangement of tabs alone and retrieve the parent tab.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java
A modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils_data.xsql
---
(0061291)
shankarb   
2013-09-19 11:27   
Issue not fixed yet.
(0061297)
hudsonbot   
2013-09-19 14:52   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/407564ea9109 [^]

Maturity status: Test
(0061486)
hgbot   
2013-09-30 14:01   
Repository: erp/devel/pi
Changeset: 73df6c79ca82f5fcc60cddda824d6bd721e05067
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Sep 30 17:25:31 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/73df6c79ca82f5fcc60cddda824d6bd721e05067 [^]

Fixes Issue 0024638: An error appears when using a field in the tab display logic which is present in the header and also in the tab

The following actions has been done to fix the issue.
* When generating display logic for tabs, the parameter needs to be fetched from context and not from currentValues.
* When executing the display logic for a tab at runtime, always use the context of the parent,
as that contains the context variables for displaying the child tab.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0061487)
AugustoMauch   
2013-09-30 15:05   
Code reviewed and verified in pi@73df6c79ca82
(0061507)
hudsonbot   
2013-10-01 17:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/541c707a5e9b [^]

Maturity status: Test