Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024516Retail ModulesWeb POSpublic2013-08-08 17:452013-08-21 08:33
Reporteralostale 
Assigned Toguilleaer 
PriorityurgentSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRMP26Fixed in VersionRMP26 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024516: WebPOS relies on delivery status to check if a ticket is a layaway
DescriptionWebPOS relies on delivery status to check if a ticket is a layaway. It needs to be reviewed if it makes sense from the functional point of view.

From the technical point of view, current query might have performance problems because it relies in computed columns.

Additionally, API will change starting from MP27, so it will be required to modify it to (in the worse of the cases) use the proxy to access the computed column starting from RMP27.
Steps To ReproduceSee PaidReceiptProperties:

        add(new HQLProperty("(case when ord.deliveryStatus = 0 then true else false end)",
            "isLayaway")); // TODO: computed column, it should be refactored
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0024212 closed marvintm Retail Modules WebPOS relies on delivery status field to create or not the invoices. Wrong in some cases 
related to defect 0024495 closed alostale Openbravo ERP Lazy computed columns API chage 
related to design defect 00241043.0MP27 closed alostale Openbravo ERP Unnecessary evaluation of computed columns 
related to design defect 0024283 closed migueldejuana Retail Modules Avoid using computed columns 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-08-08 17:45alostaleNew Issue
2013-08-08 17:45alostaleAssigned To => guilleaer
2013-08-08 17:45alostaleTriggers an Emergency Pack => No
2013-08-08 17:45alostaleRelationship addedrelated to 0024212
2013-08-08 17:46alostaleRelationship addedrelated to 0024495
2013-08-08 17:46alostaleRelationship addedrelated to 0024104
2013-08-09 11:07guilleaerRelationship addedrelated to 0024283
2013-08-12 19:01hgbotCheckin
2013-08-12 19:01hgbotNote Added: 0060579
2013-08-20 11:12hgbotCheckin
2013-08-20 11:12hgbotNote Added: 0060673
2013-08-20 11:12hgbotStatusnew => resolved
2013-08-20 11:12hgbotResolutionopen => fixed
2013-08-20 11:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3a10c0c70392a461b7f6e9f03b82c6b911e348fa [^]
2013-08-20 23:39guilleaerReview Assigned To => guilleaer
2013-08-20 23:39guilleaerNote Added: 0060688
2013-08-20 23:39guilleaerStatusresolved => closed
2013-08-20 23:39guilleaerFixed in Version => RMP26
2013-08-21 08:31hgbotCheckin
2013-08-21 08:31hgbotNote Added: 0060690
2013-08-21 08:31hgbotStatusclosed => resolved
2013-08-21 08:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3a10c0c70392a461b7f6e9f03b82c6b911e348fa [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-rds/rev/3a10c0c70392a461b7f6e9f03b82c6b911e348fa [^]
2013-08-21 08:33guilleaerNote Added: 0060695
2013-08-21 08:33guilleaerStatusresolved => closed

Notes
(0060579)
hgbot   
2013-08-12 19:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 56c4d15d2a313f7d591ac9b41ff6bc329e68d3b2
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Aug 12 18:47:46 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/56c4d15d2a313f7d591ac9b41ff6bc329e68d3b2 [^]

related to issue 24516: [temporary fix] If instance is >=MP27 access to computed columns correctly

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceiptProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptsHeader.java
---
(0060673)
hgbot   
2013-08-20 11:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3a10c0c70392a461b7f6e9f03b82c6b911e348fa
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Aug 20 11:12:28 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3a10c0c70392a461b7f6e9f03b82c6b911e348fa [^]

Fixed issue 24516. Removed usage of deliveryStatus from the WebPOS

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceiptProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptsHeader.java
---
(0060688)
guilleaer   
2013-08-20 23:39   
Verified
(0060690)
hgbot   
2013-08-21 08:31   
Repository: erp/pmods/org.openbravo.retail.posterminal-rds
Changeset: 3a10c0c70392a461b7f6e9f03b82c6b911e348fa
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Aug 20 11:12:28 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-rds/rev/3a10c0c70392a461b7f6e9f03b82c6b911e348fa [^]

Fixed issue 24516. Removed usage of deliveryStatus from the WebPOS

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceiptProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptsHeader.java
---
(0060695)
guilleaer   
2013-08-21 08:33   
reclosing