Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024469Openbravo ERP07. Sales managementpublic2013-08-01 09:342013-08-02 10:32
Reporternaiaramartinez 
Assigned ToioritzCia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tonaiaramartinez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-10-29
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/main/rev/4f75ce8264e2 [^]
Triggers an Emergency PackNo
Summary0024469: Drop down list in 'actions regarding document' is not showing correct options when processing a payment
DescriptionThe options in the drop down list that is shown in the pop up when processing a payment, are not correct.



Steps To ReproduceConfigure in Financial Account 'Cuenta Banco' - payment method 'transfenrecia'
  Payment in: do not check automatic deposit
  Payment out: check automatic withdrawn

Go to Sales invoice window and create an invoice. Complete it.

Add a payment in for 'Cuenta de Banco' and 'Transferencia'. Process the payment.
Notice that in the pop-up, in 'action regading docuement' you can only see: 'Process Received Payment(s) and Deposit'.

It is not correct. Drop down list should show: 'Process Received Payment(s) and Deposit' and ''Process Received Payment(s)'.
Proposed SolutionActual code:

boolean forcedFinancialAccountTransaction = finAccPaymentMethod.isAutomaticDeposit() || finAccPaymentMethod.isAutomaticWithdrawn();

Proposed code:
boolean forcedFinancialAccountTransaction = isReceipt ? finAccPaymentMethod.isAutomaticDeposit() : finAccPaymentMethod.isAutomaticWithdrawn();


Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-08-01 09:34naiaramartinezNew Issue
2013-08-01 09:34naiaramartinezAssigned To => ioritzCia
2013-08-01 09:34naiaramartinezModules => Core
2013-08-01 09:34naiaramartinezTriggers an Emergency Pack => No
2013-08-01 09:35naiaramartinezRegression level => Production - Confirmed Stable
2013-08-01 09:35naiaramartinezRegression date => 2012-10-29
2013-08-01 09:35naiaramartinezRegression introduced by commit => https://code.openbravo.com/erp/devel/main/rev/4f75ce8264e2 [^]
2013-08-01 09:39naiaramartinezProposed Solution updated
2013-08-01 10:16hgbotCheckin
2013-08-01 10:16hgbotNote Added: 0060455
2013-08-01 10:16hgbotStatusnew => resolved
2013-08-01 10:16hgbotResolutionopen => fixed
2013-08-01 10:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bde9178f9f824708933aa8c50cd58c63ff29da99 [^]
2013-08-01 17:51hudsonbotCheckin
2013-08-01 17:51hudsonbotNote Added: 0060465
2013-08-02 10:32naiaramartinezReview Assigned To => naiaramartinez
2013-08-02 10:32naiaramartinezNote Added: 0060481
2013-08-02 10:32naiaramartinezStatusresolved => closed

Notes
(0060455)
hgbot   
2013-08-01 10:16   
Repository: erp/devel/pi
Changeset: bde9178f9f824708933aa8c50cd58c63ff29da99
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Thu Aug 01 10:00:53 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bde9178f9f824708933aa8c50cd58c63ff29da99 [^]

Fixes issue 24469: Drop down list in 'actions regarding document' is not showing
correct options when processing a payment.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java
---
(0060465)
hudsonbot   
2013-08-01 17:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/37aeae33b0c0 [^]

Maturity status: Test
(0060481)
naiaramartinez   
2013-08-02 10:32   
Code Review and testing OK