Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024412Openbravo ERPA. Platformpublic2013-07-26 10:482013-07-29 16:34
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP26 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2013-07-12
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b0cfc1e495435ccb1bd58f8e55bebb30bd83c634 [^]
Triggers an Emergency PackNo
Summary0024412: Random failures in FIC
DescriptionAfter applying fix for issue 0024326, FIC randomly fails.

This can be noticed in several ways:
-ERROR org.hibernate.LazyInitializationException - could not initialize proxy - no Session can be seen in the log
-when this happens, default values are not correctly populated

The problem is caused by an incomplete DAL object initialization in ApplicationDictionaryCachedStructures.getTab method, which caches and returns the tab attached to the session created for the Tab that invoked it. Previous to fix for 0024326, initialization was completed by the getParentTab method, afterwards it is not in case of root tab.

The way it can happen is:
-Request 1 (thread-1) gets a root tab. This tab, attached to thread-1's DAL session, is cached in ApplicationDictionaryCachedStructures without its proxies being initialized so thread-1's session is killed.
-Request 2 (thread-2) gets same tab from ApplicationDictionaryCachedStructures and tries to initialize any of its proxies, as the tab is still attached to thread-1's session the error is raisen
Steps To ReproduceOpen BP window and select a record, this happens randomly
Proposed SolutionTemporary backout patch for issue 0024326
Additional Information
TagsNo tags attached.
Relationships
related to defect 0024326 closed alostale Suboptimal parent tab getter for root tabs 
related to defect 00244213.0MP28 closed alostale ApplicationDictionaryCachedStructures is not thread safe 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-26 10:48alostaleNew Issue
2013-07-26 10:48alostaleAssigned To => alostale
2013-07-26 10:48alostaleModules => Core
2013-07-26 10:48alostaleTriggers an Emergency Pack => No
2013-07-26 10:48alostaleRelationship addedrelated to 0024326
2013-07-26 10:49alostaleRegression level => Pre packaging ( pi )
2013-07-26 10:49alostaleRegression date => 2013-07-12
2013-07-26 10:49alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b0cfc1e495435ccb1bd58f8e55bebb30bd83c634 [^]
2013-07-26 10:49alostaleReview Assigned To => shankarb
2013-07-26 10:59alostaleDescription Updatedbug_revision_view_page.php?rev_id=4917#r4917
2013-07-26 11:08hgbotCheckin
2013-07-26 11:08hgbotNote Added: 0060302
2013-07-26 11:08hgbotStatusnew => resolved
2013-07-26 11:08hgbotResolutionopen => fixed
2013-07-26 11:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/338d1021bc54b3e3658c8c3c7eae605600d7bf81 [^]
2013-07-26 20:32hudsonbotCheckin
2013-07-26 20:32hudsonbotNote Added: 0060317
2013-07-29 12:28alostaleRelationship addedrelated to 0024421
2013-07-29 13:10egoitzIssue Monitored: egoitz
2013-07-29 16:34shankarbNote Added: 0060352
2013-07-29 16:34shankarbStatusresolved => closed
2013-07-29 16:34shankarbFixed in Version => 3.0MP26

Notes
(0060302)
hgbot   
2013-07-26 11:08   
Repository: erp/devel/pi
Changeset: 338d1021bc54b3e3658c8c3c7eae605600d7bf81
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jul 26 11:07:34 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/338d1021bc54b3e3658c8c3c7eae605600d7bf81 [^]

fixed bug 24412, backouts fix for bug 24326

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java
---
(0060317)
hudsonbot   
2013-07-26 20:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b9e43ea5aa1b [^]

Maturity status: Test
(0060352)
shankarb   
2013-07-29 16:34   
Code reviewed and tested in pi changeset 2128830a28ff.