Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024401Openbravo ERPA. Platformpublic2013-07-23 13:082013-07-29 08:33
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP26Fixed in Version3.0MP26 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024401: Opening a window results in an additional request for the notes datasource
DescriptionOpening a window should take as little requests as possible, this can be inlined with the standard view generation. The advantage is that when views are cached by the browser that this datasource definition is not regenerated either.
Steps To ReproduceOpen any window and check the requests, see the related window
Proposed Solution
Additional Information
TagsPerformance
Relationships
Attached Filespng Selection_002.png (88,413) 2013-07-23 13:08
https://issues.openbravo.com/file_download.php?file_id=6281&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2013-07-23 13:08mtaalNew Issue
2013-07-23 13:08mtaalAssigned To => mtaal
2013-07-23 13:08mtaalFile Added: Selection_002.png
2013-07-23 13:08mtaalModules => Core
2013-07-23 13:08mtaalOBNetwork customer => No
2013-07-23 13:08mtaalTriggers an Emergency Pack => No
2013-07-23 13:08mtaalReview Assigned To => alostale
2013-07-23 13:10hgbotCheckin
2013-07-23 13:10hgbotNote Added: 0060175
2013-07-23 13:10hgbotStatusnew => resolved
2013-07-23 13:10hgbotResolutionopen => fixed
2013-07-23 13:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a4cf9374e8db821a699f3284547ffb392c552a7e [^]
2013-07-24 21:31hudsonbotCheckin
2013-07-24 21:31hudsonbotNote Added: 0060292
2013-07-29 08:31alostaleTag Attached: Performance
2013-07-29 08:33alostaleNote Added: 0060339
2013-07-29 08:33alostaleStatusresolved => closed
2013-07-29 08:33alostaleFixed in Version => 3.0MP26

Notes
(0060175)
hgbot   
2013-07-23 13:10   
Repository: erp/devel/pi
Changeset: a4cf9374e8db821a699f3284547ffb392c552a7e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 23 13:09:51 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a4cf9374e8db821a699f3284547ffb392c552a7e [^]

Fixes issue 24401: Opening a window results in an additional request for the notes datasource
Create the notes datasource in the tab on the server instead of using a separate request.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js
---
(0060292)
hudsonbot   
2013-07-24 21:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/965b32a20794 [^]

Maturity status: Test
(0060339)
alostale   
2013-07-29 08:33   
Code reviewed and verified notes DS creation is not done when opening the window.