Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024395Openbravo ERPA. Platformpublic2013-07-22 14:332013-07-24 18:56
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024395: Improve import.sample.data to skip already imported clients
DescriptionRight now workflow to install retail sampledata on a freshly installed erp is

1.) install retail modules + retail sampledata module
2.) rebuild
3.) delete core sampledata
4.) ant import.sample.data

That part 3 is a bit akward. If import.sample.data would be improved to skip already imported clients that step 3 would just not be necessary.
Steps To Reproduce-
Proposed SolutionOn import.sample.data when having found a directory containing sampledata.
First search for and parse the AD_CLIENT.xml file, then check if a client with that uuid is already present in the database. If it is -> skip important that sampledata folder and continue searching for other sampledata folders.

Implementation note:
The code first will check if the AD_CLIENT.xml file is present, in case it is not it will skip the check and just important the data.
This allow for future shipment of incremental sampledata which is inserted on top of sampledata provided by some other module.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-22 14:33shuehnerNew Issue
2013-07-22 14:33shuehnerAssigned To => shuehner
2013-07-22 14:33shuehnerModules => Core
2013-07-22 14:33shuehnerOBNetwork customer => No
2013-07-22 14:33shuehnerTriggers an Emergency Pack => No
2013-07-22 14:34shuehnerReview Assigned To => marvintm
2013-07-22 21:24hgbotCheckin
2013-07-22 21:24hgbotNote Added: 0060153
2013-07-22 21:24hgbotStatusnew => resolved
2013-07-22 21:24hgbotResolutionopen => fixed
2013-07-22 21:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/e28be33901e3de206ba2f2321d71d32705130876 [^]
2013-07-22 21:25hgbotCheckin
2013-07-22 21:25hgbotNote Added: 0060155
2013-07-22 21:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/e28be33901e3de206ba2f2321d71d32705130876 [^] => http://code.openbravo.com/erp/devel/pi/rev/c7975027a5bcd52cacc073db8d16fe188b14c5cf [^]
2013-07-23 05:33hudsonbotCheckin
2013-07-23 05:33hudsonbotNote Added: 0060163
2013-07-24 18:56marvintmStatusresolved => closed

Notes
(0060153)
hgbot   
2013-07-22 21:24   
Repository: erp/devel/dbsm-main
Changeset: e28be33901e3de206ba2f2321d71d32705130876
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jul 22 14:41:33 2013 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/e28be33901e3de206ba2f2321d71d32705130876 [^]

Fixed 24395: Skip already imported clients in ant import.sample.data
When running import.sample.data check if a client to be imported
is already in the database, if so -> skip important that client
and continue searching for other sampledata to import.
In case no ad_client.xml exists in the sampledata folder skip that new
check altogether to prepare for future incremental sampledata.

---
M src/org/openbravo/ddlutils/task/ImportSampledata.java
---
(0060155)
hgbot   
2013-07-22 21:25   
Repository: erp/devel/pi
Changeset: c7975027a5bcd52cacc073db8d16fe188b14c5cf
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jul 22 14:44:31 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c7975027a5bcd52cacc073db8d16fe188b14c5cf [^]

Fixed 24394, Fixed 24395. Commit dbsm changes to pi

---
M src-db/database/lib/dbsourcemanager.jar
---
(0060163)
hudsonbot   
2013-07-23 05:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6a3af4b90642 [^]

Maturity status: Test