Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024389Retail ModulesWeb POSpublic2013-07-22 12:382013-09-10 10:02
Reporterjecharri 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRMP27Fixed in VersionRMP27 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket22530
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024389: Problems with stock reservation and web POS
DescriptionProblems with stock reservation and web POS
Steps To Reproduce-Enable stock reservation http://wiki.openbravo.com/wiki/Stock_Reservation [^]

-Create a stock for one product with qty on hand 10
-Create a stock reservation of 9 units

-Go to web POS and create a ticket with qty=2 and same product

Verify that the order goes to "errors while importing pos data" due to a trigger M_transaction_trg2 lines
IF (v_onhand - v_reserved < ABS(NEW.movementqty)) THEN
  RAISE EXCEPTION '%', '@CannotTakeOutReservedStock@'; --OBTG:-20000--
END IF;
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff diffIssue24389_v1.diff (3,907) 2013-08-21 23:56
https://issues.openbravo.com/file_download.php?file_id=6328&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-07-22 12:38jecharriNew Issue
2013-07-22 12:38jecharriAssigned To => marvintm
2013-07-22 12:38jecharriOBNetwork customer => Yes
2013-07-22 12:38jecharriResolution time => 1377381600
2013-07-22 12:38jecharriSupport ticket => 22530
2013-08-08 03:45eintelauIssue Monitored: eintelau
2013-08-12 14:33hgbotCheckin
2013-08-12 14:33hgbotNote Added: 0060574
2013-08-12 14:33hgbotStatusnew => resolved
2013-08-12 14:33hgbotResolutionopen => fixed
2013-08-12 14:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ca15098edeb034654a92bc392dc55bcc129d0216 [^]
2013-08-12 14:39hgbotCheckin
2013-08-12 14:39hgbotNote Added: 0060575
2013-08-12 14:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ca15098edeb034654a92bc392dc55bcc129d0216 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b526b6602b40dabeed1b3675de475d3d21943d47 [^]
2013-08-12 19:01hgbotCheckin
2013-08-12 19:01hgbotNote Added: 0060578
2013-08-12 19:04hgbotCheckin
2013-08-12 19:04hgbotNote Added: 0060581
2013-08-13 08:50hgbotCheckin
2013-08-13 08:50hgbotNote Added: 0060584
2013-08-16 20:33hudsonbotCheckin
2013-08-16 20:33hudsonbotNote Added: 0060650
2013-08-16 20:33hudsonbotCheckin
2013-08-16 20:33hudsonbotNote Added: 0060651
2013-08-16 20:33hudsonbotCheckin
2013-08-16 20:33hudsonbotNote Added: 0060652
2013-08-20 12:37hgbotCheckin
2013-08-20 12:37hgbotNote Added: 0060675
2013-08-20 12:37hgbotCheckin
2013-08-20 12:37hgbotNote Added: 0060676
2013-08-20 12:45hgbotCheckin
2013-08-20 12:45hgbotNote Added: 0060677
2013-08-20 12:45hgbotCheckin
2013-08-20 12:45hgbotNote Added: 0060678
2013-08-20 13:01guilleaerNote Added: 0060680
2013-08-20 13:01guilleaerStatusresolved => new
2013-08-20 13:01guilleaerResolutionfixed => open
2013-08-20 13:01guilleaerTriggers an Emergency Pack => No
2013-08-20 13:01guilleaerTarget VersionRMP26 => RMP27
2013-08-21 08:31hgbotCheckin
2013-08-21 08:31hgbotNote Added: 0060691
2013-08-21 08:31hgbotCheckin
2013-08-21 08:31hgbotNote Added: 0060692
2013-08-21 09:01hgbotCheckin
2013-08-21 09:01hgbotNote Added: 0060696
2013-08-21 10:40hgbotCheckin
2013-08-21 10:40hgbotNote Added: 0060698
2013-08-21 18:59hudsonbotCheckin
2013-08-21 18:59hudsonbotNote Added: 0060715
2013-08-21 18:59hudsonbotCheckin
2013-08-21 18:59hudsonbotNote Added: 0060716
2013-08-21 23:56guilleaerFile Added: diffIssue24389_v1.diff
2013-08-21 23:56guilleaerNote Added: 0060722
2013-08-30 11:29hgbotCheckin
2013-08-30 11:29hgbotNote Added: 0060835
2013-08-30 11:29hgbotStatusnew => resolved
2013-08-30 11:29hgbotResolutionopen => fixed
2013-08-30 11:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b526b6602b40dabeed1b3675de475d3d21943d47 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/349a5325fc81966203ab76aab4c0978bb139b92d [^]
2013-09-02 12:14marvintmReview Assigned To => marvintm
2013-09-02 12:14marvintmStatusresolved => closed
2013-09-10 09:54hgbotCheckin
2013-09-10 09:54hgbotNote Added: 0060993
2013-09-10 09:54hgbotStatusclosed => resolved
2013-09-10 09:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/349a5325fc81966203ab76aab4c0978bb139b92d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/349a5325fc81966203ab76aab4c0978bb139b92d [^]
2013-09-10 10:02guilleaerNote Added: 0061047
2013-09-10 10:02guilleaerStatusresolved => closed
2013-09-10 10:02guilleaerFixed in Version => RMP27

Notes
(0060574)
hgbot   
2013-08-12 14:33   
Repository: erp/devel/pi
Changeset: ca15098edeb034654a92bc392dc55bcc129d0216
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Aug 12 14:30:33 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ca15098edeb034654a92bc392dc55bcc129d0216 [^]

fixed issue 24389: [core part] Added a column to skip stock reservations when a transaction is added

---
M src-db/database/model/tables/M_TRANSACTION.xml
M src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0060575)
hgbot   
2013-08-12 14:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b526b6602b40dabeed1b3675de475d3d21943d47
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Aug 12 14:37:22 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b526b6602b40dabeed1b3675de475d3d21943d47 [^]

fixed issue 24389: [retail part] Stock reservation check is skiped when a transaction is created from order loader

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0060578)
hgbot   
2013-08-12 19:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7c16e85e243d587c554f2aded13b1821cd0be008
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Aug 12 17:54:23 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7c16e85e243d587c554f2aded13b1821cd0be008 [^]

realted to issue 24389: to maintain compatibility, set property using set intead of seter

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0060581)
hgbot   
2013-08-12 19:04   
Repository: erp/devel/pi
Changeset: 4080460baf195097717658087cabdede6e8581ae
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Aug 12 19:03:16 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4080460baf195097717658087cabdede6e8581ae [^]

related to issue 24389: remove log from trigger

---
M src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
---
(0060584)
hgbot   
2013-08-13 08:50   
Repository: erp/devel/pi
Changeset: 21d0baeb6c99f9d3854b9aeecf6adf0c19d9ca06
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Aug 13 08:49:20 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/21d0baeb6c99f9d3854b9aeecf6adf0c19d9ca06 [^]

related to issue 24389: return NEW is not needed in this case

---
M src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
---
(0060650)
hudsonbot   
2013-08-16 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/59a1180e7f4f [^]

Maturity status: Test
(0060651)
hudsonbot   
2013-08-16 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/59a1180e7f4f [^]

Maturity status: Test
(0060652)
hudsonbot   
2013-08-16 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/59a1180e7f4f [^]

Maturity status: Test
(0060675)
hgbot   
2013-08-20 12:37   
Repository: erp/devel/pi
Changeset: 55c000c9189778b7c6416ca834f56d43c2f846ac
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Aug 20 09:33:47 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/55c000c9189778b7c6416ca834f56d43c2f846ac [^]

related to issue 24389: backed out changeset 21d0baeb6c99

---
M src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
---
(0060676)
hgbot   
2013-08-20 12:37   
Repository: erp/devel/pi
Changeset: 8d3f43817c4f620385d6df2c5609f91e173edb9e
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Aug 20 09:37:09 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8d3f43817c4f620385d6df2c5609f91e173edb9e [^]

related to issue 24389: Backed out changesets 4080460baf19 and ca15098edeb0

---
M src-db/database/model/tables/M_TRANSACTION.xml
M src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0060677)
hgbot   
2013-08-20 12:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ae2c43d80a846844f818faa9da4b62c2ff0c241d
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Aug 20 09:40:47 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae2c43d80a846844f818faa9da4b62c2ff0c241d [^]

related to issue 24389: backed out changeset 7c16e85e243d

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0060678)
hgbot   
2013-08-20 12:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6cabfefbeba0dd555d51d3460d482e94c88f51fa
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Aug 20 09:41:32 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6cabfefbeba0dd555d51d3460d482e94c88f51fa [^]

related to issue 24389: backed out changeset b526b6602b40

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0060680)
guilleaer   
2013-08-20 13:01   
A new fix will be implemented
(0060691)
hgbot   
2013-08-21 08:31   
Repository: erp/pmods/org.openbravo.retail.posterminal-rds
Changeset: ae2c43d80a846844f818faa9da4b62c2ff0c241d
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Aug 20 09:40:47 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-rds/rev/ae2c43d80a846844f818faa9da4b62c2ff0c241d [^]

related to issue 24389: backed out changeset 7c16e85e243d

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0060692)
hgbot   
2013-08-21 08:31   
Repository: erp/pmods/org.openbravo.retail.posterminal-rds
Changeset: 6cabfefbeba0dd555d51d3460d482e94c88f51fa
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Aug 20 09:41:32 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-rds/rev/6cabfefbeba0dd555d51d3460d482e94c88f51fa [^]

related to issue 24389: backed out changeset b526b6602b40

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0060696)
hgbot   
2013-08-21 09:01   
Repository: erp/devel/api-checks
Changeset: 0837378afd54cc0068a54caa4e4f8a9a30c65578
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Aug 21 09:00:24 2013 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/0837378afd54cc0068a54caa4e4f8a9a30c65578 [^]

reverted previous change in the api due to backout of issue 24389

---
M java/reference/java.japi.gz
---
(0060698)
hgbot   
2013-08-21 10:40   
Repository: erp/devel/api-checks
Changeset: ea811632fdf2cbe35f91898f27ce7a009248f976
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Aug 21 10:39:56 2013 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/ea811632fdf2cbe35f91898f27ce7a009248f976 [^]

reverted previous change in the api due to backout of issue 24389 - Using 4186 instead of 4180

---
M java/reference/java.japi.gz
---
(0060715)
hudsonbot   
2013-08-21 18:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5a759279dc34 [^]

Maturity status: Test
(0060716)
hudsonbot   
2013-08-21 18:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5a759279dc34 [^]

Maturity status: Test
(0060722)
guilleaer   
2013-08-21 23:56   
Attached you can find the first version of the final patch which will be included in RMP27.
(0060835)
hgbot   
2013-08-30 11:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 349a5325fc81966203ab76aab4c0978bb139b92d
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Aug 30 11:22:44 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/349a5325fc81966203ab76aab4c0978bb139b92d [^]

fixed issue 24389: Inventory is updated manually calling to M_UPDATE_INVENTORY. M_Transaction triggers are not executed.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0060993)
hgbot   
2013-09-10 09:54   
Repository: erp/pmods/org.openbravo.retail.posterminal-levelpricing
Changeset: 349a5325fc81966203ab76aab4c0978bb139b92d
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Aug 30 11:22:44 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/349a5325fc81966203ab76aab4c0978bb139b92d [^]

fixed issue 24389: Inventory is updated manually calling to M_UPDATE_INVENTORY. M_Transaction triggers are not executed.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0061047)
guilleaer   
2013-09-10 10:02   
reclosed