Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024305Retail ModulesWeb POSpublic2013-07-10 12:342013-09-13 11:49
Reporteradrianromero 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRMP27Fixed in Version 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024305: Discretionary discounts may produce a discount applied not only to the receipt line.
DescriptionFor example in the following case

1 x Ale beer 9$
--> Discount/Promotion fixed 10$ applied

1 x Lager beer 8$
--> No discount applied


The total is now 7$. This is not correct, the total should be 8$, if the discount applied to a line is greater than the total of the line, the total of the line should be 0 and not spread the excess to the rest of the order
Steps To ReproduceIn description
Proposed SolutionWhen applying a discount it is not completely correct to verify that the total of the receipt is greater or equal than 0, it should be verified that the total of the line is greater or equal than 0.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0024145RMP25 closed marvintm Discretionary discount may produce negative totals. This must be avoided. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-10 12:34adrianromeroNew Issue
2013-07-10 12:34adrianromeroAssigned To => marvintm
2013-07-10 12:40adrianromeroRelationship addedrelated to 0024145
2013-07-16 11:18anherzogIssue Monitored: anherzog
2013-07-16 18:16jecharriResolution time => 1378332000
2013-07-22 09:58hgbotCheckin
2013-07-22 09:58hgbotNote Added: 0060137
2013-07-22 09:58hgbotStatusnew => resolved
2013-07-22 09:58hgbotResolutionopen => fixed
2013-07-22 09:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/f0bd2f349385c18d24f56fe65eac9cd889972c4a [^]
2013-07-24 19:07hgbotCheckin
2013-07-24 19:07hgbotNote Added: 0060289
2013-07-24 19:09guilleaerNote Added: 0060290
2013-07-24 19:09guilleaerStatusresolved => new
2013-07-24 19:09guilleaerResolutionfixed => open
2013-08-07 08:53hgbotCheckin
2013-08-07 08:53hgbotNote Added: 0060520
2013-08-07 08:53hgbotStatusnew => resolved
2013-08-07 08:53hgbotResolutionopen => fixed
2013-08-07 08:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/f0bd2f349385c18d24f56fe65eac9cd889972c4a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts-col/rev/f0bd2f349385c18d24f56fe65eac9cd889972c4a [^]
2013-08-07 08:53hgbotCheckin
2013-08-07 08:53hgbotNote Added: 0060521
2013-08-07 11:48guilleaerNote Added: 0060523
2013-08-07 11:48guilleaerStatusresolved => new
2013-08-07 11:48guilleaerResolutionfixed => open
2013-08-19 12:08marvintmTriggers an Emergency Pack => No
2013-08-19 12:08marvintmTarget VersionRMP26 => RMP27
2013-09-12 13:49hgbotCheckin
2013-09-12 13:49hgbotNote Added: 0061102
2013-09-12 13:49hgbotStatusnew => resolved
2013-09-12 13:49hgbotResolutionopen => fixed
2013-09-12 13:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts-col/rev/f0bd2f349385c18d24f56fe65eac9cd889972c4a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/f400287ff6cd6a321c4cb52cf360970c17b65ed6 [^]
2013-09-13 11:49umartirenaReview Assigned To => umartirena
2013-09-13 11:49umartirenaNote Added: 0061134
2013-09-13 11:49umartirenaStatusresolved => closed

Notes
(0060137)
hgbot   
2013-07-22 09:58   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: f0bd2f349385c18d24f56fe65eac9cd889972c4a
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Jul 22 09:58:10 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/f0bd2f349385c18d24f56fe65eac9cd889972c4a [^]

fixed issue 24305: The qty to be discounted cannot be greater than line gross

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0060289)
hgbot   
2013-07-24 19:07   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 04651ac9f07e69a24eb5d9d42794beb4f789736f
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Jul 24 19:07:32 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/04651ac9f07e69a24eb5d9d42794beb4f789736f [^]

related to issue 24305: revert previous commit because is wrong

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0060290)
guilleaer   
2013-07-24 19:09   
wrong fix.

http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/04651ac9f07e69a24eb5d9d42794beb4f789736f [^]

When affected lines are executed in the second time, we can't know if other discounts are being applied.
(0060520)
hgbot   
2013-08-07 08:53   
Repository: erp/pmods/org.openbravo.retail.discounts-col
Changeset: f0bd2f349385c18d24f56fe65eac9cd889972c4a
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Jul 22 09:58:10 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts-col/rev/f0bd2f349385c18d24f56fe65eac9cd889972c4a [^]

fixed issue 24305: The qty to be discounted cannot be greater than line gross

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0060521)
hgbot   
2013-08-07 08:53   
Repository: erp/pmods/org.openbravo.retail.discounts-col
Changeset: 04651ac9f07e69a24eb5d9d42794beb4f789736f
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Jul 24 19:07:32 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts-col/rev/04651ac9f07e69a24eb5d9d42794beb4f789736f [^]

related to issue 24305: revert previous commit because is wrong

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0060523)
guilleaer   
2013-08-07 11:48   
reopening
(0061102)
hgbot   
2013-09-12 13:49   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: f400287ff6cd6a321c4cb52cf360970c17b65ed6
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 13:49:09 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/f400287ff6cd6a321c4cb52cf360970c17b65ed6 [^]

Fixed issue 24305. If the discountedPrice of the line is lower than the discount, the discount will be set to the remaining total of the line.

---
M web/org.openbravo.retail.discounts/js/promotion-discount.js
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0061134)
umartirena   
2013-09-13 11:49   
Successfully tested and closed.