Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024248Openbravo ERPA. Platformpublic2013-07-02 17:442013-07-16 14:26
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP26Fixed in Version3.0MP26 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024248: dbsourcemanager should support managing BLOB, and the 5 images imported using ant load.logo.images should be moved to ADRD
DescriptionCurrently dbsourcemanager does not support managing blob's.

However install.source should import 5 images (blob's) into the database on initial creation and then not touch those ever on update.database.

As dbsm cannot do this there is a special 'ant load.logoimages' task with corresponding ImageToDatabaseLoder.java file which imports those 5 images into the database at the end of install.source working around this dbsm limitation.

dbsm should be enhanced to be able to manage blobs.
Then these 5 images should be moved into the ADRD dataset which does exactly what is needed here (insert the image on db creation but then never touch them again on updates)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0024249 closed shuehner API-change request: deletion of ImageToDatabaseLoader code as it has been replaced as does no longer serve any purpose. 
related to feature request 0024250 new shuehner ad_registration_info + ad_system_info tables should be loaded via ADRD 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-02 17:44shuehnerNew Issue
2013-07-02 17:44shuehnerAssigned To => shuehner
2013-07-02 17:44shuehnerModules => Core
2013-07-02 17:44shuehnerTriggers an Emergency Pack => No
2013-07-02 17:50shuehnerRelationship addedrelated to 0024249
2013-07-02 17:53shuehnerRelationship addedrelated to 0024250
2013-07-02 18:08shuehnerNote Added: 0059817
2013-07-03 11:25hgbotCheckin
2013-07-03 11:25hgbotNote Added: 0059833
2013-07-03 11:26shuehnerReview Assigned To => marvintm
2013-07-03 11:33hgbotCheckin
2013-07-03 11:33hgbotNote Added: 0059839
2013-07-03 11:33hgbotStatusnew => resolved
2013-07-03 11:33hgbotResolutionopen => fixed
2013-07-03 11:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0b9c6c0013daedfd7ebf6e2caf0e5fd9c3ac753c [^]
2013-07-05 11:17marvintmStatusresolved => closed
2013-07-05 11:17marvintmFixed in Version => 3.0MP26
2013-07-16 14:26hudsonbotCheckin
2013-07-16 14:26hudsonbotNote Added: 0060021

Notes
(0059817)
shuehner   
2013-07-02 18:08   
Technically the change moves the insertion of AD_IMAGE entries from ant load.logoimages time (just end of install.source) to the end of create.database. Same the settings of the 5 image uuid's + setting support contact string.

For Testing:
It needs to be verified that after running install.source the ad_image table does contain 5 entries for client=0 as before.
Easiest is to check 'System Information' as a system administrator user. In the 'logos' section it should show the same 5 logos in the same fields as before the change.
Also 2 of the logos show the same images, it needs to be verified that those point to different ad_image entries. That can be done by uploading a new image to one of the two fields and verifying the the 2nd field does not also change it's image.
(0059833)
hgbot   
2013-07-03 11:25   
Repository: erp/devel/dbsm-main
Changeset: 1485b28220397af0f983897ec3d880a8aafdd167
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jul 02 18:10:25 2013 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/1485b28220397af0f983897ec3d880a8aafdd167 [^]

Issue 24248: Add support for managing blobs (i.e. images) to dbsourcemanager
dbsm did already support exporting BLOB fields.
This change adds the necessary logic to also insert data having a column of
type blob. This makes it possible to i.e. manage the ad_imange table using
dbsourcemanager.

---
M src/org/apache/ddlutils/platform/PlatformImplBase.java
---
(0059839)
hgbot   
2013-07-03 11:33   
Repository: erp/devel/pi
Changeset: 0b9c6c0013daedfd7ebf6e2caf0e5fd9c3ac753c
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jul 02 18:13:56 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0b9c6c0013daedfd7ebf6e2caf0e5fd9c3ac753c [^]

Fixed 24248. Move managing images of client=0 from manual ant task to ADRD.
As now dbsourcemanager support blob. Add the AD_IMAGE table (filter client_id=0)
to the ADRD dataset and export the 5 entries for client=0 to ADRD dataset.

Add setting of the 5 fields for the images in ad_system_info table to postcreate
Add setting of support contact string to postcreate task as well.

Delete all ant tasks + java code related to old 'ant load.logoimages' tasks
as those are now no longer needed.

---
M build.xml
M src-db/database/build-create.xml
M src-db/database/lib/dbsourcemanager.jar
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src/build.xml
A src-db/database/sourcedata/referencedData/AD_IMAGE.xml
R src/org/openbravo/erpCommon/utility/ImageToDatabaseLoader.java
---
(0060021)
hudsonbot   
2013-07-16 14:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a5d5983399f [^]

Maturity status: Test