Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024247Openbravo ERPA. Platformpublic2013-07-02 14:432013-07-16 14:26
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP26Fixed in Version3.0MP26 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024247: junit test SystemServiceTest.testChangedDataSet assumes wrongly that all dataset have changes in last 600 days
DescriptionThe code in this junit test assumes that any non-empty dataset has changed in the last 600 days from now.

That holds not true for the ADRD (aka referenceddata) dataset, but that fact is hidden by a dbsm bug/non-feature.

As of now dbsm will not use any audit info from xml files and always puts 'now()' value on install.source which was hiding the problem

A future change will change this in dbsm to use audit data if present in some xml files thus breaking this junit test.

Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-02 14:43shuehnerNew Issue
2013-07-02 14:43shuehnerAssigned To => shuehner
2013-07-02 14:43shuehnerModules => Core
2013-07-02 14:43shuehnerOBNetwork customer => No
2013-07-02 14:43shuehnerTriggers an Emergency Pack => No
2013-07-03 11:26shuehnerReview Assigned To => marvintm
2013-07-03 11:33hgbotCheckin
2013-07-03 11:33hgbotNote Added: 0059838
2013-07-03 11:33hgbotStatusnew => resolved
2013-07-03 11:33hgbotResolutionopen => fixed
2013-07-03 11:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/844e3b805e0b66b144e045f0fa23721157b72bca [^]
2013-07-05 11:26marvintmStatusresolved => closed
2013-07-05 11:26marvintmFixed in Version => 3.0MP26
2013-07-16 14:26hudsonbotCheckin
2013-07-16 14:26hudsonbotNote Added: 0060020

Notes
(0059838)
hgbot   
2013-07-03 11:33   
Repository: erp/devel/pi
Changeset: 844e3b805e0b66b144e045f0fa23721157b72bca
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jul 02 14:51:54 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/844e3b805e0b66b144e045f0fa23721157b72bca [^]

Fixed 24247. Fix invalid assumption in junit-test: testChangedDataSet
When selecting a date for which we assume that after it any dataset
has changed do not pick arbitrarily 600 days before today, but pick 0
date (smallest possible date ever).

---
M src-test/org/openbravo/test/system/SystemServiceTest.java
---
(0060020)
hudsonbot   
2013-07-16 14:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a5d5983399f [^]

Maturity status: Test