Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024237Retail ModulesWeb POSpublic2013-07-01 16:592013-07-24 17:09
Reporterjecharri 
Assigned Tomarvintm 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRMP23.1 
Target VersionFixed in VersionRMP25 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024237: Wrong taxable amount in Web POS
DescriptionWrong taxable amount in Web POS

Steps To Reproduce-Configure currency with price precision 2 and standard precision 2
-Change the price of adhesive body warmers to 0.75 and work with price including taxes
-change the product tax rate to 10%
-Go to web POS and add in the ticket.
-Add 10% of discount manually with the keyboard or change the price to 0.68

You will see that taxable amount is 0.61 instead of 0.62
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-01 16:59jecharriNew Issue
2013-07-01 16:59jecharriAssigned To => marvintm
2013-07-01 16:59jecharriResolution time => 1372629600
2013-07-01 16:59jecharriIssue generated from0024195
2013-07-01 17:04jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=4848#r4848
2013-07-02 17:34hgbotCheckin
2013-07-02 17:34hgbotNote Added: 0059814
2013-07-02 17:34hgbotStatusnew => resolved
2013-07-02 17:34hgbotResolutionopen => fixed
2013-07-02 17:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51f69a104ec30d0ee24b5bfe0e052e217161dc57 [^]
2013-07-03 09:48marvintmNote Added: 0059827
2013-07-03 12:04hgbotCheckin
2013-07-03 12:04hgbotNote Added: 0059842
2013-07-03 12:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51f69a104ec30d0ee24b5bfe0e052e217161dc57 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c1eb6fef503f0dcdd59ea5764dc7d25a717b54a0 [^]
2013-07-04 16:40hgbotCheckin
2013-07-04 16:40hgbotNote Added: 0059860
2013-07-04 16:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c1eb6fef503f0dcdd59ea5764dc7d25a717b54a0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.multiorder/rev/51f69a104ec30d0ee24b5bfe0e052e217161dc57 [^]
2013-07-04 16:41hgbotCheckin
2013-07-04 16:41hgbotNote Added: 0059865
2013-07-04 16:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.multiorder/rev/51f69a104ec30d0ee24b5bfe0e052e217161dc57 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.multiorder/rev/c1eb6fef503f0dcdd59ea5764dc7d25a717b54a0 [^]
2013-07-05 16:10hgbotCheckin
2013-07-05 16:10hgbotNote Added: 0059903
2013-07-08 15:26hgbotCheckin
2013-07-08 15:26hgbotNote Added: 0059923
2013-07-24 17:09guilleaerReview Assigned To => guilleaer
2013-07-24 17:09guilleaerNote Added: 0060267
2013-07-24 17:09guilleaerStatusresolved => closed
2013-07-24 17:09guilleaerFixed in Version => RMP25

Notes
(0059814)
hgbot   
2013-07-02 17:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 51f69a104ec30d0ee24b5bfe0e052e217161dc57
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jul 02 17:34:14 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51f69a104ec30d0ee24b5bfe0e052e217161dc57 [^]

Fixed issue 24237. Fixed issue 24220. The way net and amount values in pricelists which include taxes has been reworked.
- OrderTax calculation has been moved to the end of the function. This computation will now be computed by adding up all non-rounded nets and amounts of the OrderTaxLines, and then rounding at the end.
- Multiple calls to OB.DEC have been replaced by direct calls to the BigDecimal library. This has been done to avoid losing precision on intermediate steps of the tax calculation.
- For OrderTaxLines, two new properties (netfull and amountfull) have been added. These properties are not rounded, so they can be used on calculations of the OrderTax.
- The discountedNet now not rounded, only rounded at the call to adjustPrices. This is done again not to lose precision on intermediate computations.

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0059827)
marvintm   
2013-07-03 09:48   
The previous fix is not for this issue, a fix for this issue will be committed soon.
(0059842)
hgbot   
2013-07-03 12:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c1eb6fef503f0dcdd59ea5764dc7d25a717b54a0
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jul 03 12:04:23 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c1eb6fef503f0dcdd59ea5764dc7d25a717b54a0 [^]

Fixed issue 24237. The precision of the computation of discounts using the keyboard has been improved

---
M web/org.openbravo.retail.posterminal/js/data/dataorderdiscount.js
---
(0059860)
hgbot   
2013-07-04 16:40   
Repository: erp/pmods/org.openbravo.retail.posterminal.multiorder
Changeset: 51f69a104ec30d0ee24b5bfe0e052e217161dc57
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jul 02 17:34:14 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.multiorder/rev/51f69a104ec30d0ee24b5bfe0e052e217161dc57 [^]

Fixed issue 24237. Fixed issue 24220. The way net and amount values in pricelists which include taxes has been reworked.
- OrderTax calculation has been moved to the end of the function. This computation will now be computed by adding up all non-rounded nets and amounts of the OrderTaxLines, and then rounding at the end.
- Multiple calls to OB.DEC have been replaced by direct calls to the BigDecimal library. This has been done to avoid losing precision on intermediate steps of the tax calculation.
- For OrderTaxLines, two new properties (netfull and amountfull) have been added. These properties are not rounded, so they can be used on calculations of the OrderTax.
- The discountedNet now not rounded, only rounded at the call to adjustPrices. This is done again not to lose precision on intermediate computations.

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0059865)
hgbot   
2013-07-04 16:41   
Repository: erp/pmods/org.openbravo.retail.posterminal.multiorder
Changeset: c1eb6fef503f0dcdd59ea5764dc7d25a717b54a0
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jul 03 12:04:23 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.multiorder/rev/c1eb6fef503f0dcdd59ea5764dc7d25a717b54a0 [^]

Fixed issue 24237. The precision of the computation of discounts using the keyboard has been improved

---
M web/org.openbravo.retail.posterminal/js/data/dataorderdiscount.js
---
(0059903)
hgbot   
2013-07-05 16:10   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 456c81d1c421377f8c4872bc6cac3458ef19e5b6
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Jul 05 16:10:30 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/456c81d1c421377f8c4872bc6cac3458ef19e5b6 [^]

Related to issue 24237. Related to issue 24220: Summary taxes shouldn't be included in taxes

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0059923)
hgbot   
2013-07-08 15:26   
Repository: erp/pmods/org.openbravo.retail.posterminal.multiorder
Changeset: 456c81d1c421377f8c4872bc6cac3458ef19e5b6
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Jul 05 16:10:30 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.multiorder/rev/456c81d1c421377f8c4872bc6cac3458ef19e5b6 [^]

Related to issue 24237. Related to issue 24220: Summary taxes shouldn't be included in taxes

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0060267)
guilleaer   
2013-07-24 17:09   
verified