Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024217Openbravo ERPA. Platformpublic2013-06-27 16:142013-08-20 10:04
Reporterjecharri 
Assigned Topramakrishnan 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP27Fixed in Version3.0MP27 
Merge Request Status
Review Assigned Tojecharri
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024217: Little problem with Oracle messages in the ERP
DescriptionLittle problem with Oracle messages in the ERP

Some times oracle messages are not clear

One example
ORA-20000: Line Amount Is Not Correct ORA-06512: en "TAD.GL_JOURNAL_TRG", línea 30 ORA-04088: error durante la ejecución del disparador 'TAD.GL_JOURNAL_TRG' ORA-06512: en "TAD.GL_JOURNAL_POST", línea 335
Steps To Reproduce-Working in Oracle, go to gl_journal_trg and add the following line after line AD_isTriggerEnabled()='N' THEN RETURN;
    End If;

RAISE_APPLICATION_ERROR(-20000, '@LineAmountNotCorrect@') ;

-Go to the ERP and go to window "G/L Journal"
-Create a batch, header and lines
-Try to complete the header
-It happens the same if you try to complete the batch

You will get the above error instead of
Line Amount Is Not Correct
Proposed Solution-I saw that message is set in java srcAD/org/openbravo/erpWindows/GLJournal/Header.java line 441
Additional Information
TagsMoved from MP26 to MP27
Relationships
related to defect 00241743.0MP26 closed shankarb Little problem with Oracle messages in the ERP 
Attached Filesdiff messageTranslate.diff (1,262) 2013-07-18 10:17
https://issues.openbravo.com/file_download.php?file_id=6268&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-06-27 16:14jecharriNew Issue
2013-06-27 16:14jecharriAssigned To => AugustoMauch
2013-06-27 16:14jecharriModules => Core
2013-06-27 16:14jecharriResolution time => 1374530400
2013-06-27 16:14jecharriTriggers an Emergency Pack => No
2013-06-27 16:16AugustoMauchAssigned ToAugustoMauch => shankarb
2013-06-27 16:18AugustoMauchRelationship addedrelated to 0024174
2013-06-27 16:41jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=4842#r4842
2013-06-27 16:41jecharriProposed Solution updated
2013-07-03 07:07shankarbIssue Monitored: AugustoMauch
2013-07-03 07:08shankarbReview Assigned To => AugustoMauch
2013-07-03 07:08hgbotCheckin
2013-07-03 07:08hgbotNote Added: 0059823
2013-07-03 07:08hgbotStatusnew => resolved
2013-07-03 07:08hgbotResolutionopen => fixed
2013-07-03 07:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3758cd466f44deef4b8052072c56bd49c7d6ae21 [^]
2013-07-04 16:51jecharriStatusresolved => new
2013-07-04 16:51jecharriResolutionfixed => open
2013-07-16 14:26hudsonbotCheckin
2013-07-16 14:26hudsonbotNote Added: 0060014
2013-07-18 10:17shankarbFile Added: messageTranslate.diff
2013-07-18 10:18shankarbNote Added: 0060090
2013-07-18 10:25AugustoMauchAssigned Toshankarb => dmiguelez
2013-07-18 10:27AugustoMauchNote Added: 0060091
2013-08-05 10:54jonalegriaesarteTarget Version3.0MP26 => 3.0MP27
2013-08-05 10:54jonalegriaesarteTag Attached: Moved from MP26 to MP27
2013-08-05 10:57jonalegriaesarteAssigned Todmiguelez => shankarb
2013-08-05 11:47jonalegriaesarteAssigned Toshankarb => pramakrishnan
2013-08-07 08:07pramakrishnanAssigned Topramakrishnan => shankarb
2013-08-07 08:12pramakrishnanNote Added: 0060517
2013-08-13 07:26shankarbNote Added: 0060582
2013-08-13 07:26shankarbIssue End Monitor: AugustoMauch
2013-08-13 07:26shankarbAssigned Toshankarb => pramakrishnan
2013-08-13 08:02pramakrishnanStatusnew => scheduled
2013-08-13 08:02pramakrishnanfix_in_branch => pi
2013-08-14 10:44hgbotCheckin
2013-08-14 10:44hgbotNote Added: 0060589
2013-08-14 10:44hgbotStatusscheduled => resolved
2013-08-14 10:44hgbotResolutionopen => fixed
2013-08-14 10:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/3758cd466f44deef4b8052072c56bd49c7d6ae21 [^] => http://code.openbravo.com/erp/devel/pi/rev/d6ba90dc64faacd3386f85420435d117d3726f36 [^]
2013-08-14 15:32pramakrishnanNote Added: 0060592
2013-08-14 15:32pramakrishnanStatusresolved => new
2013-08-14 15:32pramakrishnanResolutionfixed => open
2013-08-14 15:32pramakrishnanReview Assigned ToAugustoMauch => jecharri
2013-08-14 15:32pramakrishnanfix_in_branchpi =>
2013-08-14 15:34pramakrishnanStatusnew => scheduled
2013-08-14 15:34pramakrishnanfix_in_branch => pi
2013-08-14 15:34pramakrishnanStatusscheduled => resolved
2013-08-14 15:34pramakrishnanResolutionopen => fixed
2013-08-16 20:33hudsonbotCheckin
2013-08-16 20:33hudsonbotNote Added: 0060654
2013-08-20 10:04jecharriNote Added: 0060672
2013-08-20 10:04jecharriStatusresolved => closed
2013-08-20 10:04jecharriFixed in Version => 3.0MP27

Notes
(0059823)
hgbot   
2013-07-03 07:08   
Repository: erp/devel/pi
Changeset: 3758cd466f44deef4b8052072c56bd49c7d6ae21
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jul 03 10:37:43 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/3758cd466f44deef4b8052072c56bd49c7d6ae21 [^]

Fixes Issue 0024217: Little problem with Oracle messages in the ERP

Comparing for delimiter \n and if not found check for \\n. In oracle, some error stack comes without delimiting \n and some with delimiting \\n.
Now it handles both these cases.

---
M src/org/openbravo/erpCommon/utility/ErrorTextParserORACLE.java
---
(0060014)
hudsonbot   
2013-07-16 14:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a5d5983399f [^]

Maturity status: Test
(0060090)
shankarb   
2013-07-18 10:18   
Proposed solution attached
(0060091)
AugustoMauch   
2013-07-18 10:27   
When the exception in thrown (in this particular case in the FIN_AddPaymentFromJournal class), its message needs to be traslated before throwing the error (see the attached file).

A review should be done to check if this patch needs to be applied in other windows.
(0060517)
pramakrishnan   
2013-08-07 08:12   
This fix is not working when mutating trigger error is raised. So there might be some cases which is missed. Below is an example case:

1. Add the following statement in the m_productionline_trg in when updating
"Select count(*) from m_productionline where m_productionplan_id = NEW.m_productionplan_id".
2. Try to update a row in Bill of materials production -> production run -> I/O Products.
3. System throws the mutating trigger error with some oracle codes and \n
(0060582)
shankarb   
2013-08-13 07:26   
Only user defined exceptions within the range of 20000 - 30000 are parsed in the Application. This error code 4091 is not within the range and hence the whole message is getting displayed.
(0060589)
hgbot   
2013-08-14 10:44   
Repository: erp/devel/pi
Changeset: d6ba90dc64faacd3386f85420435d117d3726f36
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Tue Aug 13 11:58:10 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/d6ba90dc64faacd3386f85420435d117d3726f36 [^]

Fixes Issue 24217: Little problem with Oracle messages in the ERP

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournal.java
---
(0060592)
pramakrishnan   
2013-08-14 15:32   
Reopened to update review assigned to
(0060654)
hudsonbot   
2013-08-16 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/59a1180e7f4f [^]

Maturity status: Test
(0060672)
jecharri   
2013-08-20 10:04   
Tested and verified in client side