Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024190Openbravo ERP07. Sales managementpublic2013-06-26 10:202013-09-23 18:21
Reporterjecharri 
Assigned Topramakrishnan 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version3.0MP28 
Merge Request Status
Review Assigned Tojecharri
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024190: Impossible to book an order with discounts and promotions
DescriptionImpossible to book an order with discounts and promotions
Steps To ReproduceFirst of all go to discounts and promotions and create a price adjustement for all conditions.

1) Create Sales order for Happy Drinks
2) add 2 lines (Ale Beer and Energy Drink)
3) Book Order
4) Ship Ale Beer line and complete it
5) Reactivate order, change energy drink quantity, rebook order
6) Invoice Ale Beer line and book it
7) Reactivate order, change energy drink quantity and try to rebook order.

You will see that you will get an error and you can rebook the order.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng error.png (108,526) 2013-06-26 10:20
https://issues.openbravo.com/file_download.php?file_id=6224&type=bug
png

patch 0024190.patch (690) 2013-07-12 05:55
https://issues.openbravo.com/file_download.php?file_id=6257&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-06-26 10:20jecharriNew Issue
2013-06-26 10:20jecharriAssigned To => dmiguelez
2013-06-26 10:20jecharriFile Added: error.png
2013-06-26 10:20jecharriWeb browser => Google Chrome
2013-06-26 10:20jecharriModules => Core
2013-06-26 10:20jecharriResolution time => 1378332000
2013-06-26 10:20jecharriTriggers an Emergency Pack => No
2013-06-26 10:21jecharriAssigned Todmiguelez => jonalegriaesarte
2013-06-26 11:45eintelauIssue Monitored: eintelau
2013-07-12 05:55eintelauFile Added: 0024190.patch
2013-07-12 05:56eintelauNote Added: 0059954
2013-07-22 16:53jonalegriaesarteWeb browserGoogle Chrome => Google Chrome
2013-07-22 16:53jonalegriaesarteTarget Version3.0MP26 => 3.0MP27
2013-08-26 11:46jonalegriaesarteAssigned Tojonalegriaesarte => pramakrishnan
2013-09-02 10:12jonalegriaesarteWeb browserGoogle Chrome => Google Chrome
2013-09-02 10:12jonalegriaesarteTarget Version3.0MP27 => 3.0MP28
2013-09-08 09:34pramakrishnanStatusnew => scheduled
2013-09-08 09:34pramakrishnanfix_in_branch => pi
2013-09-08 09:36hgbotCheckin
2013-09-08 09:36hgbotNote Added: 0060969
2013-09-08 09:36hgbotStatusscheduled => resolved
2013-09-08 09:36hgbotResolutionopen => fixed
2013-09-08 09:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/988629436d33cf715d191ad3e1617a6ef5dcebce [^]
2013-09-15 09:01pramakrishnanNote Added: 0061159
2013-09-15 09:01pramakrishnanStatusresolved => new
2013-09-15 09:01pramakrishnanResolutionfixed => open
2013-09-15 09:02pramakrishnanReview Assigned To => jecharri
2013-09-15 09:02pramakrishnanWeb browserGoogle Chrome => Google Chrome
2013-09-15 09:02pramakrishnanStatusnew => scheduled
2013-09-15 09:02pramakrishnanfix_in_branchpi =>
2013-09-15 09:02pramakrishnanStatusscheduled => resolved
2013-09-15 09:02pramakrishnanResolutionopen => fixed
2013-09-17 19:02hudsonbotCheckin
2013-09-17 19:02hudsonbotNote Added: 0061225
2013-09-23 18:21jecharriNote Added: 0061359
2013-09-23 18:21jecharriStatusresolved => closed
2013-09-23 18:21jecharriFixed in Version => 3.0MP28

Notes
(0059954)
eintelau   
2013-07-12 05:56   
A simple fix for this issue is to disable calculation of promotions for invoiced lines. This can be done by adding a QtyInvoiced=0 condition to the M_PROMOTION_CALCULATE procedure as per the attached patch
(0060969)
hgbot   
2013-09-08 09:36   
Repository: erp/devel/pi
Changeset: 988629436d33cf715d191ad3e1617a6ef5dcebce
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Mon Aug 26 19:57:58 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/988629436d33cf715d191ad3e1617a6ef5dcebce [^]

Fixes Issue 0024190: Impossible to book an order with discounts and promotions

---
M src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
---
(0061159)
pramakrishnan   
2013-09-15 09:01   
Reopened to add review assigned to
(0061225)
hudsonbot   
2013-09-17 19:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1c53d622fc50 [^]

Maturity status: Test
(0061359)
jecharri   
2013-09-23 18:21   
Verified