Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024120Openbravo ERPA. Platformpublic2013-06-18 13:382013-06-20 02:08
ReporterSandrahuguet 
Assigned ToAugustoMauch 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0MP24 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2013-04-10
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/08d5a13b722bbc496c640a976d5bb319a1db44bc [^]
Triggers an Emergency PackNo
Summary0024120: The widget in reconciliation tab in financial account window does not work
DescriptionThe widget in reconciliation tab in financial account window does not work
Steps To Reproduce- Go to Financial Account and select Bank-Account 1
- Navigate to reconciliation tab and select the reconciliation number 1000006
- Open the form view
- Notice that the widget shows the message: No items to show
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-06-18 13:38SandrahuguetNew Issue
2013-06-18 13:38SandrahuguetAssigned To => AugustoMauch
2013-06-18 13:38SandrahuguetModules => Core
2013-06-18 13:38SandrahuguetOBNetwork customer => No
2013-06-18 13:38SandrahuguetTriggers an Emergency Pack => No
2013-06-18 13:53AugustoMauchNote Added: 0059492
2013-06-18 15:55AugustoMauchRegression level => Production - QA Approved
2013-06-18 15:55AugustoMauchRegression date => 2013-04-10
2013-06-18 15:55AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/08d5a13b722bbc496c640a976d5bb319a1db44bc [^]
2013-06-18 15:55AugustoMauchPriorityhigh => immediate
2013-06-18 15:55AugustoMauchSeveritymajor => critical
2013-06-18 19:54AugustoMauchReview Assigned To => alostale
2013-06-18 19:55hgbotCheckin
2013-06-18 19:55hgbotNote Added: 0059506
2013-06-18 19:55hgbotStatusnew => resolved
2013-06-18 19:55hgbotResolutionopen => fixed
2013-06-18 19:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0dfdcbb590ca545d9c263e78bb9ee08fa96165b6 [^]
2013-06-19 11:26alostaleNote Added: 0059521
2013-06-19 11:26alostaleStatusresolved => closed
2013-06-19 11:26alostaleFixed in Version => 3.0MP24
2013-06-20 02:08hudsonbotCheckin
2013-06-20 02:08hudsonbotNote Added: 0059587

Notes
(0059492)
AugustoMauch   
2013-06-18 13:53   
c988d094 196292 [http-8080-3] ERROR org.openbravo.service.datasource.DataSourceServlet - Current user/role does not have access to widget Reconciliation Details
org.openbravo.base.exception.OBSecurityException: Current user/role does not have access to widget Reconciliation Details
    at org.openbravo.client.querylist.QueryListDataSource.getData(QueryListDataSource.java:113)
    at org.openbravo.service.datasource.ReadOnlyDataSourceService.fetchJSONObject(ReadOnlyDataSourceService.java:120)
    at org.openbravo.service.datasource.ReadOnlyDataSourceService.fetch(ReadOnlyDataSourceService.java:68)
    at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:256)
    at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:678)
(0059506)
hgbot   
2013-06-18 19:55   
Repository: erp/devel/pi
Changeset: 0dfdcbb590ca545d9c263e78bb9ee08fa96165b6
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Jun 18 19:54:08 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0dfdcbb590ca545d9c263e78bb9ee08fa96165b6 [^]

Fixes issue 24120: Widgets embedded in tabs are supported again

In this changeset [1] some logic was added to restrict the access to the widgets. One of the checks consisted in throwing an exception if the widget class did not have any widget instance class associated. This makes sense for workspace widgets, but widgets embedded in tabs do not have widget instance classes.

Now, this check is only done if the widget is not embedded in a window accessible by the user.


[1] https://code.openbravo.com/erp/devel/pi/rev/08d5a13b722bbc496c640a976d5bb319a1db44bc [^]

---
M modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
---
(0059521)
alostale   
2013-06-19 11:26   
Code reviewed in pi@b631ef452dae

Executed test plan:
-Following steps to reproduce in this issue works as expected
-Role without access Financial Account window cannot retrieve widget's data
-Restrictions implemented by issue 0023520 still work
(0059587)
hudsonbot   
2013-06-20 02:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5caf871044ad [^]

Maturity status: Test