Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002407Openbravo ERP01. General setuppublic2007-12-21 13:502008-06-12 09:43
Reportercromero 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version2.40alpha-r2 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0002407: Bad format in BPLocation when Address2 is null in PostgreSQL
DescriptionIf I enter all data in the Business Partner Location window, the format is right 'Address1 - Address2 - City - ...', but, for i.e, if Address2 is missing (or any other fields), the formatted string is ''.
 
The problem is in LocationAddress_Data.xsql:
 
(TO_CHAR(table4.Address1) || ' - ' || TO_CHAR(table4.Address2) || ' - ' || TO_CHAR(table4.Postal) ...
 
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0003596 closed cromero Bad format in BPLocation when Address2 is null P 
depends on backport 0003694 closed alostale Bad format in BPLocation when Address2 is null i 
Attached Files
Issue History
Date ModifiedUsernameFieldChange

Notes
(0005996)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1855691 [^]
(0002850)
cromero   
2007-12-21 13:58   
(edited on: 2008-06-12 09:23)
Logged In: YES
user_id=1500614
Originator: YES

putting a COALESCE the problem is solved:
 
(TO_CHAR(COALESCE(table4.Address1, '')) || ' - ' || TO_CHAR(COALESCE(table4.Address2, '')) ...
 
so it's needed to edit the function AD_COLUMN_IDENTIFIER_REF_SQL and replace the line:
  v_SQL:='TO_CHAR('||p_TableRef||'.'|| p_ColumnName||')';
by
  v_SQL:='TO_CHAR(COALESCE('||p_TableRef||'.'|| p_ColumnName||',''''))';

Carlos Romero
Openbravo Team
(0002851)
cromero   
2008-01-15 17:11   
(edited on: 2008-06-12 09:23)
Logged In: YES
user_id=1500614
Originator: YES

Fixed since revision 1921.

Carlos Romero
Openbravo Team
(0002852)
cromero   
2008-04-29 01:14   
(edited on: 2008-06-12 09:23)
Logged In: YES
user_id=1500614
Originator: YES

This fix is not complete.
Also a problem occurs when you enter to the BPlocation page in edit mode because WAD doesn't insert COALESCE in the selectEdit method in the generated LocationAddressData.

If you come from the location selector now it works fine because of the changes.